Skip to content

[Due for payment 2025-06-02] [Due for payment 2025-05-30] [Report Creation UI] [$250] Expense - Not here page opens when admin clicks Move expense in member's report #62575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
8 tasks done
nlemma opened this issue May 22, 2025 · 36 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@nlemma
Copy link

nlemma commented May 22, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.49-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Admin invites member to the workspace.
  • Admin account does not have any workspace expense report in any status (open, closed, processing etc).
  1. Go to staging.new.expensify.com
  2. [Member] Go to workspace chat.
  3. [Member} Create an expense in the workspace chat.
  4. [Admin] Go to workspace chat with member.
  5. [Admin] Click on the expense preview.
  6. [Admin] Click More > Move expense.

Expected Result:

Report list will open with the current report selected.

Actual Result:

Not here page opens.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6839124_1747913566720.20250522_192759.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925612414512804213
  • Upwork Job ID: 1925612414512804213
  • Last Price Increase: 2025-05-22
  • Automatic offers:
    • twilight2294 | Contributor | 107414077
Issue OwnerCurrent Issue Owner: @slafortune
@nlemma nlemma added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 22, 2025
Copy link

melvin-bot bot commented May 22, 2025

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 22, 2025

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 22, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 22, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@grgia
Copy link
Contributor

grgia commented May 22, 2025

Likely #62270

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label May 22, 2025
@melvin-bot melvin-bot bot changed the title Expense - Not here page opens when admin clicks Move expense in member's report [$250] Expense - Not here page opens when admin clicks Move expense in member's report May 22, 2025
Copy link

melvin-bot bot commented May 22, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021925612414512804213

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 22, 2025
Copy link

melvin-bot bot commented May 22, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@trjExpensify trjExpensify changed the title [$250] Expense - Not here page opens when admin clicks Move expense in member's report [Report Creation UI] [$250] Expense - Not here page opens when admin clicks Move expense in member's report May 22, 2025
@trjExpensify trjExpensify moved this to Second Cohort - HIGH in [#whatsnext] #migrate May 22, 2025
@arosiclair
Copy link
Contributor

Likely #62270

No word from @jnowakow atm. We should confirm reverting fixes this and then get started on that.

@arosiclair
Copy link
Contributor

I reproduced in staging v9.1.49-6 and not in prod v9.1.49-0

@arosiclair arosiclair self-assigned this May 22, 2025
@trjExpensify
Copy link
Contributor

Yeah, @luacmartins @Pujan92 and I are looking into it now.

@trjExpensify
Copy link
Contributor

I can repro in the Report row as well:

2025-05-22_20-04-47.mp4

It's gotta' be something to do with the admin/approver permissions to move the expense.

@luacmartins
Copy link
Contributor

@twilight2294 all yours. Please work on a PR

@daledah
Copy link
Contributor

daledah commented May 22, 2025

In the video, employee has 2 reports, and admin has 1 report. If we open one of the employee reports then the reports list will display only the admin report, which is obviously incorrect. So we need to fix it here

@twilight2294
Copy link
Contributor

sure, thanks!, working on it ASAP

@daledah
Copy link
Contributor

daledah commented May 22, 2025

@luacmartins Could you please take a look at #62575 (comment), removing change report will only hide the bug for specific case and not fixing the actual bug here.

@luacmartins
Copy link
Contributor

We're not removing the option to change report. We're updating the flow to use the correct accountID and also only show the field as editable if there are available reports

@Pujan92
Copy link
Contributor

Pujan92 commented May 22, 2025

.filter((report) => isReportOutstanding(report, policyID) && report?.ownerAccountID === reportOwnerAccountID)

Isn't this(&& report?.ownerAccountID === reportOwnerAccountID) getting false for admin every time bcoz report ownerAccountID won't be the admin accountID?

@twilight2294
Copy link
Contributor

PR ready for review

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 22, 2025
@arosiclair arosiclair removed the DeployBlockerCash This issue or pull request should block deployment label May 23, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 23, 2025
@melvin-bot melvin-bot bot changed the title [Report Creation UI] [$250] Expense - Not here page opens when admin clicks Move expense in member's report [Due for payment 2025-05-30] [Report Creation UI] [$250] Expense - Not here page opens when admin clicks Move expense in member's report May 23, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 23, 2025
Copy link

melvin-bot bot commented May 23, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 23, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-30. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 23, 2025

@grgia @slafortune @jnowakow / @twilight2294 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 26, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-30] [Report Creation UI] [$250] Expense - Not here page opens when admin clicks Move expense in member's report [Due for payment 2025-06-02] [Due for payment 2025-05-30] [Report Creation UI] [$250] Expense - Not here page opens when admin clicks Move expense in member's report May 26, 2025
Copy link

melvin-bot bot commented May 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-06-02. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 26, 2025

@grgia @slafortune @jnowakow / @twilight2294 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: Second Cohort - HIGH
Development

No branches or pull requests