-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page. #62558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @abekkala ( |
Triggered auto assignment to @pecanoro ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.When re-moving an expense between reports, the "to" field (recipient information) briefly appears and then disappears on the reports page, creating a flickering effect. What is the root cause of that problem?The root cause was that the logic for displaying the recipient information in the What changes do you think we should make in order to solve the problem?To solve this, we introduced a new utility function In Additionally, the This separates business logic from presentation and ensures consistent behavior across the application. What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A What alternative solutions did you explore?N/A |
Job added to Upwork: https://www.upwork.com/jobs/~021925532511970505418 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 ( |
Demoting since it's a minor visual glitch |
ProposalPlease re-state the problem that we are trying to solve in this issue.To field is shown briefly when moving expense. What is the root cause of that problem?I can't perform the exact test step as QA because move report is not allowed between workspaces. I can repro it by having 2 report in the same workspace chat, with 1 report is empty. When we create a new money request, Lines 350 to 353 in 526a0e4
But after moving the expense to the empty report, What changes do you think we should make in order to solve the problem?We can return true for
(if report is undefined, then we can't know if we should show "To" or not, so it's better to not show it) What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A |
@ishpaul777 Did you have a moment to review the proposals? |
Sure @pecanoro i'll review in 1 hour |
i could not reproduce the issue with steps from QA but from steps in @bernhardoj, when moving expense the in same workspace chat to new empty report, "->" briefly appears, @bernhardoj proposal fixes that and looks good to me video
🎀 👀 🎀 |
Current assignee @pecanoro is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: V9.1.49-4
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Applausetester [email protected]
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: User Settings
Action Performed:
Expected Result:
On re-moving expense, "to" field must not briefly appear and disappear in reports page.
Actual Result:
On re-moving expense, "to" field briefly appears and disappears in reports page.
Workaround:
Unknown
Platforms:
Screenshots/Videos
1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @The text was updated successfully, but these errors were encountered: