Skip to content

[Due for payment 2025-06-02] [Due for payment 2025-05-30] Reports - Bottom modal does not close after tapping Move expenses #62502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 8 tasks
nlemma opened this issue May 21, 2025 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@nlemma
Copy link

nlemma commented May 21, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.48-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - New feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #62270
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit a manual expense.
  4. Go to Reports.
  5. Long press on the expense.
  6. Tap Select.
  7. Tap Move expenses.

Expected Result:

Bottom modal will close.

Actual Result:

Bottom modal does not close after tapping Move expenses.

On Android, the bottom modal closes after tapping Move expenses, but it reopens when tapping back button on move expenses page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6838553_1747855041162.Screen_Recording_20250522_030040_Chrome.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @alexpensify
@nlemma nlemma added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 21, 2025
Copy link

melvin-bot bot commented May 21, 2025

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 21, 2025

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 21, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 21, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nlemma
Copy link
Author

nlemma commented May 21, 2025

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@nabi-ebrahimi
Copy link
Contributor

It doesn't show the Move expense for me. I followed your directions.

@yuwenmemon
Copy link
Contributor

Hmmm... I'm not able to reproduce this

@yuwenmemon
Copy link
Contributor

Nvm I have a fix

@arosiclair
Copy link
Contributor

We CP'd just pending QA

@arosiclair
Copy link
Contributor

QA passed

@github-actions github-actions bot removed the DeployBlockerCash This issue or pull request should block deployment label May 23, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 23, 2025
@melvin-bot melvin-bot bot changed the title Reports - Bottom modal does not close after tapping Move expenses [Due for payment 2025-05-30] Reports - Bottom modal does not close after tapping Move expenses May 23, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 23, 2025
Copy link

melvin-bot bot commented May 23, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 23, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-30. 🎊

Copy link

melvin-bot bot commented May 23, 2025

@yuwenmemon @alexpensify @yuwenmemon The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 26, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-30] Reports - Bottom modal does not close after tapping Move expenses [Due for payment 2025-06-02] [Due for payment 2025-05-30] Reports - Bottom modal does not close after tapping Move expenses May 26, 2025
Copy link

melvin-bot bot commented May 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-06-02. 🎊

Copy link

melvin-bot bot commented May 26, 2025

@yuwenmemon @alexpensify @yuwenmemon The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants