-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-06-02] [Due for payment 2025-05-30] [$250] Reports - Expenses preview shown briefly when opening expenses report from header subtitle #62514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @jliexpensify ( |
Triggered auto assignment to @neil-marcellini ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
Job added to Upwork: https://www.upwork.com/jobs/~021925481058335378299 |
Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new. |
@mountiny Is this external for contributor? |
@nkdengineer yes |
@mountiny Merging #62363 will fix this problem see this RCA: #62363 (comment) |
ProposalPlease re-state the problem that we are trying to solve in this issue.When tapping on the header subtitle of an expense report, the user lands briefly on a page with the preview of the expenses of the same report, before being redirected to the report where the expenses are shown in list mode. What is the root cause of that problem?Whenever App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx Lines 126 to 129 in 6871ba9
What changes do you think we should make in order to solve the problem?We should add the check
App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx Lines 126 to 129 in 6871ba9
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)NA Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
@nkdengineer Your proposal will introduce again the original flicker bug Screen.Recording.2025-05-22.at.16.55.02.mov |
We CP'd but this still needs QA. Waiting on Applause for that |
Issue not reproducible on build build 9.1.49-6 bandicam.2025-05-22.22-39-00-775.mp41000122512.mp41000122512.1.mp4 |
@arosiclair any payments needed here, or is this being handled as part of a larger project? |
No payments here as the original PR authors handled it, we can close |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-05-30. 🎊 For reference, here are some details about the assignees on this issue:
|
@DylanDylann @jliexpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-06-02. 🎊 For reference, here are some details about the assignees on this issue:
|
@DylanDylann @jliexpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.48-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests
Action Performed:
Expected Result:
When tapping on the header subtitle, the user should be automatically navigated to expenses report.
Actual Result:
When tapping on the header subtitle of an expense report, the user lands briefly on a page with the preview of the expenses of the same report, before being redirected to the report where the expenses are shown in list mode.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6838611_1747858434762.Brief.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @jliexpensifyThe text was updated successfully, but these errors were encountered: