Skip to content

[Due for payment 2025-06-02] [Due for payment 2025-05-30] [$250] Reports - Expenses preview shown briefly when opening expenses report from header subtitle #62514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 8 tasks
nlemma opened this issue May 21, 2025 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@nlemma
Copy link

nlemma commented May 21, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.48-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

  1. Open the Expenify app.
  2. Open any workspace chat.
  3. Submit two different expenses.
  4. Navigate to "Reports"
  5. Open any of those expenses.
  6. Tap on subtitle on header to open expenses report.
  7. Note that expenses preview can be seen briefly, before expenses report is displayed.

Expected Result:

When tapping on the header subtitle, the user should be automatically navigated to expenses report.

Actual Result:

When tapping on the header subtitle of an expense report, the user lands briefly on a page with the preview of the expenses of the same report, before being redirected to the report where the expenses are shown in list mode.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6838611_1747858434762.Brief.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925481058335378299
  • Upwork Job ID: 1925481058335378299
  • Last Price Increase: 2025-05-22
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @jliexpensify
@nlemma nlemma added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 21, 2025
Copy link

melvin-bot bot commented May 21, 2025

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 21, 2025

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 21, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 21, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nlemma
Copy link
Author

nlemma commented May 21, 2025

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label May 22, 2025
@melvin-bot melvin-bot bot changed the title Reports - Expenses preview shown briefly when opening expenses report from header subtitle [$250] Reports - Expenses preview shown briefly when opening expenses report from header subtitle May 22, 2025
Copy link

melvin-bot bot commented May 22, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021925481058335378299

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 22, 2025
Copy link

melvin-bot bot commented May 22, 2025

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@nkdengineer
Copy link
Contributor

@mountiny Is this external for contributor?

@mountiny
Copy link
Contributor

@nkdengineer yes

@DylanDylann
Copy link
Contributor

@mountiny Merging #62363 will fix this problem

see this RCA: #62363 (comment)

@nkdengineer
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

When tapping on the header subtitle of an expense report, the user lands briefly on a page with the preview of the expenses of the same report, before being redirected to the report where the expenses are shown in list mode.

What is the root cause of that problem?

Whenever OpenReport API is called, isLoadingInitialReportActions is true which causes isEmptyTransactionReport is false and then the old view is displayed briefly

const isEmptyTransactionReport = transactions && transactionThreadReportID === undefined && !isLoadingInitialReportActions;
const shouldDisplayMoneyRequestActionsList = !!isEmptyTransactionReport && shouldDisplayReportTableView(report, transactions);
const reportHeaderView = useMemo(

What changes do you think we should make in order to solve the problem?

We should add the check reportActions length here to avoid the flicker if we've already fetched it. As what I see in #62363, we always display the skeleton that can also cause the loading is displayed every time we visit this report that triggers OpenReport API.

const isEmptyTransactionReport = transactions && transactionThreadReportID === undefined && (!isLoadingInitialReportActions || reportActions.length > 0);

const isEmptyTransactionReport = transactions && transactionThreadReportID === undefined && !isLoadingInitialReportActions;
const shouldDisplayMoneyRequestActionsList = !!isEmptyTransactionReport && shouldDisplayReportTableView(report, transactions);
const reportHeaderView = useMemo(

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@DylanDylann
Copy link
Contributor

@nkdengineer Your proposal will introduce again the original flicker bug

Screen.Recording.2025-05-22.at.16.55.02.mov

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels May 22, 2025
@arosiclair
Copy link
Contributor

We CP'd but this still needs QA. Waiting on Applause for that

@izarutskaya
Copy link

Issue not reproducible on build build 9.1.49-6
Web/mWeb/Android

bandicam.2025-05-22.22-39-00-775.mp4
1000122512.mp4
1000122512.1.mp4

@arosiclair arosiclair removed the DeployBlockerCash This issue or pull request should block deployment label May 22, 2025
@jliexpensify
Copy link
Contributor

@arosiclair any payments needed here, or is this being handled as part of a larger project?

@mountiny
Copy link
Contributor

No payments here as the original PR authors handled it, we can close

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 23, 2025
@melvin-bot melvin-bot bot changed the title [$250] Reports - Expenses preview shown briefly when opening expenses report from header subtitle [Due for payment 2025-05-30] [$250] Reports - Expenses preview shown briefly when opening expenses report from header subtitle May 23, 2025
Copy link

melvin-bot bot commented May 23, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 23, 2025
Copy link

melvin-bot bot commented May 23, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-30. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 23, 2025

@DylanDylann @jliexpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 26, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-30] [$250] Reports - Expenses preview shown briefly when opening expenses report from header subtitle [Due for payment 2025-06-02] [Due for payment 2025-05-30] [$250] Reports - Expenses preview shown briefly when opening expenses report from header subtitle May 26, 2025
Copy link

melvin-bot bot commented May 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-06-02. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 26, 2025

@DylanDylann @jliexpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants