Refactor table view report loading state #62363

SzymczakJ · 2025-05-20T11:24:45Z

Explanation of Change

This PR adds loading skeleton for Next steps and Report Actions in ReportScreen and SearchMoneyRequestReportPage

Fixed Issues

$ #62198
PROPOSAL:

Tests

Go to report that hasn't been accessed in a long time(you can also clear onyx data to achieve that) and make sure that the loading skeleton hasn't changed:
Go to report that is already loaded(and it's transactions) and it's report actions hasn't been loaded yet, make sure that loading skeleton for report actions is shown.
Make sure that the above loading state doesn't flash too often(once every 2 seconds is often) and lookout for "jumpy" UI.

Offline tests

QA Steps

Same as tests.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

loading.od.zero.mov

same.report.akcje.mov

tylko.3.rzedy.wytlumaczenie.mov

MacOS: Desktop

melvin-bot · 2025-05-20T11:37:26Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-05-20T13:53:58Z

@SzymczakJ I also wanted to confirm, will these changes prevent the bug we have where we quickly see the report empty state folder illustration? For example, this shouldn't be happening but it currently does on staging:

CleanShot.2025-05-20.at.15.35.29.mp4

github-actions · 2025-05-20T13:54:06Z

🚧 @trjExpensify has triggered a test app build. You can view the workflow run here.

shawnborton · 2025-05-20T16:18:29Z

I still see the report empty state when I clear my cache and then load a report:

Otherwise the skeleton stuff that was added is feeling pretty good to me.

trjExpensify · 2025-05-20T16:42:53Z

I still see the report empty state when I clear my cache and then load a report:

@mountiny did you imply this issue and this PR is fixing that, or is that just for transaction thread reports? 🤔

mountiny · 2025-05-20T17:23:49Z

It might help with this case too but hard to say without testing them both together

DylanDylann · 2025-05-21T04:57:54Z

src/components/MoneyReportHeader.tsx

@@ -280,7 +281,7 @@ function MoneyReportHeader({policy, report: moneyRequestReport, transactionThrea
    const isSubmitterSameAsNextApprover = isReportOwner(moneyRequestReport) && nextApproverAccountID === moneyRequestReport?.ownerAccountID;
    const optimisticNextStep = isSubmitterSameAsNextApprover && policy?.preventSelfApproval ? buildOptimisticNextStepForPreventSelfApprovalsEnabled() : nextStep;

-    const shouldShowNextStep = isFromPaidPolicy && !!optimisticNextStep?.message?.length && !shouldShowStatusBar;
+    const shouldShowNextStep = isFromPaidPolicy && !shouldShowStatusBar;


@SzymczakJ shouldShowNextStep is also used for isMoreContentShown and shouldAddGapToContents. Does this change impact on it?

Good catch, from what I know(this knowledge comes from @trjExpensify) we are always showing the next steps in expense Reports(this kind of reports always has MoneyReportHeader) and never(at least for now) for the invoice reports(this is the only other report type that uses MoneyReportHeader).
I've added !isInvoiceReport check to reflect it.
So when the shouldShowNextStep is true, the isMoreContentShown is also true, and "more content" is either skeleton or real next steps and we don't need to worry about optimisticNextStep?.message?.length.

src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

DylanDylann · 2025-05-21T05:11:29Z

src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

+                    entering={FadeIn}
+                    exiting={FadeOut}
+                >
+                    {hasComments || isLoadingReportActions ? translate('common.comments') : ''}


Why do we need to hasComments condition?

Previously, we didn't show the comments string when there were no comments, so this condition comes from the past.

DylanDylann · 2025-05-21T05:16:18Z

@shawnborton I think this bug will be handled here

shawnborton · 2025-05-21T09:27:54Z

Ah that's great to hear, cc @martasudol to confirm!

mountiny · 2025-05-21T12:23:12Z

#62276 merged so we could retest once main is merged here too

github-actions · 2025-05-21T12:55:27Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-21T12:59:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄


Desktop 💻	Web 🕸️
❌ FAILED ❌	https://62363.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

DylanDylann · 2025-05-22T04:40:50Z

@SzymczakJ Could you please remove reportActions.length === 0 condition in here?

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Line 163 in 6871ba9

    
           if (!!(isLoadingInitialReportActions && reportActions.length === 0 && !isOffline) || !transactions) {

Ref: #62276 (comment)

DylanDylann · 2025-05-22T05:32:11Z

The rest seems fine

DylanDylann · 2025-05-22T05:32:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-22.at.12.28.53.mov

Android: mWeb Chrome

Screen.Recording.2025-05-22.at.12.27.30.mov

iOS: HybridApp

Screen.Recording.2025-05-22.at.12.31.20.mov

iOS: mWeb Safari

Screen.Recording.2025-05-22.at.12.30.36.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-22.at.12.24.12.mov

MacOS: Desktop

Screen.Recording.2025-05-22.at.12.25.47.mov

SzymczakJ · 2025-05-22T08:14:16Z

All the PR comments fixed @DylanDylann

DylanDylann · 2025-05-22T09:31:54Z

@SzymczakJ Failed test, please

DylanDylann

LGTM

mountiny

2 small things

mountiny · 2025-05-23T09:13:41Z

src/components/MoneyReportHeaderStatusBarSkeleton.tsx

+            </SkeletonViewContentLoader>
+        </View>
+    );
+}


displayName

mountiny · 2025-05-23T09:14:22Z

src/components/MoneyRequestReportView/ReportActionsListLoadingSkeleton.tsx

+            <ReportActionsSkeletonView possibleVisibleContentItems={3} />
+        </Animated.View>
+    );
+}


Display name

OSBotify · 2025-05-23T10:10:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-23T19:31:16Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.51-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-26T19:17:05Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.51-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

SzymczakJ added 3 commits May 20, 2025 12:48

refactor loading state logic in ReportScreen

19f893e

add loading report actions logic to MoneyRequestReportView

5102271

Merge branch 'main' into @szymczak/table-view-report-loading-state

0e0b101

SzymczakJ marked this pull request as ready for review May 20, 2025 11:37

SzymczakJ requested a review from a team as a code owner May 20, 2025 11:37

melvin-bot bot requested a review from DylanDylann May 20, 2025 11:37

melvin-bot bot removed the request for review from a team May 20, 2025 11:37

This comment has been minimized.

Sign in to view

mountiny assigned SzymczakJ May 20, 2025

mountiny self-requested a review May 20, 2025 15:44

DylanDylann reviewed May 21, 2025

View reviewed changes

DylanDylann mentioned this pull request May 21, 2025

fix: blinking empty state for transaction reports #62276

Merged

51 tasks

fix PR comments

fe0d59f

Merge branch 'main' into @szymczak/table-view-report-loading-state

c554e97

DylanDylann approved these changes May 22, 2025

View reviewed changes

DylanDylann mentioned this pull request May 22, 2025

[Due for payment 2025-06-02] [Due for payment 2025-05-30] [$250] Reports - Expenses preview shown briefly when opening expenses report from header subtitle #62514

Closed

8 tasks

SzymczakJ force-pushed the @szymczak/table-view-report-loading-state branch from 544351d to c554e97 Compare May 22, 2025 11:19

SzymczakJ added 3 commits May 23, 2025 09:54

Merge branch 'main' into @szymczak/table-view-report-loading-state

f46fcc0

fix typecheck

05e2f15

polish entering animation

732873b

DylanDylann approved these changes May 23, 2025

View reviewed changes

mountiny previously approved these changes May 23, 2025

View reviewed changes

add missing display names

a155fb8

SzymczakJ dismissed mountiny’s stale review via a155fb8 May 23, 2025 09:40

mountiny approved these changes May 23, 2025

View reviewed changes

mountiny merged commit f55a92e into Expensify:main May 23, 2025
17 checks passed

github-actions bot mentioned this pull request May 23, 2025

Deploy Checklist: New Expensify 2025-05-23 #62662

Closed

This was referenced May 24, 2025

[Due for payment 2025-06-05] [Due for payment 2025-06-02] Expense - Next step action shows skeleton loading when workflows are disabled #62685

Open

Revert "Refactor table view report loading state" #62708

Closed

lakchote mentioned this pull request May 26, 2025

[$250] Report -"Wating for you to submit expense" becomes infinite loading when changing report´s WS #62729

Open

8 tasks

melvin-bot bot mentioned this pull request May 26, 2025

[Due for payment 2025-06-02] [Better Expense Report View] Add the skeleton loading UI when clicking into a report from a preview in a chat. #62198

Closed

Refactor table view report loading state #62363

Refactor table view report loading state #62363

Uh oh!

Conversation

SzymczakJ commented May 20, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 20, 2025

Uh oh!

shawnborton commented May 20, 2025

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

This comment has been minimized.

shawnborton commented May 20, 2025

Uh oh!

trjExpensify commented May 20, 2025

Uh oh!

mountiny commented May 20, 2025

Uh oh!

DylanDylann May 21, 2025

Choose a reason for hiding this comment

Uh oh!

SzymczakJ May 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DylanDylann May 21, 2025

Choose a reason for hiding this comment

Uh oh!

SzymczakJ May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented May 21, 2025

Uh oh!

shawnborton commented May 21, 2025

Uh oh!

mountiny commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

DylanDylann commented May 22, 2025

Uh oh!

DylanDylann commented May 22, 2025

Uh oh!

DylanDylann commented May 22, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

SzymczakJ commented May 22, 2025

Uh oh!

DylanDylann commented May 22, 2025

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny May 23, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 23, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

SzymczakJ May 21, 2025 •

edited

Loading