Skip to content

Deploy Checklist: New Expensify 2025-05-23 #62662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions bot opened this issue May 23, 2025 · 39 comments
Open

Deploy Checklist: New Expensify 2025-05-23 #62662

github-actions bot opened this issue May 23, 2025 · 39 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Release Version: 9.1.51-10
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@gleitebr gleitebr added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 23, 2025
@IuliiaHerets
Copy link

IuliiaHerets commented May 23, 2025

The following PRs were deployed in the previous builds.
Checking off.
#60171
#62626
#62644
#62654

Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.51-0 🚀

@marcaaron
Copy link
Contributor

#62704 is expected behavior

@IuliiaHerets
Copy link

@IuliiaHerets
Copy link

Regression is completed.

Unchecked PRs
#60997 is failing with #62728, #62731, #62688 and #62745
#61170 - pending validation on all platforms
#61532 - failed on Web with #62741
#62071 - failed with #62703
#62216 - failed with #62709
#62244 - failed on Desktop with #62713
#62363 - pending validation on Desktop,
#62482 - failed with #60013
#62583 - failed with #62746

Blockers

#62669
#62672
#62674
#62675
#62676
#62677
#62678
#62679
#62680
#62682
#62685
#62686
#62688
#62689
#62692
#62693
#62695
#62697
#62700
#62702
#62703
#62706
#62707
#62709
#62711
#62712
#62713
#62714
#62716
#62717
#62719
#62721
#62722
#62723
#62724
#62725
#62727
#62728
#62729
#62730
#62731
#62735
#62741
#62742
#62745

@MariaHCD
Copy link
Contributor

MariaHCD commented May 26, 2025

Checked off #62637 (under Internal QA) as the associated Web-E PR has not been deployed to staging yet

@mountiny
Copy link
Contributor

Demoted #62723

@Beamanator
Copy link
Contributor

Demoted #62680 since it was fixed by a revert, but not closing b/c it has a PR in progress for a future fix

@Beamanator
Copy link
Contributor

Demoted #62672 for same reason (fixed in a mega revert)

@Beamanator
Copy link
Contributor

Beamanator commented May 26, 2025

Checked off #62727 b/c the critical part was fixed in #62784

@Beamanator
Copy link
Contributor

Beamanator commented May 26, 2025

@mollfpr
Copy link
Contributor

mollfpr commented May 26, 2025

Demoting #62713 for reason

@IuliiaHerets
Copy link

CP #62768 failed for native apps with issue #62719, build 9.1.51-3

@Beamanator
Copy link
Contributor

Beamanator commented May 26, 2025

#62748 and #62751 were closed b/c intended behavior

@marcaaron
Copy link
Contributor

marcaaron commented May 26, 2025

Demoting #62731 #62774 #62775

@Beamanator
Copy link
Contributor

Demoting #62711 since it doesn't look big enough to be a blocker

@Beamanator
Copy link
Contributor

#62763 was demoted, checked it off

@Beamanator
Copy link
Contributor

#62682 and #62692 were fixed by #62701 👍

@Beamanator
Copy link
Contributor

demoted #62686 as fixed by BE PR

@Beamanator
Copy link
Contributor

Demoted #62725 as it's tiny & bug is hidden behind beta

@Beamanator
Copy link
Contributor

Demoted #62722 as well since it's a small bug

@Beamanator
Copy link
Contributor

Closed #62724 as fixed by #62798

@Beamanator
Copy link
Contributor

Demoting #62685 as fixed by #62768

@Beamanator
Copy link
Contributor

Demoting #62703 since it's a tiny bug, so also checking off its PR #62071

@Beamanator
Copy link
Contributor

Checked off #62244 b/c the reported bug wasn't a bug

@Beamanator
Copy link
Contributor

Beamanator commented May 26, 2025

Checking off #62482 as it failed with an old bug still on prod

@MarioExpensify
Copy link
Contributor

Checking off #62735 as it was reverted by #62781

@os-botify
Copy link

os-botify bot commented May 26, 2025

Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!

Copy link

melvin-bot bot commented May 26, 2025

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@rlinoz
Copy link
Contributor

rlinoz commented May 26, 2025

Demoted #62813

@Beamanator
Copy link
Contributor

Beamanator commented May 26, 2025

@Beamanator
Copy link
Contributor

#62695 was checked off as it was fixed by #62800

@Beamanator
Copy link
Contributor

Beamanator commented May 26, 2025

Demoted #62741 as not reproducible by a few people - so also checked off PR #61532

@Beamanator
Copy link
Contributor

#62729 was demoted

@Beamanator
Copy link
Contributor

#62797 demoted as fixed by #62828

@Beamanator
Copy link
Contributor

Demoted #62706 b/c not reproducible anymore in staging - also tested by QA

@melvin-bot melvin-bot bot added the Monthly KSv2 label May 27, 2025
@mvtglobally
Copy link

Regression is completed.

Unchecked PRs
#60997 - is failing with #62728, #62731, #62688 and #62745

Blockers
#62688

@Beamanator
Copy link
Contributor

Demoted #62856 b/c it's not a problem in prod & i believe the links will always be prod links

@marcaaron
Copy link
Contributor

This one should be fixed now: #62688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests