Skip to content

[CP Staging] Put Delete report Behind beta #62828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025

Conversation

allgandalf
Copy link
Contributor

Explanation of Change

Fixed Issues

$ #57466
PROPOSAL: N/A

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@allgandalf allgandalf requested a review from a team as a code owner May 26, 2025 20:54
@melvin-bot melvin-bot bot requested review from abdulrahuman5196 and removed request for a team May 26, 2025 20:54
Copy link

melvin-bot bot commented May 26, 2025

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@allgandalf allgandalf changed the title add beta to delete report Put Delete report Behind beta May 26, 2025
@allgandalf
Copy link
Contributor Author

Normal customer flow:

Screenshot 2025-05-27 at 2 26 51 AM

Beta enabled:

Screenshot 2025-05-27 at 2 27 32 AM

@chiragsalian
Copy link
Contributor

chiragsalian commented May 26, 2025

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@chiragsalian
Copy link
Contributor

Since this code helps resolve a couple of blockers, by moving the feature behind a beta we'll proceed with merging without waiting for C+ and CP-ing this. We'll test it on staging.

@chiragsalian chiragsalian merged commit f07ffca into Expensify:main May 26, 2025
15 of 17 checks passed
@Beamanator Beamanator changed the title Put Delete report Behind beta [CP Staging] Put Delete report Behind beta May 26, 2025
OSBotify pushed a commit that referenced this pull request May 26, 2025
Put Delete report Behind beta

(cherry picked from commit f07ffca)

(cherry-picked to staging by Beamanator)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 26, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mvtglobally
Copy link

@chiragsalian @allgandalf @Beamanator Anything to QA here?

@chiragsalian
Copy link
Contributor

Nope, we self QA'd when we CP-d it.
image

Delete report option doesn't show up if user is behind beta. I'll check it off the deploy checklist.

Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.1.51-9 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label May 27, 2025
Copy link
Contributor

Performance Comparison Report 📊 (1/3)

⚠️ Some tests did not pass successfully, so some results are omitted from final report: Open search router TTI, Linking, Money request

Significant Changes To Duration

Name Duration
App start time contentAppeared_To_screenTTI 903.447 ms → 1010.007 ms (+106.560 ms, +11.8%) 🔴
Show details
Name Duration
App start time contentAppeared_To_screenTTI Baseline
Mean: 903.447 ms
Stdev: 248.163 ms (27.5%)
Runs: 558.7160260006785 564.6542019993067 565.5806090012193 589.9892619997263 600.8573609963059 601.8846499994397 609.1194640025496 611.2365809977055 619.6736209988594 623.9632650017738 629.9739329963923 632.4071559980512 635.978014998138 645.7894620001316 648.7652750015259 659.506511002779 662.0552870035172 666.0817880034447 666.3807279989123 669.786151997745 696.7559619992971 713.5893390029669 731.1197770014405 731.9395459964871 740.7424900010228 755.3226540014148 766.498074002564 768.751661002636 770.4821889996529 781.8089030012488 1002.5752689987421 1004.389392003417 1038.459743000567 1057.763874001801 1075.072622001171 1091.3944230005145 1097.7899520024657 1113.2183789983392 1119.8223939985037 1119.8859589993954 1127.3252810016274 1132.0658999979496 1136.1268540024757 1136.2245519980788 1145.4545969963074 1149.2586510032415 1152.5787850022316 1162.2680839970708 1163.1844889968634 1166.5208079963923 1169.1772639974952 1169.2476530000567 1177.6444049999118 1186.9085260033607 1206.9365549981594 1225.0085629969835 1227.5698449984193 1232.7631879970431 1247.153706997633 1253.6395279988647

Current
Mean: 1010.007 ms
Stdev: 220.597 ms (21.8%)
Runs: 637.5292610004544 637.912157997489 648.0500100031495 653.7922889962792 657.2288980036974 662.7681189998984 664.6937879994512 665.170368000865 675.5418479964137 676.8606579974294 685.757781997323 689.3106110021472 697.3657509982586 727.5644380003214 742.7819179967046 744.1967779994011 772.24994199723 792.7198669984937 793.11660400033 982.3347980007529 1042.7136519998312 1046.5929720029235 1089.2885539978743 1096.87731000036 1099.7490810006857 1113.984563998878 1117.3398820012808 1119.0785380005836 1119.1372419968247 1120.3961329981685 1125.399580001831 1128.4379699975252 1131.9638120010495 1137.7415700033307 1146.3076049983501 1146.3370549976826 1149.4064380005002 1150.1415600031614 1154.940064996481 1158.1492249965668 1158.9602899998426 1162.2817070037127 1168.8224840015173 1169.851167999208 1174.6147769987583 1179.1836400032043 1181.6396400034428 1186.6604899987578 1188.646480999887 1193.8852410018444 1198.6259249970317 1200.1787300035357 1202.9301159977913 1206.4433429986238 1213.7080020010471 1215.158165000379 1235.3293429985642 1245.1868819966912 1253.0148210003972 1264.3692710027099

Copy link
Contributor

Performance Comparison Report 📊 (2/3)

Meaningless Changes To Duration (1/2)

Show entries
Name Duration
App start time nativeLaunch 24.173 ms → 25.050 ms (+0.877 ms, +3.6%)
App start time nativeLaunchEnd_To_appCreationStart 78.737 ms → 78.475 ms (-0.262 ms, ±0.0%)
App start time appCreation 77.950 ms → 77.593 ms (-0.357 ms, ±0.0%)
App start time runJsBundle 334.833 ms → 341.067 ms (+6.233 ms, +1.9%)
App start time appCreationEnd_To_contentAppeared 513.000 ms → 502.933 ms (-10.067 ms, -2.0%)
App start time TTI 1600.214 ms → 1695.824 ms (+95.610 ms, +6.0%)
App start time regularAppStart 0.021 ms → 0.020 ms (-0.000 ms, -0.5%)
App start time (CPU) 154.483 % → 154.351 % (-0.132 %, ±0.0%)
App start time (FPS) 60.000 FPS → 60.000 FPS
App start time (RAM) 339.065 MB → 341.028 MB (+1.963 MB, +0.6%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 27.861 % → 27.537 % (-0.324 %, -1.2%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 416.116 ms → 384.621 ms (-31.495 ms, -7.6%)
Report typing (CPU) 89.914 % → 90.047 % (+0.133 %, ±0.0%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 426.582 MB → 425.255 MB (-1.327 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 20.098 % → 19.872 % (-0.226 %, -1.1%)
Chat opening Chat TTI 787.531 ms → 779.512 ms (-8.018 ms, -1.0%)
Chat opening (CPU) 160.761 % → 162.478 % (+1.717 %, +1.1%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 367.345 MB → 366.606 MB (-0.740 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 30.349 % → 30.218 % (-0.132 %, ±0.0%)
Show details
Name Duration
App start time nativeLaunch Baseline
Mean: 24.173 ms
Stdev: 2.326 ms (9.6%)
Runs: 21 21 21 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 25 25 25 25 25 25 25 26 26 26 26 26 26 27 28 29 29 31 31

Current
Mean: 25.050 ms
Stdev: 3.232 ms (12.9%)
Runs: 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 24 24 24 24 25 25 25 25 25 26 26 26 26 27 27 28 28 28 29 29 30 30 30 30 31 31 32 32 34
App start time nativeLaunchEnd_To_appCreationStart Baseline
Mean: 78.737 ms
Stdev: 9.792 ms (12.4%)
Runs: 59 64 64 66 66 66 67 67 67 68 69 69 70 71 72 72 73 73 74 74 75 76 76 77 77 77 77 78 79 79 80 80 81 81 82 82 82 82 82 82 82 83 84 85 85 86 86 87 87 88 89 92 95 97 99 103 104

Current
Mean: 78.475 ms
Stdev: 10.058 ms (12.8%)
Runs: 58 60 63 63 65 65 65 67 68 68 69 70 70 70 71 71 71 72 72 72 72 74 74 76 76 77 78 78 78 78 79 79 79 80 80 81 82 82 82 82 82 85 85 86 86 87 87 87 88 90 90 91 92 93 93 95 95 98 103
App start time appCreation Baseline
Mean: 77.950 ms
Stdev: 10.975 ms (14.1%)
Runs: 59 59 61 61 62 64 64 64 65 67 68 68 69 69 69 70 70 72 72 72 72 73 73 73 74 74 75 76 76 78 78 79 79 79 79 80 81 81 81 82 82 83 83 84 85 86 87 87 87 89 89 92 92 95 95 96 96 96 97 108

Current
Mean: 77.593 ms
Stdev: 9.401 ms (12.1%)
Runs: 57 59 60 62 64 65 66 66 66 69 71 72 72 72 73 73 73 73 73 73 73 74 74 74 75 75 75 75 75 75 76 76 78 78 79 80 81 81 81 82 83 83 84 85 86 86 86 87 87 87 88 89 90 90 91 91 93 94 102
App start time runJsBundle Baseline
Mean: 334.833 ms
Stdev: 22.037 ms (6.6%)
Runs: 282 282 285 285 292 292 299 299 300 300 300 300 302 302 311 311 313 313 315 315 317 317 318 318 318 318 318 318 321 321 321 321 324 324 324 324 325 325 328 328 329 329 330 330 331 331 331 331 332 332 333 333 334 334 335 335 336 336 336 336 336 336 338 338 339 339 340 340 340 340 340 340 340 340 341 341 341 341 341 341 345 345 345 345 347 347 347 347 347 347 348 348 349 349 351 351 352 352 354 354 354 354 356 356 356 356 360 360 361 361 363 363 370 370 382 382 383 383 384 384

Current
Mean: 341.067 ms
Stdev: 23.034 ms (6.8%)
Runs: 289 289 292 292 309 309 311 311 312 312 315 315 315 315 316 316 317 317 320 320 320 320 322 322 322 322 323 323 324 324 325 325 327 327 328 328 328 328 329 329 331 331 332 332 332 332 333 333 334 334 334 334 334 334 335 335 336 336 338 338 339 339 339 339 341 341 341 341 343 343 344 344 344 344 346 346 348 348 349 349 349 349 350 350 352 352 355 355 355 355 356 356 356 356 359 359 363 363 367 367 367 367 367 367 368 368 369 369 378 378 383 383 384 384 388 388 390 390 391 391
App start time appCreationEnd_To_contentAppeared Baseline
Mean: 513.000 ms
Stdev: 62.454 ms (12.2%)
Runs: 412 416 422 422 424 427 435 436 439 445 446 453 455 457 461 465 470 472 473 478 479 479 479 480 490 491 492 493 493 494 497 498 510 510 512 543 544 546 548 551 552 558 566 568 569 569 570 575 576 576 585 588 589 593 601 607 609 622 629 641

Current
Mean: 502.933 ms
Stdev: 60.802 ms (12.1%)
Runs: 401 410 419 426 430 437 442 442 444 444 446 451 452 453 454 458 463 464 464 466 467 471 471 471 472 474 475 481 481 482 483 486 487 490 494 494 520 522 526 528 534 537 543 544 545 548 555 562 562 563 570 587 588 589 591 597 602 605 646 667
App start time TTI Baseline
Mean: 1600.214 ms
Stdev: 242.952 ms (15.2%)
Runs: 1239.6736209988594 1240.6542019993067 1251.0817880034447 1261.7160260006785 1277.786151997745 1295.7559619992971 1326.7894620001316 1339.5806090012193 1346.5893390029669 1363.1197770014405 1365.7652750015259 1367.7424900010228 1371.1194640025496 1372.8846499994397 1372.9892619997263 1389.0552870035172 1391.4071559980512 1393.9395459964871 1395.9632650017738 1398.2365809977055 1410.978014998138 1417.3807279989123 1421.3226540014148 1425.4821889996529 1432.9739329963923 1435.857360996306 1443.498074002564 1446.8089030012488 1449.751661002636 1469.506511002779 1630.389392003417 1650.763874001801 1682.072622001171 1685.575268998742 1696.7899520024657 1747.2245519980788 1759.3252810016274 1775.5787850022316 1784.2586510032415 1795.459743000567 1801.4545969963074 1809.1772639974952 1809.3944230005145 1843.1844889968634 1854.9085260033607 1856.6395279988647 1868.2476530000567 1871.2183789983392 1880.7631879970431 1884.8859589993954 1886.0085629969835 1901.9365549981594 1904.0658999979496 1912.5698449984193 1914.8223939985037 1916.1268540024757 1923.153706997633 1932.6444049999118 1958.5208079963923 1960.2680839970708

Current
Mean: 1695.824 ms
Stdev: 224.853 ms (13.3%)
Runs: 1277.5418479964137 1303.0500100031495 1308.6937879994512 1335.170368000865 1363.757781997323 1363.912157997489 1378.7819179967046 1380.196777999401 1383.5644380003214 1390.5292610004544 1392.11660400033 1394.24994199723 1395.8606579974294 1407.2288980036974 1435.3106110021472 1447.7922889962792 1459.7198669984937 1485.7681189998984 1493.3657509982586 1610.334798000753 1633.7136519998312 1648.5929720029235 1675.87731000036 1704.2885539978743 1714.4379699975252 1715.3398820012808 1733.9638120010495 1758.7415700033307 1769.4064380005002 1777.3076049983501 1808.8224840015173 1820.851167999208 1821.1787300035357 1843.6604899987578 1844.646480999887 1848.8852410018444 1849.1836400032043 1851.7490810006857 1858.0785380005836 1858.984563998878 1861.7080020010471 1863.9602899998426 1865.3370549976826 1872.158165000379 1877.3961329981685 1879.6147769987583 1881.4433429986238 1882.6259249970317 1895.1372419968247 1915.3293429985642 1919.1868819966912 1932.1415600031614 1935.0148210003972 1936.3692710027099 1941.2817070037127 1941.940064996481 1943.1492249965668 1944.9301159977913 1954.6396400034428 1961.399580001831
App start time regularAppStart Baseline
Mean: 0.021 ms
Stdev: 0.002 ms (11.0%)
Runs: 0.01623600721359253 0.016561001539230347 0.016805000603199005 0.017048999667167664 0.017455995082855225 0.01753699779510498 0.017659001052379608 0.017903998494148254 0.01790400594472885 0.01798500120639801 0.01827000081539154 0.018472999334335327 0.018472999334335327 0.01855500042438507 0.0186770036816597 0.01896200329065323 0.019123993813991547 0.019327998161315918 0.019409000873565674 0.01949099451303482 0.019571997225284576 0.019815996289253235 0.019857004284858704 0.019897006452083588 0.019937999546527863 0.019979000091552734 0.020101003348827362 0.020344994962215424 0.020386002957820892 0.020507000386714935 0.020507998764514923 0.02063000202178955 0.020671002566814423 0.02087400108575821 0.02111799269914627 0.021118000149726868 0.021321997046470642 0.021361999213695526 0.021362006664276123 0.02180999517440796 0.0218920037150383 0.021931998431682587 0.021932005882263184 0.02197299897670746 0.022054001688957214 0.02217700332403183 0.022339001297950745 0.022378996014595032 0.022624000906944275 0.022665001451969147 0.02278599888086319 0.023152001202106476 0.023193001747131348 0.02335599809885025 0.023763000965118408 0.023803003132343292 0.02457600086927414 0.02571599930524826 0.02652999758720398

Current
Mean: 0.020 ms
Stdev: 0.002 ms (8.5%)
Runs: 0.015706002712249756 0.01741500198841095 0.01798500120639801 0.01798500120639801 0.0186769962310791 0.018759004771709442 0.0190420001745224 0.019042998552322388 0.019043006002902985 0.019124001264572144 0.019165001809597015 0.01920599490404129 0.019286997616291046 0.019328005611896515 0.019408993422985077 0.019450001418590546 0.019491001963615417 0.0195310041308403 0.0195310041308403 0.019571997225284576 0.019612997770309448 0.019816003739833832 0.019937999546527863 0.019979000091552734 0.02001900225877762 0.02006000280380249 0.020101003348827362 0.02022300660610199 0.02034500241279602 0.020386002957820892 0.02046699821949005 0.020507998764514923 0.020629003643989563 0.02071099728345871 0.020711004734039307 0.020712003111839294 0.02075199782848358 0.020996995270252228 0.021036997437477112 0.02115900069475174 0.021199993789196014 0.021402999758720398 0.02144400030374527 0.0217289999127388 0.02180999517440796 0.022013001143932343 0.022257000207901 0.022339001297950745 0.022380001842975616 0.02262299507856369 0.022867999970912933 0.022908002138137817 0.022909000515937805 0.024943001568317413 0.02600099891424179
App start time (CPU) Baseline
Mean: 154.483 %
Stdev: 6.994 % (4.5%)
Runs: 137.57654075546725 137.8976475838327 140.74103585657372 141.34693312775505 142.547325570907 143.5146771037182 144.96202432510742 145.6066895696154 146.7556253270539 147.07162248482916 147.57011297824698 148.336291651719 148.9496686874383 149.4703004928804 149.74201645516672 151.0954394358197 151.26537476357956 152.33745460897217 152.65106623290893 152.83981114409232 152.9408044834332 153.1664559593165 153.74220336097034 153.76563709429445 154.00231555413603 154.07544454723 154.1767068273092 154.44749001652627 154.74342159225395 154.86058180894315 154.864112112901 155.60030890770858 155.89412759839541 156.17259629753792 156.46466487567395 156.63084401098934 156.88010354779735 158.03391625248642 158.46415793782177 158.4776450645035 158.70284638279625 158.75881259564764 159.01159540655797 159.87598022010988 160.22829817543973 160.47543160690566 160.4755217386421 160.7801311217578 160.8189224650954 161.02099121809502 161.15103824265725 161.17874215233724 161.89226946852287 161.95475272042327 164.02880124442967 164.3495369268025 166.20029558341813 166.80319611461047 167.09463026633549

Current
Mean: 154.351 %
Stdev: 5.242 % (3.4%)
Runs: 142.32169193752995 143.42629482071717 145.26925331516665 146.48028626161388 147.2401862940785 147.9313208089486 147.947450924224 148.31158033078898 149.41149447137477 149.55657615786325 150.42533615161057 150.84707241740279 151.00065087155826 151.22499704106997 151.323650290936 151.3807074912885 151.51488605069068 151.52850039090563 151.71005737163767 152.435935159781 152.53955504557914 152.56984572853386 153.39037461313626 153.3910478176311 153.42320898756535 153.92546318231095 154.01519716033275 154.2684637511932 154.281124497992 154.3399166092548 155.3191910715062 155.66204540719596 155.8026019620678 155.8731625558093 155.91762561225002 155.92731670061093 156.05115988356232 156.61647217645918 156.85628742514976 157.31527279244733 157.39257687665705 157.65758308039835 157.91487326637971 157.9288759758589 158.4039483572761 158.43614217203117 158.5716277865211 159.63424806729566 160.61007026384397 161.98951246374727 162.28123728123728 162.37499734894274 164.63781855127425 164.6586345381527 168.0205975303556
App start time (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
App start time (RAM) Baseline
Mean: 339.065 MB
Stdev: 8.853 MB (2.6%)
Runs: 318.490234375 321.552734375 321.95703125 325.4453125 325.599609375 325.65625 325.91015625 326.669921875 327.57421875 327.96484375 328.138671875 328.416015625 328.84375 329.36328125 331.921875 332.111328125 334.03125 334.8880208333333 336.1002604166667 336.3815104166667 336.505859375 337.05859375 337.97265625 338.638671875 339.1575520833333 339.3216145833333 339.8151041666667 340.2161458333333 340.2630208333333 340.484375 341.0052083333333 341.2669270833333 341.7838541666667 341.8854166666667 342.1354166666667 342.7786458333333 342.9596354166667 343.19921875 343.3450520833333 343.9908854166667 344.2682291666667 344.3307291666667 344.59765625 344.6666666666667 345.0693359375 345.6744791666667 346.35546875 347.1119791666667 347.2565104166667 347.50390625 347.6223958333333 348.3489583333333 349.0690104166667 350.2802734375 350.4248046875 350.7578125 351.443359375 351.7643229166667 352.7552083333333 353.79296875

Current
Mean: 341.028 MB
Stdev: 8.249 MB (2.4%)
Runs: 325.759765625 325.83984375 325.861328125 326.525390625 326.767578125 327.267578125 327.34375 328.3671875 328.572265625 329.1966145833333 330.845703125 332.3697916666667 335.0234375 335.3958333333333 336.9765625 337.80078125 338.2044270833333 338.5872395833333 338.74609375 338.7513020833333 339.08203125 339.78125 340.001953125 340.109375 340.1705729166667 340.2317708333333 340.4934895833333 340.6158854166667 341.10546875 341.34765625 341.4388020833333 341.71875 342.1315104166667 342.54296875 342.6888020833333 343.0377604166667 343.1875 344.02734375 344.6028645833333 344.9947916666667 346.1513671875 346.3841145833333 347.0651041666667 347.623046875 348.0950520833333 348.4296875 349.3802083333333 349.4401041666667 349.5234375 349.55078125 350.08203125 350.6435546875 351.4466145833333 352.0458984375 352.0729166666667 352.4401041666667 352.5611979166667 353.4427083333333 356.7369791666667
App start time (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
App start time (CPU/UI) Baseline
Mean: 27.861 %
Stdev: 2.258 % (8.1%)
Runs: 22.8 23 23.1 23.9 24 24.1 24.1 24.8 25.1 25.1 25.8 26.3 26.4 26.5 27 27.2 27.3 27.3 27.4 27.8 27.9 27.9 27.9 28 28 28 28.1 28.1 28.3 28.3 28.4 28.4 28.5 28.5 28.6 28.6 29 29 29.2 29.2 29.2 29.3 29.3 29.3 29.4 29.4 29.5 29.9 30 30 30 30.5 31.1 31.2 31.8 33.4

Current
Mean: 27.537 %
Stdev: 2.434 % (8.8%)
Runs: 22 22.6 22.9 23 23.1 24 24 25 25.3 25.4 26 26 26 26 26.1 26.5 26.6 26.7 26.7 26.7 26.8 26.9 27 27.2 27.3 27.3 27.3 27.3 27.4 27.6 27.6 27.9 27.9 27.9 28 28.4 28.5 28.6 28.6 28.7 28.8 28.8 29.2 29.3 29.3 29.3 29.4 29.5 29.9 29.9 30 31.3 31.4 31.4 32 32.1 33.2

Copy link
Contributor

Performance Comparison Report 📊 (3/3)

Meaningless Changes To Duration (2/2)

Show entries
Name Duration
App start time nativeLaunch 24.173 ms → 25.050 ms (+0.877 ms, +3.6%)
App start time nativeLaunchEnd_To_appCreationStart 78.737 ms → 78.475 ms (-0.262 ms, ±0.0%)
App start time appCreation 77.950 ms → 77.593 ms (-0.357 ms, ±0.0%)
App start time runJsBundle 334.833 ms → 341.067 ms (+6.233 ms, +1.9%)
App start time appCreationEnd_To_contentAppeared 513.000 ms → 502.933 ms (-10.067 ms, -2.0%)
App start time TTI 1600.214 ms → 1695.824 ms (+95.610 ms, +6.0%)
App start time regularAppStart 0.021 ms → 0.020 ms (-0.000 ms, -0.5%)
App start time (CPU) 154.483 % → 154.351 % (-0.132 %, ±0.0%)
App start time (FPS) 60.000 FPS → 60.000 FPS
App start time (RAM) 339.065 MB → 341.028 MB (+1.963 MB, +0.6%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 27.861 % → 27.537 % (-0.324 %, -1.2%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 416.116 ms → 384.621 ms (-31.495 ms, -7.6%)
Report typing (CPU) 89.914 % → 90.047 % (+0.133 %, ±0.0%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 426.582 MB → 425.255 MB (-1.327 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 20.098 % → 19.872 % (-0.226 %, -1.1%)
Chat opening Chat TTI 787.531 ms → 779.512 ms (-8.018 ms, -1.0%)
Chat opening (CPU) 160.761 % → 162.478 % (+1.717 %, +1.1%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 367.345 MB → 366.606 MB (-0.740 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 30.349 % → 30.218 % (-0.132 %, ±0.0%)
Show details
Name Duration
Report typing Composer typing rerender count Baseline
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Report typing Message sent Baseline
Mean: 416.116 ms
Stdev: 14.034 ms (3.4%)
Runs: 393.1763510033488 393.8327230066061 398.3005370050669 399.49434500187635 400.9404710009694 401.12577299773693 401.62963899970055 402.0506190061569 403.29858399927616 403.9665530025959 404.1515310034156 404.1693929955363 406.2152500003576 407.03234899789095 408.26098600029945 408.28055799752474 409.24475099891424 409.3696700036526 410.71451799571514 411.4873460009694 411.6007080003619 412.213134996593 413.172201000154 413.18798799812794 413.6726080030203 415.04028299450874 415.0856129974127 415.61694400012493 416.3789879977703 417.083781003952 417.86340299993753 419.0485030040145 420.0664469972253 420.1918950006366 421.2768559977412 425.61490900069475 425.7016599997878 425.7274570018053 426.28503400087357 427.9398199990392 430.92008500546217 431.75622599571943 434.0072429999709 434.1981199979782 443.9196380004287 449.5805260017514 449.7541510015726 449.9364419952035

Current
Mean: 384.621 ms
Stdev: 48.522 ms (12.6%)
Runs: 295.7022709995508 300.82686399668455 300.88020899891853 304.1988119930029 304.4552000015974 305.7786049991846 306.15022799372673 306.2928870022297 307.0826819986105 309.6291100010276 310.3468019962311 313.05578600615263 314.655680000782 314.80489099770784 316.55427999794483 321.3807779997587 324.6101080030203 388.4196780025959 388.75069200247526 397.2740480005741 401.005574002862 401.5453699976206 401.7828369960189 402.83398400247097 403.17594499886036 403.8770349994302 406.5193279981613 407.50789399445057 407.58764699846506 408.000569999218 408.27294900268316 410.5914309993386 410.71085599809885 411.3428959995508 412.7774259969592 413.415933996439 414.3785400018096 415.4503170028329 416.58899000287056 416.74259500205517 416.90555799752474 417.0640869960189 418.05505400151014 418.13867200165987 418.1508380025625 418.28780099749565 418.77266500145197 418.91813199967146 419.66650400310755 420.03487100452185 420.13667799532413 422.06197100132704 422.5147299990058 425.8087969943881 425.82527700066566 429.8769130036235 433.1175130009651 435.2666829973459 435.28397700190544 438.4269210025668
Report typing (CPU) Baseline
Mean: 89.914 %
Stdev: 3.469 % (3.9%)
Runs: 80.85336582349468 83.12055742594738 83.19864481926659 85.17949631005146 85.39075421496267 85.60840184249865 85.82528290061339 86.05071840564736 86.3088687959753 86.33021937718907 86.42328945901183 86.64833819191794 86.8326656229943 87.97322156526803 88.11902553008144 88.18109767367851 88.2731869379374 88.41940394358274 88.75170857148657 88.90651508204822 89.41552321295455 90.2259071822078 90.26001759880384 90.28771258954733 90.33805338912897 90.4236696558485 90.61348055192477 90.6798858614887 90.90359389428406 91.02484791236735 91.11551006403914 91.42513857792467 91.7053508814068 91.71627257993985 91.76145709501439 91.95956822667216 92.1267414120584 92.2517798657018 92.36586269497168 92.52674552151989 92.67315021962528 93.04587651707435 93.0817014228162 93.18939387336474 93.20628826749187 93.23187636687359 93.82640351251253 94.13030858030339 96.01448115475222 96.82574918283292 96.87259271937337

Current
Mean: 90.047 %
Stdev: 4.114 % (4.6%)
Runs: 80.89874996965924 81.75423781226101 82.39953839274787 83.7165884987656 84.39245116970699 84.7285353639831 84.8443887969618 85.20299017818587 85.73101941087826 85.83404257891111 86.05184091031177 86.2065091912811 86.49918423539874 86.68738435850882 86.88449664172582 86.91162426570594 87.12374051027386 87.28996896927715 87.422318905034 87.969285053397 88.72963807440505 89.19356999761789 89.39052231579218 89.7789127474275 89.92917425203773 89.94417681443146 90.05816930162061 90.11563342818084 90.60509714740239 91.29154246986741 91.37233226767908 91.44920453493116 91.67620481234255 91.92778240782025 91.9464283083833 91.97260041724414 91.98010773813128 92.35048986545819 92.58175673873714 92.77556022405176 92.88281766704404 92.93191622781816 93.05112356929155 93.11171043404349 93.21197949933311 93.31448142177739 93.74900655415057 93.86833107694714 94.6079788075334 94.81125516887606 94.9736274925271 95.36598211019864 95.90719366833898 95.94166744062535 96.969904625006 100.34019399792538
Report typing (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Report typing (RAM) Baseline
Mean: 426.582 MB
Stdev: 7.087 MB (1.7%)
Runs: 411.81141493055554 411.8863075657895 412.038671875 412.3330078125 413.81640625 414.39370888157896 415.15082465277777 415.52300347222223 416.8138020833333 422.51801215277777 425.0557154605263 425.328125 425.33963815789474 425.38363486842104 425.5306332236842 426.2191611842105 426.4691611842105 426.53926809210526 426.7787828947368 427.02578125 427.4409950657895 427.47808159722223 427.61793154761904 428.1272615131579 428.6097861842105 428.70814732142856 428.72574013157896 428.79464285714283 428.82890625 429.04598721590907 429.23067434210526 429.55838815789474 430.21402138157896 430.68359375 431.03885690789474 431.51171875 431.7260044642857 432.25284090909093 432.3696546052632 432.65625 433.3009982638889 434.1842105263158 435.6239720394737 435.7837890625 435.82401315789474 436.6904761904762 437.39041940789474

Current
Mean: 425.255 MB
Stdev: 6.449 MB (1.5%)
Runs: 411.02706473214283 411.06558388157896 411.25390625 411.9665798611111 413.9144736842105 414.8110119047619 415.0961681547619 416.1373697916667 416.21504934210526 418.49262152777777 419.20127467105266 419.5963541666667 419.69609375 419.7122395833333 419.8291015625 421.44140625 421.5908717105263 422.09526909722223 423.07627467105266 424.4146792763158 424.7269736842105 425.0771949404762 425.16385690789474 425.4243421052632 425.5314670138889 425.5600818452381 425.8103298611111 426.61640625 426.79408482142856 426.96768465909093 427.2372532894737 427.33963815789474 427.64019097222223 427.90542763157896 427.9407894736842 427.9736328125 428.6636904761905 428.96261160714283 429.11060855263156 429.11410361842104 429.1650904605263 429.26870888157896 429.2841282894737 429.7578125 429.8408717105263 429.8884765625 430.0291015625 430.12582236842104 430.7728515625 431.2197779605263 432.60567434210526 432.6768092105263 432.8821957236842 433.03885690789474 433.15049342105266 433.22923519736844 433.6890625 433.996484375 435.2470238095238
Report typing (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Report typing (CPU/UI) Baseline
Mean: 20.098 %
Stdev: 0.952 % (4.7%)
Runs: 17.4 18.1 18.5 18.8 18.8 18.9 18.9 19 19.1 19.2 19.2 19.4 19.4 19.5 19.6 19.6 19.7 19.7 19.8 19.9 19.9 19.9 19.9 20 20 20.1 20.1 20.2 20.3 20.3 20.3 20.4 20.5 20.5 20.8 20.8 20.9 20.9 20.9 20.9 20.9 21 21 21 21.2 21.2 21.2 21.3 21.3 21.5 21.6 21.8

Current
Mean: 19.872 %
Stdev: 0.970 % (4.9%)
Runs: 17.3 18.2 18.3 18.3 18.3 18.5 18.5 18.6 18.7 18.9 18.9 18.9 18.9 19.1 19.1 19.2 19.3 19.3 19.5 19.6 19.7 19.7 19.8 19.8 19.8 19.8 19.9 19.9 19.9 20 20 20.3 20.3 20.3 20.3 20.4 20.4 20.5 20.5 20.5 20.5 20.6 20.6 20.6 20.6 20.7 20.7 20.7 20.7 20.8 20.8 20.9 21.1 21.2 21.4 21.6 22
Chat opening Chat TTI Baseline
Mean: 787.531 ms
Stdev: 48.825 ms (6.2%)
Runs: 676.8876959979534 689.3526610061526 706.843221001327 715.2434489950538 716.2379560023546 720.9361569955945 723.0242510065436 724.1660979986191 725.8392740041018 727.175170995295 730.1171879991889 735.3132330030203 735.7003990039229 735.7014169991016 736.2467859983444 738.3817539960146 754.4128419980407 763.319296002388 765.272095002234 765.801269993186 768.0028490051627 773.1732180044055 775.6220709979534 776.8654780015349 777.8952239975333 778.3570559993386 780.3315839990973 795.5302330031991 795.9313150048256 797.8525390028954 798.6289469972253 800.5039879977703 803.6949060037732 804.6763520017266 808.479858994484 812.0210769996047 816.0141199976206 816.0804449990392 817.167073994875 817.9631350040436 819.487385995686 822.087931998074 822.547201000154 827.9442149996758 828.4444589987397 828.6586919948459 831.106446005404 833.1092530041933 835.9490970000625 840.3121349960566 844.7081310003996 845.4871430024505 847.7413330003619 848.5349130034447 849.3052170053124 851.1527919992805 861.2840579971671 861.8373619988561 863.8422860056162

Current
Mean: 779.512 ms
Stdev: 59.058 ms (7.6%)
Runs: 661.5085050016642 668.1533209979534 693.9893799945712 698.3853759989142 699.7368980050087 700.250854998827 704.7342940047383 706.7174889966846 711.6750890016556 716.1765139997005 718.9259040057659 720.891561999917 726.5168460011482 733.5857339948416 735.1276860013604 736.1004649996758 736.3102219998837 744.6193039938807 749.2138679996133 751.1077480018139 753.2010909989476 758.8359789997339 761.5698650032282 765.2425139993429 768.0021570026875 769.1545009985566 769.6877449974418 770.2121179997921 771.4208980053663 773.8571779951453 780.9705820009112 786.7482500001788 789.9470219984651 795.7905680015683 799.0764570012689 810.7624509930611 812.5840249955654 815.7346200048923 816.5077320039272 816.8913580030203 820.8888350054622 821.2230229973793 823.1671550050378 826.837890997529 830.1837569996715 834.1706140041351 835.8262939974666 836.6508790031075 837.1973880007863 847.0601399987936 847.2427169978619 851.8545740023255 854.272380001843 863.731243006885 876.9832770004869 882.7365320026875 942.2560629993677
Chat opening (CPU) Baseline
Mean: 160.761 %
Stdev: 4.023 % (2.5%)
Runs: 151.509131789673 153.12420279356886 153.77625077961147 154.37228728139783 154.56168182187324 155.41378130797 156.2641189528894 156.77427997639452 156.89513385165566 157.20310715848225 157.26810558544616 157.58517901419586 157.6646519756579 157.67119710037613 157.76573705179297 157.9112657308308 158.430157625395 158.65135804125075 158.7797160939825 159.13849110057802 159.43979138010533 159.4887725638726 159.5603756589601 159.7294986394792 159.98087213024803 160.19034809181 160.37520611736255 160.6333043047791 160.69452898995792 160.92183931388243 161.0235189403017 161.0950470014586 161.356179279258 161.3600609555854 161.64727000301875 161.67792558342288 161.7169236582404 161.77400270397905 161.95779309488734 162.13718473472898 162.27039461684592 162.90415233091787 162.9314254820337 163.0262020274704 163.32818864811003 163.61778101901794 163.7595409678006 163.7685404998385 164.93201655452586 165.39741546381583 165.53260846070683 165.75972806051496 166.3233539813849 166.60147752304164 167.8139110448406 169.02264876404737 169.09905160103182 170.54643241539017

Current
Mean: 162.478 %
Stdev: 2.674 % (1.6%)
Runs: 155.15517540414186 157.28638255926737 157.9649211785996 158.30659856353424 158.61737083601733 159.0068317220432 160.0085791320839 160.02933798247437 160.0511610794584 160.20404667619795 160.55641654659368 160.64712599340126 160.88196837876822 160.90539150137238 161.00676948663 161.06582164228348 161.11163120614285 161.28927896331768 161.35622554984008 161.4033500465172 161.40362588432612 161.43101437429732 161.77974281526025 161.99447943080057 162.00189051974073 162.08397571329462 162.18449872380617 162.27808678784788 162.3893224525859 162.44379168862633 162.5106177730721 162.83420795634953 162.85850935395857 162.886188536664 163.46632071927024 163.5419159452368 163.85990407641918 164.06968575577497 164.18011277998306 164.21252935717138 164.2807946420782 164.61296940191522 164.7207004713956 164.84788953966654 165.18790738145995 165.41039753282732 165.7131171966145 165.86932144542743 166.29462105745392 166.4831928252325 167.0170596514882 167.32613597315898 167.3792308147618 167.41411110702433
Chat opening (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Chat opening (RAM) Baseline
Mean: 367.345 MB
Stdev: 6.443 MB (1.8%)
Runs: 354.59375 356.9970703125 357.0109375 359.546875 359.58984375 359.7939453125 360.0615234375 361.064453125 361.1611328125 362.22734375 362.50859375 362.7265625 363.1625 363.26796875 363.32421875 363.56171875 363.73984375 364.003125 364.01015625 364.021875 364.2828125 364.3484375 364.3671875 364.56640625 364.576171875 364.69140625 364.78359375 364.9736328125 365.09921875 365.25625 366.2921875 366.54921875 367.0375 367.04375 367.1328125 367.271875 367.56796875 367.575 368.009375 368.4734375 368.5953125 368.97421875 369.4734375 370.62734375 371.203125 371.48671875 372.834375 373.21640625 373.65546875 374.40390625 376.015625 376.7765625 377.87421875 378.5390625 378.653125 380.3703125 380.38515625 380.69140625 383.328125

Current
Mean: 366.606 MB
Stdev: 8.767 MB (2.4%)
Runs: 352.5546875 354.892578125 355.98046875 356.1943359375 357.328125 357.560546875 357.5888671875 357.69375 357.79296875 357.94921875 357.986328125 358.21796875 358.2646484375 358.533203125 358.5703125 359.306640625 359.88984375 359.9267578125 359.978515625 360.302734375 360.42890625 361.01171875 361.078125 361.0984375 361.7900390625 363.42265625 363.44765625 364.140625 364.73984375 365.5751953125 365.689453125 366.0359375 366.54296875 368.0875 369.303125 369.4453125 369.95390625 370.47578125 370.8296875 370.91796875 370.95859375 371.64921875 371.80234375 372.5609375 372.68515625 373.35703125 374.721875 374.99296875 376.021875 377.2328125 377.28515625 378.39609375 379.67578125 380.08046875 381.30546875 383.08125 385.659375 391.128125
Chat opening (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Chat opening (CPU/UI) Baseline
Mean: 30.349 %
Stdev: 1.861 % (6.1%)
Runs: 25.4 26.4 26.4 27.6 27.9 28 28.3 28.3 28.4 28.4 28.7 28.7 29 29 29.1 29.1 29.1 29.2 29.4 29.6 29.6 29.6 29.8 29.9 30 30 30.3 30.4 30.4 30.6 30.7 30.8 30.8 30.8 31 31 31.1 31.1 31.2 31.2 31.4 31.5 31.5 31.5 31.6 31.9 32 32 32 32 32.1 32.2 32.2 32.6 32.8 33 33.1 33.5 35.4

Current
Mean: 30.218 %
Stdev: 1.894 % (6.3%)
Runs: 26 26.9 27.4 27.4 27.5 27.6 27.9 28.4 28.4 28.7 28.7 28.8 28.8 28.8 28.9 28.9 29.1 29.1 29.2 29.2 29.4 29.5 29.5 29.6 29.6 29.7 29.8 29.9 29.9 30 30 30.4 30.7 30.7 30.9 31.1 31.1 31.2 31.2 31.2 31.3 31.3 31.3 31.4 31.7 31.8 31.9 32 32 32 32.3 32.4 32.9 32.9 34.1 34.8 35.2

Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@chiragsalian
Copy link
Contributor

Not really a blocker. Also i dont see how the changes here could realistically impact performance.

@chiragsalian chiragsalian removed the DeployBlockerCash This issue or pull request should block deployment label May 27, 2025
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.1.51-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.1.52-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants