-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Pre RN 0.79] Bump flash-list
#62574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pre RN 0.79] Bump flash-list
#62574
Conversation
|
@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@marcaaron Sorry for disturbing you 😓 I marked this PR as ready for review before referencing the issue in description |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-05-22.at.9.32.29.PM.movAndroid: mWeb ChromeScreen.Recording.2025-05-22.at.9.07.19.PM.moviOS: HybridAppScreen.Recording.2025-05-22.at.9.17.02.PM.moviOS: mWeb SafariScreen.Recording.2025-05-22.at.9.04.47.PM.movMacOS: Chrome / SafariScreen.Recording.2025-05-22.at.9.03.14.PM.movMacOS: DesktopScreen.Recording.2025-05-22.at.9.10.29.PM.mov |
@war-in could you merge main please that should hopefully fix the validate action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like based on @shubham1206agra testing all is working well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this patch renamed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RecyclerListView is a dependency of flashlist: https://github.com/Shopify/flash-list/blob/242ffce982cd0d482b4736ba7b16c854bd831a22/package.json#L89
Going to ignore failing |
@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.51-0 🚀
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.51-6 🚀
|
Explanation of Change
I'm working on RN 0.79 support #60421 and I found out that the flsh-list has to be bumped because it supports React Native 0.79 since 1.7.6
It seems that we can do it effortlessly because it's backwards compatible
Fixed Issues
$ #57511
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13576
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectioncanBeMissing
param foruseOnyx
toggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2025-05-22.at.13.45.40.mov
Android: mWeb Chrome
iOS: Native
ios.-.native.mov
iOS: mWeb Safari
Uploading ios - web.mov…
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov