[Due for payment 2025-06-05] [Due for payment 2025-06-04] Test Drive - Tap the Get Started or Skip does not redirect to the #admin chat

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - new feature testing
If this was caught during regression testing, add the test name, ID and link from TestRail: #60997
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Android 13 / Xiaomi Poco F5, iOS 15.8.3 / iPhone 7 Plus, Android 13 / Chrome
App Component: Other

Action Performed:

Do the test drive

1. Create a new account (without + sign)
2. Tap skip on What's your work email modal
3. Choose Manage my team's expenses > 1-10 employees
4. Choose any accounting integration (QBO, QBD, Xero, or Sage Intacct)
5. When the test drive modal shows up, tap the Start test drive
6. Do the test drive and tap the Get started button

Skip the test drive
7. Create a new account (without + sign)
8. Tap skip on What's your work email modal
9. Choose Manage my team's expenses > 1-10 employees
10. Choose any accounting integration (QBO, QBD, Xero, or Sage Intacct)
11. When the test drive modal shows up, Tap the Skip button

Expected Result:

6. Tap the Get Started button after the test drive should be redirected to the #admin chat
7. Tap the Skip button should be redirected to the #admin chat

Actual Result:

6. Tap the Get Started button, it does not redirect to the #admin chat, only to the inbox page
7. Tap the Skip button should, it does not redirect to the #admin chat, only to the inbox page
   Note:

• This issue is not reproducible in the Web environment

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6840963_1748076547043.60997_iOS-Fail_Scenario_B.mp4

Bug6840963_1748066439046.62662_-_PR60997_-_Test_Drive_-_Tap_the_Get_Started_does_not_redirect_to_the__admin_chat.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nlemma]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Test Drive - Tap the Get Started or Skip does not redirect to the #admin chat

What is the root cause of that problem?

We navigate to inbox when we complete onboarding

App/src/libs/navigateAfterOnboarding.ts

Lines 20 to 26 in 526a0e4

	// When hasCompletedGuidedSetupFlow is true, OnboardingModalNavigator in AuthScreen is removed from the navigation stack.
	// On small screens, this removal redirects navigation to HOME. Dismissing the modal doesn't work properly,
	// so we need to specifically navigate to the last accessed report.
	if (!isSmallScreenWidth) {
	if (onboardingAdminsChatReportID && !shouldPreventOpenAdminRoom) {
	reportID = onboardingAdminsChatReportID;
	}

and then navigate to TEST_DRIVE_MODAL_ROOT

App/src/libs/navigateAfterOnboarding.ts

Line 44 in 526a0e4

Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);

here

App/src/components/TestDrive/TestDriveDemo.tsx

Lines 29 to 33 in 526a0e4

	const closeModal = useCallback(() => {
	setIsVisible(false);
	InteractionManager.runAfterInteractions(() => {
	Navigation.goBack();
	});

we navigate back so end up on inbox page on small screens instead of admins room

What changes do you think we should make in order to solve the problem?

We should get the onboardingAdminsChatReportID from onyx and move to this report when user press Get started

const [onboardingAdminsChatReportID] = useOnyx(ONYXKEYS.ONBOARDING_ADMINS_CHAT_REPORT_ID, {canBeMissing: true});
.
.
const closeModal = useCallback(() => {
    setIsVisible(false);
    InteractionManager.runAfterInteractions(() => {
        if (onboardingAdminsChatReportID) {
            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingAdminsChatReportID));
        } else {
            Navigation.goBack();
        }
    });
}, []);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[iwiznia]

Damn, just saw this issue at the end of my day, did not realize I had it assigned (I usually get a message in slack for hourlies that did not get today). Will look into it tomorrow first thing.

[danieldoglas]

I think we can assign @fabioh8010

[danieldoglas]

This is part of the test drive initiative, so they're working on fixing this

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[fabioh8010]

PR is up -> #62826

[Beamanator]

PR merged, requesting CP 🙏

[Beamanator]

Hmm after hitting Get Started I was navigated to the Concierge chat... Maybe because I used an email with a + in it?

I bet this could be NAB for today 🤔

[fabioh8010]

Hmm after hitting Get Started I was navigated to the Concierge chat... Maybe because I used an email with a + in it?

I bet this could be NAB for today 🤔

@Beamanator It's expected if you used an email with a + sign. The redirection to #admins only happens when using emails without +.

[iwiznia]

Ah nice, so closing this then

[Beamanator]

aah nice, thanks for confirming @fabioh8010 !

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.52-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Redirect admin to #admins chat after TestDrive modal #62826

If no regressions arise, payment will be issued on 2025-06-04. 🎊

For reference, here are some details about the assignees on this issue:

• @fabioh8010 does not require payment (Contractor)

[melvin-bot]

@iwiznia / @roryabraham @VictoriaExpensify @fabioh8010 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Redirect admin to #admins chat after TestDrive modal #62826

If no regressions arise, payment will be issued on 2025-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @fabioh8010 does not require payment (Contractor)

[melvin-bot]

@iwiznia / @roryabraham @VictoriaExpensify @fabioh8010 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]