fix: expense can be moved to report of deleted workspace #62583

nkdengineer · 2025-05-22T13:10:14Z

Explanation of Change

fix: expense can be moved to report of deleted workspace

Fixed Issues

$ #62552
PROPOSAL: #62552 (comment)

Tests

Create a new workspace
Go to WS chat and create a new expense
Delete this WS
Create an other WS and also create a new expense
Open expense report in the step 4
Select any expense > Move expense
Verify that the archived report doesn't appear in the list

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Create a new workspace
Go to WS chat and create a new expense
Delete this WS
Create an other WS and also create a new expense
Open expense report in the step 4
Select any expense > Move expense
Verify that the archived report doesn't appear in the list

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-21.at.15.40.46.mov

Android: mWeb Chrome

Screen.Recording.2025-05-22.at.19.59.22.mov

iOS: Native

Screen.Recording.2025-05-22.at.20.03.42.mov

iOS: mWeb Safari

Screen.Recording.2025-05-22.at.20.00.24.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-22.at.19.57.56.mov

MacOS: Desktop

Screen.Recording.2025-05-22.at.20.04.51.mov

melvin-bot · 2025-05-22T13:24:23Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

Can we add a unit test for this please?

nkdengineer · 2025-05-22T15:52:25Z

@luacmartins Added a unit test.

rojiphil · 2025-05-22T16:02:15Z

Reviewing now...

luacmartins · 2025-05-22T16:02:59Z

src/libs/ReportUtils.ts

@@ -9628,14 +9628,16 @@ function isReportOutstanding(iouReport: OnyxInputOrEntry<Report>, policyID: stri
    if (!iouReport || isEmptyObject(iouReport)) {
        return false;
    }
+    const reportNameValuePair = allReportNameValuePair?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${iouReport.reportID}`];


Will this update the view in the scenario below?

[employee] is viewing the outstanding report

[admin] removes [employee] from the policy

It seems like we're calling isReportOutstanding in the view, but the component is not actually subscribed to Onyx changes. Maybe it'd update because removing the user from the policy would technically come along other updates to policy/report which the component might be listening to so we'd trigger another call to isReportOutstanding. Just wanna confirm though

@luacmartins You're right, I tested and the list isn't updated if a report is archived. I updated to subscribe reportNameValuePair and pass it to the function.

Yea, I think using Onyx.connect in lib methods in general is a bad pattern because it can lead to bugs like this.

rojiphil · 2025-05-22T17:52:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

1_62583-android-hybrid-002.mp4

Android: mWeb Chrome

1_62583-mweb-chrome-002.mp4

iOS: HybridApp

1_62583-ios-hybrid-002.mp4

iOS: mWeb Safari

1_62583-mweb-safari-002.mp4

MacOS: Chrome / Safari

62583-web-chrome-002.mp4

MacOS: Desktop

1_62583-desktop-002.mp4

rojiphil

@lakchote @luacmartins Changes LGTM and works well. All yours.

luacmartins

LGTM

luacmartins · 2025-05-22T18:04:11Z

@lakchote all yours

OSBotify · 2025-05-23T13:32:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-23T19:31:58Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.51-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-26T19:17:47Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.51-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: expense can be moved to report of deleted workspace

b64d66a

nkdengineer marked this pull request as ready for review May 22, 2025 13:24

nkdengineer requested a review from a team as a code owner May 22, 2025 13:24

melvin-bot bot requested review from rojiphil and removed request for a team May 22, 2025 13:24

luacmartins requested changes May 22, 2025

View reviewed changes

add unit test

c62877d

run prettier

43deb2d

luacmartins assigned nkdengineer May 22, 2025

luacmartins reviewed May 22, 2025

View reviewed changes

nkdengineer added 2 commits May 22, 2025 23:18

subscribe reportNameValuePairs in component

920c9bf

revert permission

11a5b03

rojiphil approved these changes May 22, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote May 22, 2025 17:54

luacmartins previously approved these changes May 22, 2025

View reviewed changes

merge main

caad58b

nkdengineer dismissed luacmartins’s stale review via caad58b May 23, 2025 08:32

lakchote approved these changes May 23, 2025

View reviewed changes

lakchote merged commit 34d912b into Expensify:main May 23, 2025
17 checks passed

github-actions bot mentioned this pull request May 23, 2025

Deploy Checklist: New Expensify 2025-05-23 #62662

Closed

IuliiaHerets mentioned this pull request May 25, 2025

Money Requests - "Move expense" option is not shown after creating new expense #62746

Closed

8 tasks

blame-gpt mentioned this pull request May 26, 2025

Expense - Incomplete system message after moving expense's report and moving it to self DM #62763

Open

8 tasks

melvin-bot bot mentioned this pull request May 26, 2025

[Due for payment 2025-06-02] [$250] Move expense - Expense can be moved to report of deleted workspace #62552

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: expense can be moved to report of deleted workspace #62583

fix: expense can be moved to report of deleted workspace #62583

Uh oh!

nkdengineer commented May 22, 2025

Uh oh!

melvin-bot bot commented May 22, 2025

Uh oh!

luacmartins left a comment

Uh oh!

nkdengineer commented May 22, 2025

Uh oh!

rojiphil commented May 22, 2025

Uh oh!

luacmartins May 22, 2025

Uh oh!

nkdengineer May 22, 2025

Uh oh!

luacmartins May 22, 2025

Uh oh!

rojiphil commented May 22, 2025

Uh oh!

rojiphil left a comment

Uh oh!

luacmartins left a comment

Uh oh!

luacmartins commented May 22, 2025

Uh oh!

Uh oh!

OSBotify commented May 23, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

Uh oh!

fix: expense can be moved to report of deleted workspace #62583

fix: expense can be moved to report of deleted workspace #62583

Uh oh!

Conversation

nkdengineer commented May 22, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 22, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented May 22, 2025

Uh oh!

rojiphil commented May 22, 2025

Uh oh!

luacmartins May 22, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer May 22, 2025

Choose a reason for hiding this comment

Uh oh!

luacmartins May 22, 2025

Choose a reason for hiding this comment

Uh oh!

rojiphil commented May 22, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented May 22, 2025

Uh oh!

Uh oh!

OSBotify commented May 23, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

Uh oh!