[$250] Expense - Confirmation page is different when submitting unreported per diem expense via different option

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue was found while executing QA for PR #62784

Version Number: 9.1.51-6
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #62784
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.
• Workspace has per diem rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two per diem expenses in the workspace chat.
4. Click on the expense preview to go to expense report.
5. Click More > Delete.
6. Delete the report.
7. Go to self DM.
   8.Click on the per diem expense.
8. Click on the report header.
9. Click Submit it to someone.
10. Select a workspace.
11. Note that the confirmation page is the confirmation page of manual expense.
12. Close the RHP.
13. Repeat Step 9 to 12 with Categorize it and Share it with my accountant.

Expected Result:

The confirmation page when submitting unreported per diem expense should be the same when Submit it to someone, Categorize it, or Share it with my accountant are selected.

Actual Result:

When submitting unreported per diem expense via Submit it to someone, the confirmation page is the confirmation page of manual expense.
When Categorize it, or Share it with my accountant is selected, the confirmation page is the confirmation page of per diem expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021927102121543191374
• Upwork Job ID: 1927102121543191374
• Last Price Increase: 2025-05-26

Issue Owner

Current Issue Owner: @c3024

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[vincdargento]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[rlinoz]

Screen.Recording.2025-05-26.at.16.20.50.mov

I was able to reproduce in prod, so removing the blocker.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021927102121543191374

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When selecting other option than Submit to someone, the confirmation page shows per diem field.

What is the root cause of that problem?

We intentionally hide the fields if the action is SUBMIT.

App/src/components/MoneyRequestConfirmationListFooter.tsx

Lines 872 to 874 in 9401610

	{isPerDiemRequest && action !== CONST.IOU.ACTION.SUBMIT && (
	<>
	<MenuItemWithTopDescription

What changes do you think we should make in order to solve the problem?

I think we should hide it for every options.

{isPerDiemRequest && !isMovingTransactionFromTrackExpense(action) && (

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[yaqoob2ishaq4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When submitting an unreported per diem expense, the confirmation page differs based on the selected action. Choosing Submit it to someone shows the manual expense confirmation page, while Categorize it and Share it with my accountant show the per diem expense confirmation page. This inconsistency confuses users.

What is the root cause of that problem?

In MoneyRequestConfirmationListFooter.tsx, per diem fields are hidden when the action is Submit it to someone (CONST.IOU.ACTION.SUBMIT), causing the manual expense page to display instead.

What changes do you think we should make in order to solve the problem?

In src/components/MoneyRequestConfirmationListFooter.tsx

Change this code:

{isPerDiemRequest && action !== CONST.IOU.ACTION.SUBMIT && (
    <>
        <MenuItemWithTopDescription
            shouldShowRightIcon={!isReadOnly}
            title={getDestinationForDisplay(perDiemCustomUnit, transaction)}
            description={translate('common.destination')}
            // ... other props
        />
        {/* other per diem fields */}
    </>
)}

To This Code:

{isPerDiemRequest && (
    <>
        <MenuItemWithTopDescription
            shouldShowRightIcon={!isReadOnly}
            title={getDestinationForDisplay(perDiemCustomUnit, transaction)}
            description={translate('common.destination')}
            // ... other props
        />
        {/* other per diem fields */}
    </>
)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Ensure confirmation pages for per diem expenses show consistent details for all actions.
• Verify that manual expense confirmations remain unaffected.

What alternative solutions did you explore? (Optional)