Fix concierge avatar reloading #62316

noahchernet · 2025-05-19T18:43:36Z

Explanation of Change

The ProfilePage component will no longer fetch Concierge's profile details from BE since all the necessary details are stored on CONST.ts. It prevents fetching its profile because

Fixed Issues

$ #61178
PROPOSAL: #61178 (comment)

Tests

Open a workspace chat
Click on '+' and create a manual expense
Ensure the expense has a merchant, but a category is not selected, then click Create
Wait until Concierge automatically replies to the expense, suggesting a category
Click on Concierge's avatar, the profile page that opens will no longer reload/refresh Concierge's avatar

Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

61178-solved-android-app.webm

Android: mWeb Chrome

61178-solved-android-chrome.webm

iOS: Native

61178-solved-ios.mp4

iOS: mWeb Safari

61178-solved-ios-safari.mp4

MacOS: Chrome / Safari

61178-solved-desktop-chrome.mp4

MacOS: Desktop

61178-solved-macos-desktop.mp4

so that the variable isConcierge can be used in the useEffect Signed-off-by: Noah Chernet <[email protected]>

Fetching concierge's profile using openPublicProfilePage changes the profile url to a new CloudFront url, making the Avatar component rerender unnecessarily while it displays the same image. Since Concierge's avatar is stored in CONST.ts already, there's no need to fetch its profile details again. Signed-off-by: Noah Chernet <[email protected]>

melvin-bot · 2025-05-19T18:43:41Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-05-19T18:43:50Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

noahchernet · 2025-05-19T18:45:30Z

I have read the CLA Document and I hereby sign the CLA

allroundexperts · 2025-05-19T21:56:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-05-21.at.3.51.38.AM.mov

iOS: HybridApp

Screen.Recording.2025-05-21.at.3.50.36.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-05-21.at.3.49.04.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-21.at.3.44.21.AM.mov

MacOS: Desktop

Screen.Recording.2025-05-21.at.3.47.48.AM.mov

allroundexperts

Works good!

cristipaval · 2025-05-22T10:58:30Z

@noahchernet could you please merge the main branch and then make sure the checks pass? 🙏

…ierge-icon-reloading

noahchernet · 2025-05-22T16:54:46Z

Hi @cristipaval, I've merged main, all the checks should be passing now.

Also, I haven't been hired on Upwork yet; I have applied to the linked job post on the issue. This is the first issue I've worked on so I'm not sure if it's supposed to happen automatically or someone has to go manually on Upwork to hire me.

cristipaval · 2025-05-22T18:10:13Z

Hi @cristipaval, I've merged main, all the checks should be passing now.

Also, I haven't been hired on Upwork yet; I have applied to the linked job post on the issue. This is the first issue I've worked on so I'm not sure if it's supposed to happen automatically or someone has to go manually on Upwork to hire me.

Thanks for merging the main again. Don't worry about being hired on Upwork; the assigned #bugzero team member (@flaviadefaria in this case) will take care of it. They'll create a new job for you if needed so you can be paid.

…ierge-icon-reloading

noahchernet · 2025-05-23T12:43:39Z

Thanks for the info Cristi! I've merged main again since one of the tests was failing due to a drift between my branch and main.

OSBotify · 2025-05-23T14:21:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-23T19:31:07Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.1.51-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-26T19:16:56Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.51-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

noahchernet added 2 commits May 19, 2025 10:28

moved isConcierge definition above useEffect

67c1383

so that the variable isConcierge can be used in the useEffect Signed-off-by: Noah Chernet <[email protected]>

noahchernet requested a review from a team as a code owner May 19, 2025 18:43

melvin-bot bot requested a review from allroundexperts May 19, 2025 18:43

melvin-bot bot removed the request for review from a team May 19, 2025 18:43

CLABotify added a commit to Expensify/CLA that referenced this pull request May 19, 2025

@noahchernet has signed the CLA in Expensify/App#62316

b5c0e82

allroundexperts approved these changes May 20, 2025

View reviewed changes

melvin-bot bot requested a review from cristipaval May 20, 2025 23:07

Merge branch 'main' of https://github.com/Expensify/App into fix-conc…

cc2a24a

…ierge-icon-reloading

Merge branch 'main' of https://github.com/Expensify/App into fix-conc…

f7d095d

…ierge-icon-reloading

cristipaval approved these changes May 23, 2025

View reviewed changes

cristipaval merged commit 0742f7c into Expensify:main May 23, 2025
16 checks passed

github-actions bot mentioned this pull request May 23, 2025

Deploy Checklist: New Expensify 2025-05-23 #62662

Closed

melvin-bot bot mentioned this pull request May 26, 2025

[Due for payment 2025-06-02] [$250] Chat - Concierge icon flickers briefly #61178

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix concierge avatar reloading #62316

Fix concierge avatar reloading #62316

Uh oh!

noahchernet commented May 19, 2025

Uh oh!

melvin-bot bot commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025 •

edited

Loading

Uh oh!

noahchernet commented May 19, 2025

Uh oh!

allroundexperts commented May 19, 2025 •

edited

Loading

Uh oh!

allroundexperts left a comment

Uh oh!

cristipaval commented May 22, 2025

Uh oh!

noahchernet commented May 22, 2025

Uh oh!

cristipaval commented May 22, 2025

Uh oh!

noahchernet commented May 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

OSBotify commented May 23, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

Uh oh!

Fix concierge avatar reloading #62316

Fix concierge avatar reloading #62316

Uh oh!

Conversation

noahchernet commented May 19, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

noahchernet commented May 19, 2025

Uh oh!

allroundexperts commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

cristipaval commented May 22, 2025

Uh oh!

noahchernet commented May 22, 2025

Uh oh!

cristipaval commented May 22, 2025

Uh oh!

noahchernet commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OSBotify commented May 23, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

Uh oh!

github-actions bot commented May 19, 2025 •

edited

Loading

allroundexperts commented May 19, 2025 •

edited

Loading

noahchernet commented May 23, 2025 •

edited

Loading