Reports - Expense that doesn´t need approval, appears on "Approve" section

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - New feature testing
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Other

Action Performed:

1. Open the Expensify app.
2. Open a workspace with delayed submissions and approvals disabled.
3. Submit a manual expense.
4. Navigate to "Reports"
5. Tap on bookmark icon and select "Approve"
6. Note that the just submitted expense appears on the list, despite not needing approval.

Expected Result:

Expenses that don´t need to be approved, shouldn´t appear on "Approve" section.

Actual Result:

Expenses that don´t need to be approved, are displayed on "Approve" section.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6840576_1748030428977.Approval.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nlemma]

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[neil-marcellini]

Caused by this PR #61170

@JS00001 what do you want to do about this one?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[IuliiaHerets]

Issue is not reproducible anymore. "Approve" section is not available anymore on "Reports". Rechecked on build 9.1.51-4

screen-20250526-113607.mp4

[Beamanator]

Removing blocker & closing since this is tracked in a few places in slack & was fixed by revert linked above

[JmillsExpensify]

Also relevant: This is more so a shortcoming of the existing instant submit design and will be fixed once instant submit becomes auto-submit (of open reports).