Skip to content

Reports - Chat bubble only appears on expense preview after opening the report #62529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 8 tasks
mitarachim opened this issue May 21, 2025 · 12 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.48-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense.
  4. Go to Reports.
  5. Tap bookmark icon.
  6. Tap Expense Reports.
  7. Long press on the expense from Step 3.
  8. Tap Select.
  9. Tap dropdown button > Hold.
  10. Enter reason and save it.
  11. Exit selection mode by tapping app back button.
  12. Note that there is no chat bubble on the expense preview.
  13. Tap on the expense.
  14. Tap app back button.
  15. Now chat bubble appeears on the expense preview after opening the report.

Expected Result:

In Step 12, after holding expense from Reports, chat bubble will appear on the expense preview.

Actual Result:

In Step 12, after holding expense from Reports, chat bubble does not appear on the expense preview.
It only appears after opening the report in Step 15.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6838572_1747855746676.Screen_Recording_20250522_032524_Chrome.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 21, 2025
Copy link

melvin-bot bot commented May 21, 2025

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 21, 2025

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 21, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 21, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@aldo-expensify
Copy link
Contributor

Trying to reproduce...

@aldo-expensify
Copy link
Contributor

The threadMessages.count is 0 before opening the report and 1 after opening:

@aldo-expensify
Copy link
Contributor

Ahh, this new chat bubble simply doesn't exist in production:

Image

So, this looks like a new feature that is not working 100% correctly. I think the problem is that some data is loaded after the report is opened. If we don't load the report, then we don't have the threads information.

@aldo-expensify
Copy link
Contributor

I'm wrong about it not being in production, now I was able to see it after creating a second report. Maybe the column was getting hidden because it was the same thread.count value for all reports. 🤷

@aldo-expensify
Copy link
Contributor

I don't understand, I only see the bubble in production if the report has 2 transactions or more. With one transaction per report, the bubble is gone:

Image

@aldo-expensify
Copy link
Contributor

Another difference I see in production vs main is that in production, the report opens in the RHP:

Image

Meanwhile, in main the reports open in the main panel

@aldo-expensify
Copy link
Contributor

aldo-expensify commented May 22, 2025

I think we can consider this a backend problem:

There are some commands that don't return the childVisibleActionCount in the IOU reportAction (like OpenApp). You can check this by running on the steps of this issue, and then logging out and logging back in. If you look for the reportAction, it will have this information missing.

Image

Once we open the report, OpenReport load this data properly and the bubble appears:

Image

There must be some new changes in the front end (which I haven't found) that can make this bubble show in cases where in production isn't showing, but I don't think we should make this a deploy blocker since we can improve this by returning this data in the backend.

Besides that, I think this bug is very minor and I don't think it is worth it to hold the deploy on it.

@aldo-expensify
Copy link
Contributor

I think we need to fix this in two places:

  • Frontend: Optimistic data when HOLDING: the childVisibleActionsCount should be incremented optimistically when the HOLD message actions is taken.
  • Backend: Some commands should probably return this information too, like OpenApp or Search?

@aldo-expensify aldo-expensify added Daily KSv2 and removed DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

3 participants