Simplified Actions on Report Header and Preview V2

[jnowakow]

This reverts commit 3daab6e.

cc @luacmartins @borys3kk

Explanation of Change

• [Due for payment 2025-05-20] Expense - "Change workspace" option is available for p2p expense and invoice #59876
• [Due for payment 2025-04-18] Expense - Delete option is present for approved expense which causes error when deleting it #59877
• [Due for payment 2025-04-18] [Better Expense Report View] [$125] mweb - Expense - "Pay with Expensify" button extends out of screen #59883
• [Due for payment 2025-04-18] Scan - Empty green button on the expense preview when the receipt is scanning #59888
• [Due for payment 2025-04-18] Expense - Missing export button on the expense preview and expense report (primary option) #59889
• Expense - scan failure receipt not display red dot in the request preview #59899
• [Due for payment 2025-04-18] Expense - Submit button missing for the Admin's Workspace #59900
• [Due for payment 2025-04-18] Invoice - Invoice preview does not display pay button #59904
• Reports -"Change Workspace" available on expense report on chat but not on "Reports" section #59905
• [Due for payment 2025-04-18] Reports - System message when moving expense is not seen on expense on "Reports" section #59908
• [Due for payment 2025-04-18] Reports - "It´s not here" page displayed after deleting expense and tapping back button. #59909
• [Due for payment 2025-04-18] Hold-In expense details page, in more section hold option is not shown. #59910
• [Due for payment 2025-04-18] Expense - Missing cancel payment option while waiting for employee to add a bank account #59916
• [Due for payment 2025-04-18] Threads - 'Download as PDF" option is be shown for DM thread, room and workspace chat #59873
• [Due for payment 2025-04-18] Expense - "Review" button is still displayed for admin and employee after expense is paid #59912
• Expense - Change Workspace option available for submitted expense #59890
• [Due for payment 2025-04-18] Expense - Pay button is missing when "Delay submissions" and "Add approvals" are disabled #59875
• [Due for payment 2025-04-18] Expense - Missing label on green button after approving track expense #59878
• [Due for payment 2025-04-18] Expense - Green button with no label on the expense preview after workspace is deleted #59879
• [Due for payment 2025-04-18] [$250] Approve button is present when expense report has no expense, empty green button is present #59880
• [Due for payment 2025-05-14] [$250] Expense - No warning is shown when unapproving an expense that has been exported to QBO. #59893
• [Due for payment 2025-04-18] Expense - No option to delete expense in More menu or report header in p2p expense #59895
• Expense - Approve button appears even when Prevent Self Approval is enabled #59901
• [Due for payment 2025-04-18] [Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account #59886
• [Due for payment 2025-04-18] RHN - More button is not animated, and the cursor is inactive while the context menu is opened #59917
• [Due for payment 2025-05-08] [Due for payment 2025-04-18] Expense - Empty space instead of "Pay" button on expense preview after payment is cancelled #59927
• [Due for payment 2025-04-18] [$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled #59928

Fixed Issues

$ #59963
$ #59960
PROPOSAL:

Tests

Test cases:

Prerequisites: Workspace without accounting with approvals enabled, workspace with connected accounting system

Test case 1:

1. Create new expense report in workspace without accounting
2. Verify it has Submit as primary action and all secondary actions work
3. Sumit report
4. On approver account verify that primary action is Approve and all secondary actions work as expected
5. Approve report
6. Verify primary action is pay and all secondary actions work as expected
7. Pay the report
8. Verify there’s no primary action.

Test case 2:

1. Follow steps from Test case 1 but in workspace with connected accounting system
2. That after report is payed there is Export to [Accounting system] primary option.

Test case 3:

1. Create new expense report with single expense
2. Put that report on hold using secondary action
3. Verify that primary action is Unhold
4. Verify Unhold action works.

Test case 4:

1. Disable approvals in workspace
2. Create new expense report
3. Submit it
4. Verify that Pay is primary action for workspace admin

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[jnowakow]

@mananjadhav conflicts resolved

[suneox]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Non Beta: enable auto approval, auto export, track, delay submition

Screen.Recording.2025-04-24.at.21.59.49.mp4

Beta: enable auto approval, auto export, track, delay submition

Screen.Recording.2025-04-24.at.22.02.53.mp4

Non Beta: disable auto export, track, delay submition

Screen.Recording.2025-04-24.at.22.14.47.mp4

Beta: disable auto export, track, delay submition

Screen.Recording.2025-04-24.at.22.18.01.mp4

Android: Native

Non Beta

Uploading Screen Recording 2025-04-24 at 22.34.17.mp4…

Android: mWeb Chrome

Non Beta

Screen.Recording.2025-04-24.at.22.29.17.mp4

iOS: Native

Non Beta

Screen.Recording.2025-04-24.at.22.23.59.mp4

iOS: mWeb Safari

Non Beta

Screen.Recording.2025-04-24.at.22.23.59.mp4

MacOS: Desktop

Non Beta: Disable track

Screen.Recording.2025-04-24.at.22.38.28.mp4

[suneox]

Overall, the changes introducing the new action behind beta flags LGTM. Just consider also applying the beta flag in ReportPrimaryActionUtils for the function that contains new logic.

I've verified the non-beta and beta in cases: enable/disable auto approval, auto export, track, delay submition

[luacmartins]

This is a large PR and has many unrelated ESLint errors. I'm gonna merge it as is and we can tackle those in a follow up.

[melvin-bot]

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[luacmartins]

See comment above

[suneox]

This is a large PR and has many unrelated ESLint errors. I'm gonna merge it as is and we can tackle those in a follow up.

Related to eslint error by rule canBeMissing I'm also having a bad dev experience due to the eslint fix more than 30 alerts when open report. Currently we don’t have any actions in place to handle missing data, I think it makes sense to set canBeMissing: true for legacy features. For new features, we can use canBeMissing: false then explicitly handle missing data where needed.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.33-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[aldo-expensify]

I think the changes in this PR may be causing this deploy blocker: #61005

Not 100% sure because it can't be reverted easily

[github-actions]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.35-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

[github-actions]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.36-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.37-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌