[Due for payment 2025-04-18] Reports - System message when moving expense is not seen on expense on "Reports" section

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: N/A
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Use Gmail account with Self DM and have at least two workspaces available.

1. Open the staging.new.expensify.com website.
2. Tap on FAB and select "Create Expense"
3. Complete the creation flow and submit it to Self DM
4. On system message select "Share with my accountant"
5. Add a merchant and submit the expense to any workspace.
6. Dismiss RHP and open expense report.
7. Tap on "More"
8. Select "Change Workspace" and move the expense to any different workspace.
9. Note that a system message was generated on report with this action,
10. Navigate to "Reports" and open the same expense report.
11. Note that the same system message is not visible on report.

Expected Result:

System message when moving a track expense should be visible on expense report on chat and also when opening the expense on "Reports" section.

Actual Result:

System message generated when moving a track expense to another workspace, can be seen on expense report on chat, but is not visible when opening report from "Reports" section.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6797003_1744192992390.System.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nlemma]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[inimaga]

Not sure if this really a deploy blocker but I agree its a 'bug' or non handled case, in a new feature being introduced in the PR at #58084. The ability to change workspaces for an expenses, as part of the feature set of the secondary actions button isn't being displayed on the reports section.

@jnowakow, @mountiny, @ @luacmartins Thoughts here?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[inimaga]

Demoted priority, as ruled not a deploy blocker as per conversation here.

Still keeping the deploy blocker tag on, as the resolution is a PR revert. So as to eventually be included in things to fix from the offending PR.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[jnowakow]

@luacmartins same case as in #59905. Technically in RHP on search page it's different view then on report page and that's why there are different messages

[luacmartins]

Hmm this is an interesting one, because this is a one expense report, we should open the expense report in the RHP and not the transaction thread. So I'd expect to see the moved reportAction.

[jnowakow]

Okey, I looked into it and I think there's maybe a bug on backend side of search 🤔
There's a prop isFromOneTransactionReport on transaction item which is sent from backend and it seems that sometimes it's set to false for transactions from one transaction reports:

hmm.mov

[luacmartins]

@jnowakow what reportActions do you get in Onyx for that reportID 69466869916232091? I'm interested in seeing all the IOU actions returned for that report

[jnowakow]

Here they are:

{
  "reportActions_6946869916232091": {
    "6348380107354971393": {
      "person": [{ "type": "TEXT", "style": "strong", "text": "***" }],
      "actorAccountID": 19241380,
      "message": [
        {
          "type": "COMMENT",
          "html": "***",
          "text": "***",
          "isEdited": false,
          "whisperedTo": [],
          "isDeletedParentAction": false,
          "deleted": "",
          "reactions": []
        }
      ],
      "originalMessage": {
        "IOUReportID": "6946869916232091",
        "IOUTransactionID": "7349440213204447110",
        "amount": -12300,
        "comment": "",
        "currency": "PLN",
        "isNewDot": true,
        "lastModified": "2025-04-09 13:43:17.787",
        "participantAccountIDs": [19241380],
        "type": "track"
      },
      "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_5.png",
      "created": "2025-04-09 13:43:17.787",
      "timestamp": 1744206197,
      "reportActionTimestamp": 1744206197787,
      "automatic": false,
      "actionName": "IOU",
      "shouldShow": true,
      "reportActionID": "6348380107354971393",
      "lastModified": "2025-04-09 13:43:17.787",
      "childType": "chat",
      "childReportNotificationPreference": "hidden",
      "whisperedToAccountIDs": [],
      "childReportID": "8316136024328492"
    },
    "3409185656961800021": {
      "reportActionID": "3409185656961800021",
      "actionName": "CREATED",
      "created": "2025-04-09 13:43:17.784",
      "reportActionTimestamp": 1744206197784,
      "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_5.png",
      "message": [
        { "type": "TEXT", "style": "strong", "text": "***" },
        { "type": "TEXT", "style": "normal", "text": "***" }
      ],
      "person": [{ "type": "TEXT", "style": "strong", "text": "***" }],
      "automatic": false,
      "sequenceNumber": 0,
      "shouldShow": true,
      "lastModified": "2025-04-09 13:43:17.784"
    },
    "580580001257534496": {
      "person": [{ "type": "TEXT", "style": "strong", "text": "***" }],
      "actorAccountID": 19241380,
      "message": [
        {
          "type": "COMMENT",
          "html": "***",
          "text": "***",
          "isEdited": false,
          "whisperedTo": [],
          "isDeletedParentAction": false,
          "deleted": ""
        }
      ],
      "originalMessage": {
        "IOUReportID": 6946869916232091,
        "amount": 12300,
        "currency": "PLN",
        "html": "***",
        "isNewDot": true,
        "lastModified": "2025-04-09 13:43:24.924"
      },
      "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_5.png",
      "created": "2025-04-09 13:43:24.924",
      "timestamp": 1744206204,
      "reportActionTimestamp": 1744206204924,
      "automatic": false,
      "actionName": "APPROVED",
      "shouldShow": true,
      "reportActionID": "580580001257534496",
      "lastModified": "2025-04-09 13:43:24.924",
      "whisperedToAccountIDs": []
    },
    "961503583046410916": {
      "person": [{ "type": "TEXT", "style": "strong", "text": "***" }],
      "actorAccountID": 19241380,
      "message": [{ "type": "TEXT", "style": "normal", "text": "***" }],
      "originalMessage": {
        "amount": 12300,
        "cc": "",
        "currency": "PLN",
        "hasExternalComment": false,
        "html": "***",
        "isNewDot": true,
        "lastModified": "2025-04-09 13:43:21.302",
        "message": "",
        "submittedTo": 19241380,
        "to": "[email protected]",
        "workflow": "BASIC"
      },
      "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_5.png",
      "created": "2025-04-09 13:43:21.302",
      "timestamp": 1744206201,
      "reportActionTimestamp": 1744206201302,
      "automatic": false,
      "actionName": "SUBMITTED",
      "shouldShow": true,
      "reportActionID": "961503583046410916",
      "lastModified": "2025-04-09 13:43:21.302",
      "whisperedToAccountIDs": []
    },
    "7805279011735654518": {
      "person": [{ "type": "TEXT", "style": "strong", "text": "***" }],
      "actorAccountID": 19241380,
      "message": [],
      "originalMessage": {
        "action": "report",
        "isNewDot": true,
        "lastModified": "2025-04-09 13:43:17.795",
        "transactionID": 7349440213204447000
      },
      "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_5.png",
      "created": "2025-04-09 13:43:17.795",
      "timestamp": 1744206197,
      "reportActionTimestamp": 1744206197795,
      "automatic": false,
      "actionName": "BILLABLEUPDATETRANSACTION",
      "shouldShow": false,
      "reportActionID": "7805279011735654518",
      "lastModified": "2025-04-09 13:43:17.795",
      "whisperedToAccountIDs": []
    }
  }
}

[luacmartins]

Ah I think I see the bug, we're not handling "type": "track" when setting isFromOneTransactionReport

[luacmartins]

I'll work on a fix.

[luacmartins]

@jnowakow I created an issue and have a PR in review

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bfitzexpensify]

Adding a BZ buddy as I'll be OOO until April 29th.

This is all internal/contractors, but keeping a BZ team member on in case we're needed.

[Christinadobrzyn]

Payment set for tomorrow, are we going to need a regression test for this? Looks like this is a bunch of issues:

#59931

Are we paying these separate/

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[Christinadobrzyn]

Sorry just catching up here - It looks like we have no payments for this GH, is that correct?

@jnowakow @inimaga @ZhenjaHorbach

[inimaga]

@Christinadobrzyn Yes. This issue is part of a broader list of issues being resolved here #59960. Therefore the plan is to handle payment via that issue.

CCing @luacmartins in case this has changed.

[luacmartins]

Correct, we're handling it in #59960.

[Christinadobrzyn]

Thank you! Okay, closing this without payment. Let me know if I'm missing something.