Skip to content

[Due for payment 2025-04-18] Reports - "It´s not here" page displayed after deleting expense and tapping back button. #59909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
jponikarchuk opened this issue Apr 9, 2025 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@jponikarchuk
Copy link

jponikarchuk commented Apr 9, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check in Prod, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

  1. Open the Expensify app.
  2. Tap on FAB and select "Create Expense"
  3. Complete the creation flow and submit it to Self DM.
  4. On system message, select "Share with my accountant"
  5. Select any workspace, add a merchant and submit the expense.
  6. Navigate to "Reports" and open the just submited expense report.
  7. Tap on "More" and delete the expense.
  8. When navigated to chat, tap on the back button on the top left corner.
  9. Check the page displayed with this last action.

Expected Result:

After deleting an expense on "Reports" section, user should land on expenses list again with no error triggered.

Actual Result:

When deleting a track expense from "Reports" section, user lands on chat, instead of expenses list again, and tapping on back button, leads to "It´s not here" page.
If the expense is not a track expense, after tapping on back button, infinite loading is displayed.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @johncschuster
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 9, 2025

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 9, 2025
Copy link
Contributor

github-actions bot commented Apr 9, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@pecanoro
Copy link
Contributor

pecanoro commented Apr 9, 2025

PR is being reverted here: #59931

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins
Copy link
Contributor

FYI we reverted the original offending PR

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Apr 9, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 11, 2025
@melvin-bot melvin-bot bot changed the title Reports - "It´s not here" page displayed after deleting expense and tapping back button. [Due for payment 2025-04-18] Reports - "It´s not here" page displayed after deleting expense and tapping back button. Apr 11, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 11, 2025
Copy link

melvin-bot bot commented Apr 11, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 11, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-18. 🎊

Copy link

melvin-bot bot commented Apr 11, 2025

@pecanoro @johncschuster @pecanoro The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@johncschuster
Copy link
Contributor

It seems like there's no need for the BZ Checklist/payment, right, @pecanoro?

@pecanoro
Copy link
Contributor

Yeah, closing, all done!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants