Deploy Checklist: New Expensify 2025-04-09

[github-actions]

Release Version: 9.1.25-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fixed an error I found in the console this morning #216
• Simplified actions on report header #58084
• Navigating to a thread from the Search page doesn’t take you to the chat #58628
• fix: rule approvers (category / tag) should be able to submit reports on workspaces with prevent self-approvals enabled #58660
• fix: No Add Bank Account button In report from employee without added BA #58783
• Room - Infinite loading when user is removed from room while in RHP #59126
• Update Unapprove warning for exported transactions #59195
• fix: remove shouldAdminsRoomBeVisible #59293
• [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab #59450
• Enabled feature does not animate #59469
• [CP Staging] Revert "Fix nested markdown isn't applied" #59490
• fix: loading spinner displayed and user stuck after signin #59511
• Fix nested markdown not applied #59586
• [Manager McTest] Tooltip Centered Incorrectly - Fix #59609
• [No QA] Only leave comment if it's not already there #59634
• Align HybridApp environment toggles #59663
• workspace round frame #59675
• Fix needs to press back twice after opening a workspace join page #59697
• Hide Retry Payment button if no card is added #59699
• Fix offline indicator isn't sticking to the keyboard on the workspace currency page #59758
• [No QA] Correct the value of CONST.BILLING.TYPE_FAILED_2018 #59762
• Fix validate code modal shows blank #59773
• Update condition for NavigationBar visibility based on keyboard state #59802
• [NO QA] Minor copy update #59841
• [NO QA] Update and rename Merge-accounts.md to Merge-Accounts.md #59842
• [CP Staging] fix: empty green button after paying with Expensify #59892
• [CP Staging] Revert "fix: empty green button after paying with Expensify" #59930
• [CP Staging] Fix sign in - validate screen is shown when signing in #59956
• [CP Staging] Revert "Simplified actions on report header" #59931

Deploy Blockers:

• [Due for payment 2025-04-18] Threads - 'Download as PDF" option is be shown for DM thread, room and workspace chat #59873
• [Due for payment 2025-04-18] Expense - Pay button is missing when "Delay submissions" and "Add approvals" are disabled #59875
• [Due for payment 2025-05-20] Expense - "Change workspace" option is available for p2p expense and invoice #59876
• [Due for payment 2025-04-18] Expense - Delete option is present for approved expense which causes error when deleting it #59877
• [Due for payment 2025-04-18] Expense - Missing label on green button after approving track expense #59878
• [Due for payment 2025-04-18] Expense - Green button with no label on the expense preview after workspace is deleted #59879
• [Due for payment 2025-04-18] [$250] Approve button is present when expense report has no expense, empty green button is present #59880
• [Due for payment 2025-04-25] [Desktop Navigation] Reports filters - Workspace filter is displayed when account has no workspace #59882
• [Due for payment 2025-04-18] [Better Expense Report View] [$125] mweb - Expense - "Pay with Expensify" button extends out of screen #59883
• [Due for payment 2025-04-18] [Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account #59886
• [Due for payment 2025-04-18] Scan - Empty green button on the expense preview when the receipt is scanning #59888
• [Due for payment 2025-04-18] Expense - Missing export button on the expense preview and expense report (primary option) #59889
• Expense - Change Workspace option available for submitted expense #59890
• [$250] [Hold for Payment 4/23] Copilot - No sign in when switching from OD to ND #59891
• [Due for payment 2025-05-14] [$250] Expense - No warning is shown when unapproving an expense that has been exported to QBO. #59893
• [Due for payment 2025-04-18] Expense - No option to delete expense in More menu or report header in p2p expense #59895
• Expense - No option to delete expense in More menu or report header in p2p expense #59897
• Expense - scan failure receipt not display red dot in the request preview #59899
• [Due for payment 2025-04-18] Expense - Submit button missing for the Admin's Workspace #59900
• Expense - Approve button appears even when Prevent Self Approval is enabled #59901
• [Due for payment 2025-04-23] Hybrid-Scan- circle loading infinitely after close the alert modal of scanning corrupted file #59903
• [Due for payment 2025-04-18] Invoice - Invoice preview does not display pay button #59904
• Reports -"Change Workspace" available on expense report on chat but not on "Reports" section #59905
• [Due for payment 2025-04-18] Reports - System message when moving expense is not seen on expense on "Reports" section #59908
• [Due for payment 2025-04-18] Reports - "It´s not here" page displayed after deleting expense and tapping back button. #59909
• [Due for payment 2025-04-18] Hold-In expense details page, in more section hold option is not shown. #59910
• [Due for payment 2025-04-18] Expense - "Review" button is still displayed for admin and employee after expense is paid #59912
• [Due for payment 2025-04-18] Expense - Missing cancel payment option while waiting for employee to add a bank account #59916
• [Due for payment 2025-04-18] RHN - More button is not animated, and the cursor is inactive while the context menu is opened #59917
• [Due for payment 2025-05-08] [Due for payment 2025-04-18] Expense - Empty space instead of "Pay" button on expense preview after payment is cancelled #59927
• [Due for payment 2025-04-18] [$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled #59928
• LHN - Room created via whisper is not displayed on LHN #59941
• Sign in-Unable to sign in with validated account after signing out, validation loop #59957

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[github-actions]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.25-0 🚀

[lakchote]

Demoting #59891 for this reason.

[m-natarajan]

Regression is 91% Completed
Unchecked PRs:
#58084 - Pending validation in Desktop and iOS,
#58660 - Pending validation in iOS,
#58783 - Pending validation in iOS,
#59195 - Pending validation in iOS.

[rlinoz]

Demoted #59903

[m-natarajan]

Left with few steps in Regression
Unchecked PRs:
#58660 - Pending validation in iOS,Desktop
#59195 failing with #59893

[blimpich]

Checking off #59957, was fixed and cherry picked to staging.

[m-natarajan]

Regression completed
Unchecked PRs:
#58660 - failing with #59901
#59195 failing with #59893

[jasperhuangg]

Both of the above issues are not blockers, checking them off!

[jasperhuangg]