[$250] [Hold for Payment 4/23] Copilot - No sign in when switching from OD to ND

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #59323
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: MacOS Big Sur
App Component: Other

Action Performed:

Precondition: Add a copilot to the current account. Clear site data in Devtools > Application for desktop and reload before check.

1. Open the OldDot application
2. Select a copilot as the active account
3. Switch to NewDot using one of the following methods:
   Support → Concierge
   Try New Expensify button
   Reports → Random report → Take me there button
4. Click "Open New Expensify" button on popup

Expected Result:

NewDot desktop application opens with the copilot as the active account in the correct location

Actual Result:

NewDot desktop app opens, but user is not logged in.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6796327_1744191486636.ver_9.1.25-0_repro.mp4

Bug6796327_1744136850834.Screen_Recording_2025-04-08_at_9.19.35_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915057474152953117
• Upwork Job ID: 1915057474152953117
• Last Price Increase: 2025-04-23

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mitarachim]

This issue actually found while run PR in Build - 9.1.24-4 , but after re-checking also reproduce in Build 9.1.25-0

[mountiny]

cc @dangrous @ZhenjaHorbach

[lakchote]

Demoting from being a blocker, as it's an edge case.

[ZhenjaHorbach]

Demoting from being a blocker, as it's an edge case.

Agree !
Let me check
Maybe it will be possible to fix it quickly and test it on Dev dev

[dangrous]

oh huh - let us know what you figure out @ZhenjaHorbach ! Agree it's not a blocker. I can take this one over if you like, @lakchote

[dangrous]

@ZhenjaHorbach I'm curious what you find; this may have a backend component as well? I noticed that opening things in the desktop app uses OPEN_OLD_DOT_LINK which is confusing... We might need to do something similar here where we log out of copilot then switch then back in again? Hopefully that can all be handled in one PR.

We could also skirt the issue by not popping up the prompt to switch to Desktop if there's a delegatorEmail in the URL.

[ZhenjaHorbach]

@ZhenjaHorbach I'm curious what you find; this may have a backend component as well? I noticed that opening things in the desktop app uses OPEN_OLD_DOT_LINK which is confusing... We might need to do something similar here where we log out of copilot then switch then back in again? Hopefully that can all be handled in one PR.

We could also skirt the issue by not popping up the prompt to switch to Desktop if there's a delegatorEmail in the URL.

Thank you for checking it out too !
But sorry
I didn't have much time to check it today
I'll do it tomorrow morning

We might need to do something similar here where we log out of copilot then switch then back in again? Hopefully that can all be handled in one PR

But it sounds complicated 😅

Maybe we should just log in using the main account 🧐
Because if we open the app, select the copilot,
log out, and then log back in,
we’ll end up with the main account active (not the copilot)

[dangrous]

Discussed offline, we're going to just remove the pop up to open in Desktop when users come in from Old Dot while copiloted in. This seems like the best solution given that this flow soon won't exist once we deprecate Classic

[ZhenjaHorbach]

@dangrous
Could you assign @suneox, please ?

[dangrous]

This is on prod, not sure why the automation didn't fire.

I think this should count as a separate followup, rather than being treated as a regression, since it was new behavior we didn't account for

[ZhenjaHorbach]

This is on prod, not sure why the automation didn't fire.

I think this should count as a separate followup, rather than being treated as a regression, since it was new behavior we didn't account for

It seems to me that this is even a separate issue
Since this bug was reproduced even without our changes

[dangrous]

yeah that works - so looks like this will be ready for payment on 4/23, and should be the standard $250 for both C and C+!

[CortneyOfstad]

Do we know if this needs a regression test or not? CC @suneox @ZhenjaHorbach

[suneox]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: New enhancement

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A This is a mandatory system change.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  N/A It's an edge case and not an impactful bug

[suneox]

Do we know if this needs a regression test or not? CC @suneox @ZhenjaHorbach

I think we don't we need a regression test for this one, since it’s an edge case and we already prevent the app from opening in copilot mode.

[dangrous]

yeah I think that's fine for now!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915057474152953117

[melvin-bot]

Current assignees @suneox and @ZhenjaHorbach are eligible for the External assigner, not assigning anyone new.

[CortneyOfstad]

@suneox — I sent you an offer via Upwork here. Please let me know once you accept so I can get that paid ASAP. Thanks!

[suneox]

@suneox — I sent you an offer via Upwork here. Please let me know once you accept so I can get that paid ASAP. Thanks!

@CortneyOfstad Thank you, I've accepted the offer

[CortneyOfstad]

Payment Summary

@suneox — paid $250 via Upwork
@ZhenjaHorbach — to be paid $250 via NewDot

Regression Test

Not needed, per the comment here