[Due for payment 2025-04-16] Enable switching from New to Old Dot on web when copiloted in

[dangrous]

Problem

Currently we disabled switching to/from new/old dot when logged in as a copilot, since the functionality wasn't enabled. It is now!

Why is this important?

Allows full functionality for our users

Solution

Remove the blocks for both flows.

Discussed in Slack, but we are sending a new URL param, delegatorEmail, to the /transition route if the user needs to be re-logged in as a delegate once logged into the base account. We need to pick that up and call Delegate.connect with that info, and, once that's complete, land the user in the correct location.

Test cases:

• Copilot into an account in Old Dot - go to New Dot - return to Old Dot - switch back to original account
• Copilot into an account in New Dot - go to Old Dot - return to New Dot - switch back to original account
• Copilot into an account in Old Dot - go to New Dot - switch back to original account - return to Old Dot
• Copilot into an account in New Dot - go to Old Dot - switch back to original account - return to New Dot

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enable switching from New to Old Dot on web when copiloted in

What is the root cause of that problem?

Currently we disabled switching to/from new/old dot when logged in as a copilot, since the functionality wasn't enabled

What changes do you think we should make in order to solve the problem?

1. Remove this code block:
   

   App/src/pages/settings/InitialSettingsPage.tsx

   Lines 263 to 266 in 3ffa779

   	if (isActingAsDelegate) {
   	setIsNoDelegateAccessMenuVisible(true);
   	return;
   	}

2. Remove these block components:

App/src/pages/settings/ExitSurvey/ExitSurveyConfirmPage.tsx

Line 64 in 3ffa779

<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>

App/src/pages/settings/ExitSurvey/ExitSurveyBookCall.tsx

Line 26 in 3ffa779

<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>

App/src/pages/settings/ExitSurvey/ExitSurveyReasonPage.tsx

Line 52 in 3ffa779

<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>

App/src/pages/settings/ExitSurvey/ExitSurveyResponsePage.tsx

Line 90 in 3ffa779

<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Don't need a test

What alternative solutions did you explore? (Optional)

[ZhenjaHorbach]

@thelullabyy
Thanks for your proposal
But sorry
This is not Help Wanted issue and I'm already working on it
And as part of this issue, we need to update the switch logic from OD to ND while preserving the active copilot if necessary

[thelullabyy]

@ZhenjaHorbach Thanks for your information!

[ZhenjaHorbach]

Not overdue
the PR is in progress

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Enable switching from Old Dot to New Dot on web when copiloted in  #59323

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

@ZhenjaHorbach @dylanexpensify @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dangrous]

looks like we still need to deal with #59891 but this is doing great so far!

[dylanexpensify]

woooot!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @ZhenjaHorbach owed $250 via NewDot

BugZero Checklist (@dylanexpensify)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[ZhenjaHorbach]

@dangrous @dylanexpensify

We forgot about @suneox 😅

Let's assign him here
Since he reviewed the PR

[dangrous]

oops, thanks! Shouldn't melvin have assigned automatically? hm.

[melvin-bot]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[dylanexpensify]

@suneox please apply here!

[suneox]

@suneox please apply here!

I can't access this job because it's private, Could you please send me another one? Thank you!

[suneox]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: New enhancement

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other: New enhancement

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A This is a mandatory system change.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  N/A

[dylanexpensify]

@suneox mind trying again??

[suneox]

@suneox mind trying again??

@dylanexpensify I've applied for this job. Thank you!

[dylanexpensify]

@suneox offer sent!

[suneox]

@suneox offer sent!

@dylanexpensify Thank you! I've accepted the offer

[melvin-bot]

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dylanexpensify]

done!