Skip to content

Reports -"Change Workspace" available on expense report on chat but not on "Reports" section #59905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 of 8 tasks
jponikarchuk opened this issue Apr 9, 2025 · 19 comments
Open
4 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@jponikarchuk
Copy link

jponikarchuk commented Apr 9, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check in Prod, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Use a Gmail account with SelfDM and have at least one workspace available.

  1. Open the staging.new.expensify.com website.
  2. Tap on FAB and select "Create Expense"
  3. Complete the creation flow and submit it to Self DM.
  4. On system message on chat, select "Share with my accountant"
  5. Add a merchant and submit the expense to any workspace.
  6. Open the expense report.
  7. Tap on "More" and note that "Change Workspace" option is present.
  8. Navigate to "Reports"
  9. Open the same expense report.
  10. Tap on "More" and note that "Change Workspace" option is not present.

Expected Result:

"Change Workspace" option should be available for a track expense when opening report on chat and also on "Reports" section.

Actual Result:

"Change Workspace" option is not available on expense on "Reports" section, but is present when opening the report on chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @maddylewis
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 9, 2025

Triggered auto assignment to @Valforte (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 9, 2025
Copy link
Contributor

github-actions bot commented Apr 9, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@jnowakow
Copy link
Contributor

jnowakow commented Apr 9, 2025

I'm not able to reproduce it:

Image

@Valforte
Copy link
Contributor

Valforte commented Apr 9, 2025

Reproduced on staging

Image

Image

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins
Copy link
Contributor

FYI we reverted the original offending PR

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Apr 9, 2025
@jasperhuangg
Copy link
Contributor

I think we can close it out, confirmed fixed

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 11, 2025
@melvin-bot melvin-bot bot changed the title Reports -"Change Workspace" available on expense report on chat but not on "Reports" section [Due for payment 2025-04-18] Reports -"Change Workspace" available on expense report on chat but not on "Reports" section Apr 11, 2025
Copy link

melvin-bot bot commented Apr 11, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 11, 2025
Copy link

melvin-bot bot commented Apr 11, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-18. 🎊

Copy link

melvin-bot bot commented Apr 11, 2025

@Valforte @maddylewis @Valforte The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@jnowakow
Copy link
Contributor

@luacmartins the root cause of this bug is that on reports screen we display transaction in RHP not report:

Image

So technically it's not bug because those are two different views. In RHP on search page we display transaction screen instead of report screen. That's why there are different options

@luacmartins
Copy link
Contributor

luacmartins commented Apr 11, 2025

hmm we can show the report in the RHP. If you go to Reports > Expense reports and click on one, you'll see that the report is opened in the RHP. That being said, I agree that the video in the OP is opening a transaction and not an expense report. We're also changing this in the other report projects (where the report will show in the main screen). So maybe we don't need to worry about this one now.

Screen.Recording.2025-04-11.at.9.23.30.AM.mov

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 15, 2025
@luacmartins
Copy link
Contributor

Reopening since this one doesn't seem to be fixed

@luacmartins luacmartins reopened this Apr 25, 2025
@luacmartins luacmartins removed Reviewing Has a PR in review Awaiting Payment Auto-added when associated PR is deployed to production labels Apr 25, 2025
@luacmartins luacmartins changed the title [Due for payment 2025-04-18] Reports -"Change Workspace" available on expense report on chat but not on "Reports" section Reports -"Change Workspace" available on expense report on chat but not on "Reports" section Apr 25, 2025
@luacmartins
Copy link
Contributor

The bug is coming from the BE. When we convert the tracked expense to a request, we're keeping the type: 'track' instead of updating it to type: 'create', which in turn makes isFromOneTransactionReport return false and we display the MoneyRequestHeader component instead of MoneyReportHeader which have different available actions. I have a PR in review to fix that.

@luacmartins luacmartins added the Reviewing Has a PR in review label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants