[Due for payment 2025-05-22] [Due for payment 2025-05-14] [Simplified Actions] FOLLOWUP: Add Primary and Secondary actions to report previews and header

[luacmartins]

Let's use this issue to track any follow ups from #59999

Needs work

• Remove beta flag and delete *HeaderOld.tsx files

In review

• [Due for payment 2025-05-20] Report - No Export to [Accounting system] primary option on paid report #61092
• [Due for payment 2025-05-20] Expense - "Change workspace" option is available for p2p expense and invoice #59876
• [Due for payment 2025-05-20] Intacct - Missing "Export to Sage Intacct" in More options after changing auto sync settings #60914
• [Due for payment 2025-05-14] Scan - After scanning completed, mark as cash button is not shown. #61019
• [Due for payment 2025-05-14] Report - The Approve button still displays for Aprrover A after clicking on it #60911
• [Due for payment 2025-05-14] Intacct - "Mark as manually entered" is missing in expense report when auto sync is disabled #60912
• [Due for payment 2025-05-14] Intacct - No warning modal when report is repeatedly exported from the expense report #60913
• [Due for payment 2025-05-14] Expense - Blank green button in expense preview and report when net amount is 0 #61005
• Reports -"Change Workspace" available on expense report on chat but not on "Reports" section #59905
• [Due for payment 2025-05-14] [$250] Expense - No warning is shown when unapproving an expense that has been exported to QBO. #59893

Fixed

• Expense - Change Workspace option available for submitted expense #59890
• [Due for payment 2025-05-08] [Due for payment 2025-04-18] Expense - Empty space instead of "Pay" button on expense preview after payment is cancelled #59927
• Fix offline report name #61049 (comment)

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[luacmartins]

@jnowakow @borys3kk I retested all issues reported by QA and added the ones that are still reproducible to the OP. @borys3kk has a draft PR to address a few of them already. It seems like one of them is coming from the BE so I'll take a look at that one. @jnowakow could you pick one of the other issues that are not addressed yet and work on a PR for it please? Let's push to remove the beta next week!

[jnowakow]

@luacmartins #60913 will be fixed by @borys3kk in his PR

[jnowakow]

@luacmartins I've opened PR for #59927 - it's here #60957

[jnowakow]

@luacmartins I think #59905 was fixed by some search related changes

[jnowakow]

@luacmartins for #59876 I'm getting this error when trying to move IOU report to workspace:

I think it's backend issue 🤔

[trjExpensify]

@luacmartins for #59876 I'm getting this error when trying to move IOU report to workspace:

Doesn't Carlos have a draftPR up for this one here: #60872?

[luacmartins]

Yea, I'll address that one in my PR

[trjExpensify]

Sounds good!

[jnowakow]

@luacmartins is this #61049 (comment) connected to this project? 😅

[borys3kk]

Hi
Regarding the remaining issues:
$ #59876 is taken caren by you Carlos
$ #59905 was fixed as stated in this comment: $ #60852 (comment)
$ #59893 was fixed in my pr
$ #61092 is I think expected behaviour but waiting for response from tester if it's a bug I will take care of this
$ #61049 fixed by you Carlos
$ #61019 you're taking care of this on as well
so all in all I think all issues from this follow up are looked after :)

[luacmartins]

@luacmartins is this #61049 (comment) connected to this project? 😅

Not really, but I think it's a cleanup item that we should address sooner rather than later. It's at the bottom of the list priority wise though

[luacmartins]

#59905 was fixed as stated in this comment: $ #60852 (comment)

I can still reproduce this issue following the steps in the OP (except for the gmail part)

Screen.Recording.2025-04-30.at.3.59.51.PM.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Borys3kk 59999 follow ups #60891

If no regressions arise, payment will be issued on 2025-05-14. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @suneox requires payment (Needs manual offer from BZ)
• @borys3kk does not require payment (Contractor)
• @jnowakow does not require payment (Contractor)

[melvin-bot]

@mananjadhav / @suneox @slafortune @mananjadhav / @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

I think all the PRs fixing the bugs in the OP are merged. @jnowakow let's update #61378 to get it merged tomorrow!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mananjadhav owed $250 via NewDot
• ROLE: @suneox paid $(AMOUNT) via Upwork (LINK)
• Contributor: @borys3kk is from an agency-contributor and not due payment
• Contributor: @jnowakow is from an agency-contributor and not due payment

BugZero Checklist (@slafortune)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove old headers implementation #61378

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @suneox requires payment (Needs manual offer from BZ)
• @borys3kk does not require payment (Contractor)
• @jnowakow does not require payment (Contractor)

[melvin-bot]

@mananjadhav / @suneox @slafortune @mananjadhav / @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]