[Due for payment 2025-05-20] Expense - "Change workspace" option is available for p2p expense and invoice

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Bug 1:

Precondition:

• Account has at least one workspace.

1. Go to staging.new.expensify.com
2. Go to 1:1 DM.
3. Submit an expense.
4. Click on the expense preview.
5. Click More.

Bug 2:

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice.
3. Send an invoice to any user.
4. Go to invoice report.
5. Click More.

Bug 3:

1. Go to staging.new.expensify.com
2. Go to 1:1 DM.
3. Click + > Pay user.
4. Enter amount > Next.
5. Pay the user.
6. Go to expense report.
7. Click More.

Expected Result:

"Change workspace" option should not be available for p2p expense and invoice report.

Actual Result:

"Change workspace" option is available for p2p expense and invoice report.
Changing workspace in p2p expense is not working too.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/aec7142f-b1de-4713-882a-bc4cef63b536
https://github.com/user-attachments/assets/7e5fe142-ad9c-488e-a1bd-1e46a20bf3ca
https://github.com/user-attachments/assets/2e9827c7-948c-4f9a-95e4-281a558b1dc7

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

cc @luacmartins @jnowakow @rayane-d @suneox

[rayane-d]

cc @mananjadhav

[jnowakow]

Bug 1:
@luacmartins I've added a question to design doc - https://docs.google.com/document/d/1JZLr_5gX348cMZXNr6HUwi4QscOcDg3IY368FMAu3H4/edit?disco=AAABgi2j1Cc

Bug 2:
I'm not able to create invoice due to another bug:

invoices.mov

Bug 3:
Report is both reimbursed and user is marked as receiver so it's correct according to design doc:

(isIOU && hasWorkspaces &&
	(isReceiver && isReimbursed) || <-- it falls here
	(isSender && isProcessing)
)

cc @luacmartins

[luacmartins]

Change workspace should be available for P2P, so that users can move an IOU they incorrectly submitted to their admin (as P2P) to their correct workspace. I think we need to investigate this one though:

Changing workspace in p2p expense is not working too.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[luacmartins]

I'm gonna reopen this since it's not solved. I have a PR for it here #60872

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix available workspace logic #60872

If no regressions arise, payment will be issued on 2025-05-20. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @jnowakow does not require payment (Contractor)
• @rayane-d requires payment through NewDot Manual Requests

[melvin-bot]

@rushatgabhane / @rayane-d @rushatgabhane / @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

• Reviewer: @rayane-d owed $250 via NewDot

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[lschurr]

Just clarifying, looking at the PR, it seems like @luacmartins made the PR and @rayane-d did the review. @rushatgabhane you didn't review this one right?

[rushatgabhane]

yes that is correct

[lschurr]

I updated the payment summary and verified it's correct.

• Reviewer: @rayane-d please request $250 via NewDot