Skip to content

[Due for payment 2025-05-14] Report - The Approve button still displays for Aprrover A after clicking on it #60911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
luacmartins opened this issue Apr 25, 2025 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@luacmartins
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Report - The Approve button still displays for Aprrover A after clicking on it

Version Number: v9.1.28-13 PR:59999
Reproducible in staging?: No
Reproducible in production?: No
Issue reported by: Applause Internal Team

Action Performed:

Preconditions: Control workspace has advanced approval set with 2 approvers
Employee has submitted a report to the Owner's workspace

Control approval flow guide and reference:
Employee submits to approver A
The second approver is Approver B
Approver B is the final approver

Other configurations are:
Set Submission frequency to Manually
Rules are disabled
Make or track payments set to "Disabled"

Steps:
Setup in preconditions is complete

Approver A steps:

  1. Log in as Approver A
  2. Verify the workspace chat for the employee has a GBR as an action is required
  3. Navigate to the workspace chat of the employee
  4. Verify that you see a whisper message in the employee workspace chat notifying you that a report is awaiting your approval
  5. Click on the header
  6. Click on members
  7. Verify the members listed are: employee, approver A and approver B
  8. Navigate back to the report
  9. Verify the next steps mention that "Waiting for [Approver A] to approve these expense(s)"
  10. Click on the Approve button on the expense
  11. Click on it again

Expected Result:

The Approve button dismisses and verifies the Next Step reads “Waiting for [Approver B] to approve expense(s)”

Actual Result:

The Approve button still displays in the report Admin A after clicking on the Approve button, click on it again displays an error

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6806054_1744969477445.approve_-_Trim.mp4

View all open jobs on GitHub

Copy link

melvin-bot bot commented Apr 29, 2025

@luacmartins, @borys3kk, @jnowakow Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 Weekly KSv2 labels Apr 29, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 7, 2025
@melvin-bot melvin-bot bot changed the title Report - The Approve button still displays for Aprrover A after clicking on it [Due for payment 2025-05-14] Report - The Approve button still displays for Aprrover A after clicking on it May 7, 2025
Copy link

melvin-bot bot commented May 7, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 7, 2025
Copy link

melvin-bot bot commented May 7, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-14. 🎊

For reference, here are some details about the assignees on this issue:

  • @borys3kk does not require payment (Contractor)
  • @jnowakow does not require payment (Contractor)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 13, 2025
Copy link

melvin-bot bot commented May 14, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label May 15, 2025
Copy link

melvin-bot bot commented May 16, 2025

@luacmartins, @borys3kk, @jnowakow Whoops! This issue is 2 days overdue. Let's get this updated quick!

@borys3kk
Copy link
Contributor

this issue was resolved in $ #60891

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2025
@luacmartins
Copy link
Contributor Author

Closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants