Skip to content

[Due for payment 2025-05-14] Expense - Blank green button in expense preview and report when net amount is 0 #61005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 of 8 tasks
mitarachim opened this issue Apr 29, 2025 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Apr 29, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.33-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • User A and B have no unsettled expenses.
  1. Go to staging.new.expensify.com
  2. [User A] Submit a manual expense with amount RM10 (any currency) to User B.
  3. [User B] Go to chat with User A.
  4. [User B] Submit a manual expense of the same amount (RM10) to User A.

Expected Result:

There will be no pay button for User B in the expense preview and expense report because the net amount is 0.

Actual Result:

A blank green button appears for User B in the expense preview and expense report when the net amount is 0.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6815837_1745889080201.20250429_090624.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @RachCHopkins
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Apr 29, 2025
Copy link

melvin-bot bot commented Apr 29, 2025

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 29, 2025

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 29, 2025
Copy link

melvin-bot bot commented Apr 29, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@aldo-expensify
Copy link
Contributor

Reproduced:

Image

@aldo-expensify
Copy link
Contributor

@aldo-expensify
Copy link
Contributor

Not sure if this is the right way to fix it: #61010

@jnowakow
Copy link
Contributor

cc @borys3kk

@borys3kk
Copy link
Contributor

Hi, I will take a look at this :)

@borys3kk
Copy link
Contributor

Fixed in my pr

@luacmartins
Copy link
Contributor

This view is behind a beta, so we can demote this. @aldo-expensify I'll let @borys3kk fix this in the canPay method since I think that's better.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Apr 29, 2025
@aldo-expensify
Copy link
Contributor

This view is behind a beta, so we can demote this. @aldo-expensify I'll let @borys3kk fix this in the canPay method since I think that's better.

Sounds good, thank you!

@aldo-expensify aldo-expensify removed the Reviewing Has a PR in review label Apr 29, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 5, 2025
@stephanieelliott
Copy link
Contributor

Reapplying the Bug label to get another BZ member on this while I am OOO til May 19.

@luacmartins @borys3kk correct me if I'm wrong, but it seems like as part of #60852 payment for this will be handled elsewhere?

@stephanieelliott stephanieelliott removed their assignment May 6, 2025
@stephanieelliott stephanieelliott added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 6, 2025
Copy link

melvin-bot bot commented May 6, 2025

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 6, 2025
@luacmartins
Copy link
Contributor

luacmartins commented May 6, 2025

@stephanieelliott yes, we'll handle it as part of #60852. We're good to close.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 7, 2025
@melvin-bot melvin-bot bot changed the title Expense - Blank green button in expense preview and report when net amount is 0 [Due for payment 2025-05-14] Expense - Blank green button in expense preview and report when net amount is 0 May 7, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 7, 2025
Copy link

melvin-bot bot commented May 7, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 7, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-14. 🎊

For reference, here are some details about the assignees on this issue:

  • @borys3kk does not require payment (Contractor)

Copy link

melvin-bot bot commented May 7, 2025

@luacmartins / @aldo-expensify @RachCHopkins @borys3kk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants