Skip to content

LHN - Room created via whisper is not displayed on LHN #59941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
vincdargento opened this issue Apr 9, 2025 · 7 comments
Closed
4 of 8 tasks

LHN - Room created via whisper is not displayed on LHN #59941

vincdargento opened this issue Apr 9, 2025 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@vincdargento
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5907869&group_by=cases:section_id&group_order=asc&group_id=296763
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Tap on FAB and select "Start Chat"
  3. Tap on "Room"
  4. Add a name and finish the creation flow.
  5. Once redirected to chat, add a mention of a room that doesn´t exist yet. (For example: [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-04] [HOLD for payment 2023-08-24] [HOLD for payment 2023-08-17] [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] [HOLD for payment 2023-08-07] [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] [HOLD for payment 2023-08-01] [HOLD for payment 2023-07-28] [HOLD for payment 2023-07-26] [HOLD for payment 2023-07-24] [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Implement custom buttons #123)
  6. On the whisper message displayed, tap on "Yes"
  7. Return to LHN.
  8. Note that the new room is not displayed on chats list.

Expected Result:

New room created via whisper, should be displayed on LHN on chats list.

Actual Result:

Room created via whisper, doesn´t appear on LHN and the user has to search for it on "Search" section.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

@vincdargento vincdargento added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 9, 2025

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 9, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 9, 2025
Copy link
Contributor

github-actions bot commented Apr 9, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@vincdargento
Copy link
Author

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@samranahm
Copy link
Contributor

I think this is expected since our current behavior is if there is nothing in the room don't show that in LHN

@cead22
Copy link
Contributor

cead22 commented Apr 9, 2025

I agree, since we're in focus mode in the video, I didn't expect it to show on the LHN

@cead22 cead22 closed this as completed Apr 9, 2025
@github-actions github-actions bot removed the DeployBlockerCash This issue or pull request should block deployment label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants