Skip to content

[CP Staging] Revert "fix: empty green button after paying with Expensify" #59930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

[CP Staging] Revert "fix: empty green button after paying with Expensify" #59930

merged 1 commit into from
Apr 9, 2025

Conversation

luacmartins
Copy link
Contributor

Reverts #59892

@luacmartins luacmartins self-assigned this Apr 9, 2025
@mountiny mountiny changed the title Revert "[CP Staging] fix: empty green button after paying with Expensify" [CP Staging] Revert "fix: empty green button after paying with Expensify" Apr 9, 2025
@mountiny
Copy link
Contributor

mountiny commented Apr 9, 2025

Straight revert

@luacmartins luacmartins marked this pull request as ready for review April 9, 2025 14:37
@luacmartins luacmartins requested a review from a team as a code owner April 9, 2025 14:37
@mountiny mountiny merged commit 4fa7338 into main Apr 9, 2025
14 of 17 checks passed
@mountiny mountiny deleted the revert-59892-fix/59886 branch April 9, 2025 14:37
@melvin-bot melvin-bot bot added the Emergency label Apr 9, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 9, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot requested review from blimpich and removed request for a team April 9, 2025 14:38
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 9, 2025

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

mountiny commented Apr 9, 2025

Straight revert

@OSBotify
Copy link
Contributor

OSBotify commented Apr 9, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Apr 9, 2025
@mountiny @OSBotify
Merge pull request #59930 from Expensify/revert-59892-fix/59886
d2b7cf9 
[CP Staging] Revert "fix: empty green button after paying with Expensify"

(cherry picked from commit 4fa7338)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Apr 9, 2025
@github-actions github-actions bot mentioned this pull request Apr 9, 2025
Closed
66 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.25-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.25-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@blimpich blimpich Awaiting requested review from blimpich

Assignees

@luacmartins luacmartins

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @mountiny @OSBotify