[Due for payment 2025-04-18] Threads - 'Download as PDF" option is be shown for DM thread, room and workspace chat

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Chat Report View

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to 1:1 DM.
3. Send a message.
4. Right click on the message > Reply in thread.
5. Click on the thread header.

Expected Result:

'Download as PDF" option will not be shown for DM thread.

Actual Result:

'Download as PDF" option is be shown for DM thread.
When trying to download the PDF, it fails.

The download PDF option is also seen in room details page and workspace chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Download as PDF" option is be shown for DM thread.
When trying to download the PDF, it fails.

What is the root cause of that problem?

This comes from https://github.com/Expensify/App/pull/58084/files#diff-409b0e2fb439856e9897b808014031ce244a427d116ed30f37a2e0117599adc4L558

We removed the check caseID === CASES.MONEY_REPORT then the Download as PDF option is shown for all reports if the beta is enabled.

App/src/pages/ReportDetailsPage.tsx

Line 487 in 0754949

if (canUsePDFExport) {

What changes do you think we should make in order to solve the problem?

We should add the check the report is an expense report or not back

if (canUsePDFExport && caseID === CASES.MONEY_REPORT) {

App/src/pages/ReportDetailsPage.tsx

Line 487 in 0754949

if (canUsePDFExport) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mananjadhav]

@jnowakow looks like from our PR.

[jnowakow]

@mananjadhav yup :/ will take a look

[mollfpr]

@jnowakow Are you able to create the fix PR soon?

[nkdengineer]

@mollfpr I can help with a quick fix if @jnowakow is not available.

[SzymczakJ]

@jnowakow asked me to take over this issue. From what I see, the @nkdengineer's solution fixes the issue. I can raise a PR, but I wouldn't do anything more than @nkdengineer did in his proposal.

Should we give it to @nkdengineer? @mollfpr

[mollfpr]

@SzymczakJ Thanks for the confirmation, and I agree with you. I also confirm that @nkdengineer can create the PR soon. So I'll assign the issue to them.

[mollfpr]

@mananjadhav I'm assigning for the PR review. Thanks!

[luacmartins]

FYI we reverted the original offending PR

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[jasperhuangg]

This was fixed!

[nkdengineer]

@jasperhuangg Should I get the payment here since the PR is done and we decided to revert the offending PR?

[jasperhuangg]

@nkdengineer Ah thanks for bringing that to my attention. Because you were assigned by an internal employee and you drafted a PR, you are owed 100% payment for your time. @RachCHopkins can we be sure that @nkdengineer gets paid out here?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Simplified actions on report header" #59931

If no regressions arise, payment will be issued on 2025-04-18. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

@mananjadhav @RachCHopkins @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[RachCHopkins]

@mananjadhav do we need a checklist here? Also, I assume there is no payment for you.

[mananjadhav]

Yeah looks like no payment. The PR was reverted, so no checklist as well.

[RachCHopkins]

@nkdengineer I have sent you an offer!

[RachCHopkins]

Payment Summary:

• Contributor: @nkdengineer to be paid $250 via Upwork
• Contributor+: @mananjadhav no payment due to regression.

Upwork job here

[RachCHopkins]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.