Skip to content

[Due for payment 2025-04-17] [HOLD][Simplified Actions] Remove download button from ReportDetailsPage #57441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luacmartins opened this issue Feb 26, 2025 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 26, 2025

Implement this section of the #migrate: Simplified actions framework for all reports design doc

We should hold on implementing this one until we can download via the secondary actions button

cc @jnowakow

Issue OwnerCurrent Issue Owner: @johncschuster
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Feb 26, 2025
@luacmartins luacmartins self-assigned this Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

Triggered auto assignment to @johncschuster (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 26, 2025
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 26, 2025
@jnowakow
Copy link
Contributor

Hello, I'm from Software Mansion, an expert agency, and I'll work on this one

@luacmartins
Copy link
Contributor Author

We should hold on implementing this one until we can download via the secondary actions button

@luacmartins luacmartins changed the title [Simplified Actions] Remove download button from ReportDetailsPage [HOLD][Simplified Actions] Remove download button from ReportDetailsPage Feb 26, 2025
Copy link

melvin-bot bot commented Mar 4, 2025

@johncschuster, @luacmartins, @jnowakow Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2025
@luacmartins
Copy link
Contributor Author

We'll get started on it this week

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2025
@flaviadefaria flaviadefaria moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Mar 4, 2025
@melvin-bot melvin-bot bot added the Overdue label Mar 7, 2025
Copy link

melvin-bot bot commented Mar 10, 2025

@johncschuster, @luacmartins, @jnowakow Eep! 4 days overdue now. Issues have feelings too...

@luacmartins
Copy link
Contributor Author

Still on hold. holding issues are moving along though

@melvin-bot melvin-bot bot removed the Overdue label Mar 10, 2025
@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Mar 10, 2025
@melvin-bot melvin-bot bot added the Overdue label Mar 19, 2025
@johncschuster
Copy link
Contributor

Looks like we've got a linked PR! 🥳

@melvin-bot melvin-bot bot removed the Overdue label Mar 19, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 21, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 7, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Apr 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins
Copy link
Contributor Author

Closing in favor of #59960. We'll handle payment in that issue.

@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Apr 9, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 10, 2025
@melvin-bot melvin-bot bot changed the title [HOLD][Simplified Actions] Remove download button from ReportDetailsPage [Due for payment 2025-04-17] [HOLD][Simplified Actions] Remove download button from ReportDetailsPage Apr 10, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 10, 2025
Copy link

melvin-bot bot commented Apr 10, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 10, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.25-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-17. 🎊

For reference, here are some details about the assignees on this issue:

  • @jnowakow does not require payment (Contractor)

Copy link

melvin-bot bot commented Apr 10, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@jnowakow] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Development

No branches or pull requests

3 participants