Skip to content

[Due for payment 2025-03-13] [Simplified Actions] Implement getPrimaryAction with tests #57436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luacmartins opened this issue Feb 26, 2025 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 26, 2025

Implement this section of the #migrate: Simplified actions framework for all reports design doc

cc @jnowakow

Issue OwnerCurrent Issue Owner: @bfitzexpensify
@luacmartins luacmartins added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 26, 2025

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Feb 26, 2025

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 26, 2025
@luacmartins luacmartins changed the title Implement getPrimaryAction with tests [Simplified Actions] Implement getPrimaryAction with tests Feb 26, 2025
@dubielzyk-expensify
Copy link
Contributor

Anything needed from me here?

@jnowakow
Copy link
Contributor

Hello, I'm from Software Mansion, an expert agency, and I'll work on this one

@luacmartins
Copy link
Contributor Author

Anything needed from me here?

@dubielzyk-expensify we're good for now. I'll unassign you

@jnowakow
Copy link
Contributor

jnowakow commented Mar 3, 2025

@luacmartins the UI is modified as well in this section. On slack you wrote about writing only getPrimaryAction function and tests. There are already tasks for UI changes (#57439 and #57441) but I think we have to do all this UI changes in one PR.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Mar 3, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 3, 2025
@luacmartins
Copy link
Contributor Author

There are already tasks for UI changes (#57439 and #57441) but I think we have to do all this UI changes in one PR.

Yea, that's fine. We can add the UI changes once the rest of the logic is in place!

@flaviadefaria flaviadefaria moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Mar 4, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 6, 2025
@melvin-bot melvin-bot bot changed the title [Simplified Actions] Implement getPrimaryAction with tests [Due for payment 2025-03-13] [Simplified Actions] Implement getPrimaryAction with tests Mar 6, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 6, 2025
Copy link

melvin-bot bot commented Mar 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.9-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-13. 🎊

For reference, here are some details about the assignees on this issue:

  • @jnowakow does not require payment (Contractor)

Copy link

melvin-bot bot commented Mar 6, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@jnowakow] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@ikevin127
Copy link
Contributor

@bfitzexpensify I will require payment here as C+ reviewer of PR #57475 mentioned in #57436 (comment).

  • [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

🟢 No regression test needed for this PR as they will be added later when getPrimaryAction will actually be used - see #57475 (comment) for more details.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Mar 13, 2025
@bfitzexpensify
Copy link
Contributor

Offer sent @ikevin127

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2025
@ikevin127
Copy link
Contributor

@bfitzexpensify Offer accepted, thank you!

@bfitzexpensify
Copy link
Contributor

Payment complete, closing this out.

@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Mar 14, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

6 participants