[Due for payment 2025-04-18] [$250] Approve button is present when expense report has no expense, empty green button is present

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• "Delay submissions" (set to Manually) and "Add approvals" are enabled.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Click Submit.
5. Click on the expense preview.
6. Send a message to the expense report.
7. Go offline.
8. Click More > Delete expense.
9. Delete the expense.
10. Click Approve.

Expected Result:

In Step 10, Approve button should not be present when there is no more expense.

Actual Result:

In Step 10, Approve button is present when there is no more expense.
After approving the expense, there is a green button with no purpose.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6796823_1744180128699.20250409_124649.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909929813119397026
• Upwork Job ID: 1909929813119397026
• Last Price Increase: 2025-04-09
• Automatic offers:
• nkdengineer | Contributor | 106851017

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@suneox @jnowakow @rayane-d @luacmartins

[rayane-d]

cc @mananjadhav

[MariaHCD]

👋🏼 Hey, team. Is this caused by a specific PR? Are we planning to revert or do we have a fix in mind for this?

[jnowakow]

@MariaHCD it's caused by #58084 :/

[MariaHCD]

Ah, okay, thanks @jnowakow

Seems like a revert of that PR is not an option - so let's roll forward and fix this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909929813119397026

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jnowakow]

@MariaHCD I hope we'll manage without revert 😅

[maksym-shpak]

Proposal

I will conditionally render the "Approve" button only when the expense report contains at least one expense. This check will be added in the component logic rendering the report footer.

To test:

• Reproduce issue with empty report (no expenses).
• Add mock expense to confirm button reappears.
• Verify behavior across Web, iOS, Android.
• Add/extend test coverage if applicable.

Let me know if this direction is good — ready to proceed.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[luacmartins]

FYI we reverted the original offending PR

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[jjcoffee]

@abekkala This one will still need to be paid out as a PR was raised. I'm not sure of the timeline, but I guess it can be paid out without waiting as there isn't a regression period as such!

[abekkala]

Given the PR was created and full review was completed : this will get paid out at 100%

PAYMENT SUMMARY

• @nkdengineer [$250] OFFER
• @jjcoffee [$250] payment via NewDot

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Simplified actions on report header" #59931

If no regressions arise, payment will be issued on 2025-04-18. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@jjcoffee @abekkala @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[abekkala]

PAYMENT SUMMARY

• @nkdengineer [$250] payment sent and Upwork contract ended
• @jjcoffee [$250] payment via NewDot

[garrettmknight]

$250 approved for @jjcoffee