[HOLD PR 61378][$250] mWeb - Expense - Device´s back button after cancelling payment, leads to details page again.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.33-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Money Requests

Action Performed:

1. Open the staging.new.expensify.com website.
2. Open any workspace chat.
3. Create a manual expense.
4. Tap on "Pay Elsewhere" on expense preview.
5. Open the expense report.
6. Tap on report header and cancel the payment.
7. When redirected to report again, use device´s back button.
8. Note that you land on details page again instead of landing on chat.

Expected Result:

When using device back button on expense report, after cancelling payment, the user should return to chat.

Actual Result:

When using device´s back button after cancelling an expense´s payment, the user lands on expense´s details page again instead of returning to chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6815909_1745897118446.Details.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Pujan92

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021922198667693655644
• Upwork Job ID: 1922198667693655644
• Last Price Increase: 2025-05-13

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[techievivek]

Should be fine to demote this since it doesn't block user from returning to chat.

[borys3kk]

Hi, first things first the issue in question is not reproducible in new view we are trying to push pr 59999, should we try to fix it anyway or leave it as it is?
secondly
the issue is kinda expected behaviour because when we are canceling payment we are pushing the reportsplit into navigation routes so our stack looks like this before cancel:

and after cancel:

the back button of the device just 'pops' the last route so it is expected that we go back to details page
see here for more info
the solution for this would be to just pop the details page when redirected to report

[techievivek]

Hi, first things first the issue in question is not reproducible in new view we are trying to push #59999, should we try to fix it anyway or leave it as it is?

If this is going to be resolved by the ongoing PR, I don’t think we need a separate fix in the meantime as the bug itself is not very concerning.

the issue is kinda expected behaviour because when we are canceling payment we are pushing the reportsplit into navigation routes so our stack looks like this before cancel:

I think it would be best to take the user to chat report in this case.

[techievivek]

We can put this on HOLD for #59999

[sakluger]

FYI, #59999 was just deployed to prod.

[sakluger]

I will be OOO from May 5 - 16, so I have added another BZ member to watch over the issue while I'm out.

I also just removed the hold since the other issue is live on Prod. I am going to ask for a QA retest (https://expensify.slack.com/archives/C9YU7BX5M/p1746202182370999) - if it's no longer reproduceable, we can close the issue.

[IuliiaHerets]

@sakluger Tester still can repro the issue, build 9.1.39-2

screen-20250502-134351.mp4

[sakluger]

@techievivek how should we handle this since the other PR didn't fix it?

[melvin-bot]

@sakluger, @jliexpensify, @techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

Bump @techievivek !

[mallenexpensify]

Made @techievivek issue owner so it'll go overdue, remove once you've replied. Thx

[melvin-bot]

@sakluger @jliexpensify @techievivek this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[techievivek]

Sending this to external to get some eyes on.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021922198667693655644

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When using device´s back button after cancelling an expense´s payment, the user lands on expense´s details page again instead of returning to chat.

What is the root cause of that problem?

We removed the logic navigation from the previous page here. The reason is this action is on the report page now. But we still need to go back to the previous page for the action on the report detail page.

31fe5b8#diff-9c07b44e092fd3d975806649be46d76b75a377c16e32ed86597b630a84c290d0L9445

App/src/pages/ReportDetailsPage.tsx

Lines 414 to 416 in 12e6cb3

	cancelPaymentAction(moneyRequestReport, chatReport);
	setIsConfirmModalVisible(false);
	}, [moneyRequestReport, chatReport]);

What changes do you think we should make in order to solve the problem?

We should add Navigation.goBack logic to the report detail page here. After add this logic again, I can't reproduce the original bug.

Navigation.goBack(backTo);
setIsConfirmModalVisible(false);

App/src/pages/ReportDetailsPage.tsx

Lines 414 to 416 in 12e6cb3

	cancelPaymentAction(moneyRequestReport, chatReport);
	setIsConfirmModalVisible(false);
	}, [moneyRequestReport, chatReport]);

Optional: We can wrap the navigation logic into InteractionManager.runAfterInteractions to make sure the navigation is executed after the confirm modal is closed.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[borys3kk]

Hi, I think that this issue doesn't need any fix as new preview and header buttons will be live in the very near future and as I stated above this would solve this issue
the issue removing the view causing a bug was already merged to main but not yet deployed to staging:
$ #61378

[jliexpensify]

@Pujan92 / @techievivek thoughts on this?

[techievivek]

Based on the updates provided by @borys3kk we can just keep this issue on HOLD since the issue will no longer be reproducible once #61378 gets deployed.