Fixes for change policy feature #58534

rayane-d · 2025-03-16T17:51:33Z

Explanation of Change

Fixes for issues from this list: #57464 (comment)

This is a follow up to Feature: Implement ChangeReportPolicy #57553

Fixed Issues

$ #58428
$ #58432
$ #58433
$ #58451
$ #58459
$ #58462
$ #58516

PROPOSAL:

Tests

Test 1

Precondition: Account has two workspaces.
Go to workspace chat of the first workspace.
Submit an expense.
Go offline.
Delete the second workspace.
Go to the expense report from Step 3.
Copy link to this report and add /change-workspace then send it in the chat and click on it
Verify that the deleted workspace is not included in the workspaces list

Test 2

Create a new workspace.
Go to workspace chat.
Submit two expenses.
Go to transaction thread of any expense.
Add /change-workspace to the end of the URL and navigate to it.
Expected Result: Not found page should open

Test 3

Precondition: Account has self DM and at least one workspace.
Go to self DM.
Track a manual expense.
Go to transaction thread.
Add /change-workspace to the end of the URL and navigate to it.
Expected Result: Not found page should open

Test 4

Test on android native app
Pre-condition: app language set to Spanish. Should have at least 2 workspaces
Open a workspace chat > Create expense
Copy the share url from details page
Paste the URL in report page and add /chage-workspace to it and send the URL
Open the link
Note a banner is shown
Expected Result: "Trabajo" word must be shown in the change workspace banner and must not be cut off.

Test 5

Prerequisite: Have at least two workspaces available.
Open any workspace chat.
Create an expense.
Open the expense report.
Tap on the header and select "Share"
Copy the URL.
Return to report and paste the URL.
At the end of it, add /change-workspace
Tap on header again and delete the expense.
Return to LHN and open the expense report thread.
Tap on the URL
Expected Result: Not found page should open

Test 6

Precondition: User is logged into two sessions. Account has two workspaces.
[Session A] Go to workspace chat and submit an expense.
[Session A] Go to expense report.
[Session A] Add /change-workspace to the end of the URL and send the link to the report.
[Session A] Go offline.
[Session B] Delete the second workspace.
[Session A] Click on the link in Step 4.
[Session A] Select the deleted workspace.
[Session A] Go online.
Expected Result: Session A should receive an error that the moving fails.

Test 7

Create two workspaces, create an expense report with 2 expenses in the workspace chat 1
Send the url of the report to any chat, append /change-workspace to the URL
Tap on the new link
From the workspace selection list select Workspace 2.
Tap "Got it" on the educational modal
Navigate to LHN and observe the messages displayed for the workspace 1 and 2
Expected Result: Owed amount for the expense report and GBR is shown only for workspace 2, where the report was moved to. workspace 1 chat should not have a GBR and should not show Owed amount message in LHN

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

[Change Policy] Report - Report workspace changed be changed to a deleted workspace in offline mode #58428

Screenshot/Video

Screen.Recording.2025-03-16.at.6.29.18.PM.mov
[Change Policy] Expense - Workspace page is blank when opened /change-workspace from individual expense #58432

Screenshot/Video
[Change Policy] Track expense - Expense is not moved to workspace when navigate to /change-workspace #58433

Screenshot/Video
[Change Policy] Android -expense-Trabajo word is missing in change workspace banner #58451

Screenshot/Video
[Change Policy] Expense - Deleted expense can still be moved to a different workspace. #58459

Screenshot/Video

Screen.Recording.2025-03-16.at.11.03.16.PM.mov
[Change Policy] Expense - No error message when moving report fails #58462

Screenshot/Video

Screen.Recording.2025-03-16.at.6.29.18.PM.mov
[Change Policy] LHN - "Workspace owes.." is displayed for the old workspace after moving the report #58516

Screenshot/Video

Screen.Recording.2025-03-16.at.8.46.36.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rayane-d · 2025-03-16T17:54:22Z

melvin-bot · 2025-03-18T14:46:58Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-03-18T15:54:40Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny

Looks good to me, @eVoloshchak can you please prioritize this review? thanks!

github-actions · 2025-03-18T16:08:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android Hybrid build failed	The QR code can't be generated, because the iOS Hybrid build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/58534/NewExpensify.dmg	https://58534.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

eVoloshchak · 2025-03-18T17:45:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

#58428

Screen Recording

Screen.Recording.2025-03-18.at.21.48.35.mov

#58432

Screen Recording

Screen.Recording.2025-03-18.at.21.56.50.mov

#58433

Screen Recording

Screen.Recording.2025-03-18.at.21.58.27.mov

#58436 - Closed

#58437 - Backend bug

#58442 - Resolved by #58520

#58443 - Backend bug

#58445 - Backend bug

#58447 - on HOLD

#58451

Screen Recording

Screen.Recording.2025-03-18.at.22.17.33.mov

#58458 - Not reproducible

#58459

Screen Recording

Screen.Recording.2025-03-18.at.22.23.53.mov

#58462

Screen Recording

Screen.Recording.2025-03-18.at.22.36.12.mov

#58516

Screen Recording

Screen.Recording.2025-03-18.at.22.44.35.mov

luacmartins

LGTM

eVoloshchak

LGTM!

mountiny

@luacmartins wanna merge?

OSBotify · 2025-03-18T23:44:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-20T15:37:18Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-21T22:21:20Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.16-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

rayane-d added 4 commits March 16, 2025 16:37

hide pending deleted workspace from change workspace list

115d69e

show a not found page for transaction thread

a10d963

Show not found page in the case of pending deletion report

6a391bb

Add error message when moving report fails

4202218

rayane-d added 4 commits March 16, 2025 20:51

Fix LHN for the old workspace chat after moving the report

ba3a5e1

Fix: Trabajo word is cut off

017f882

prettier

3335fa2

don't allow a report with 0 total to be moved to another workspace

92aaeb4

rayane-d mentioned this pull request Mar 16, 2025

[Due for payment 2025-03-24] [Simplified Actions] [App] Implement ChangeReportPolicy #57464

Closed

luacmartins requested review from eVoloshchak and luacmartins March 17, 2025 17:19

rayane-d marked this pull request as ready for review March 18, 2025 14:46

rayane-d requested a review from a team as a code owner March 18, 2025 14:46

melvin-bot bot requested review from mountiny and removed request for a team March 18, 2025 14:46

mountiny assigned rayane-d Mar 18, 2025

mountiny added the Ready To Build label Mar 18, 2025

mountiny approved these changes Mar 18, 2025

View reviewed changes

luacmartins approved these changes Mar 18, 2025

View reviewed changes

eVoloshchak approved these changes Mar 18, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny March 18, 2025 21:46

mountiny approved these changes Mar 18, 2025

View reviewed changes

luacmartins merged commit c94cb19 into Expensify:main Mar 18, 2025
19 of 25 checks passed

rayane-d deleted the Fixes-for-Change-Policy-feature branch March 18, 2025 23:44

github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Mar 19, 2025

This was referenced Mar 19, 2025

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #58671

Closed

Deploy Checklist: New Expensify 2025-03-20 #58801

Closed

luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Mar 20, 2025

melvin-bot bot mentioned this pull request Mar 21, 2025

[Due for payment 2025-03-28] [Change Policy] LHN - "Workspace owes.." is displayed for the old workspace after moving the report #58516

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixes for change policy feature #58534

Fixes for change policy feature #58534

Uh oh!

rayane-d commented Mar 16, 2025 •

edited

Loading

Uh oh!

rayane-d commented Mar 16, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

mountiny left a comment

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

eVoloshchak commented Mar 18, 2025 •

edited

Loading

Uh oh!

luacmartins left a comment

Uh oh!

eVoloshchak left a comment

Uh oh!

mountiny left a comment

Uh oh!

Uh oh!

OSBotify commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

Uh oh!

Fixes for change policy feature #58534

Fixes for change policy feature #58534

Uh oh!

Conversation

rayane-d commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 1

Test 2

Test 3

Test 4

Test 5

Test 6

Test 7

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

rayane-d commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

eVoloshchak commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

Uh oh!

rayane-d commented Mar 16, 2025 •

edited

Loading

rayane-d commented Mar 16, 2025 •

edited

Loading

eVoloshchak commented Mar 18, 2025 •

edited

Loading