Skip to content

[Change Policy] Expense - Every field on expense report is displayed empty after changing expense to other WS #58437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
jponikarchuk opened this issue Mar 14, 2025 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@jponikarchuk
Copy link

jponikarchuk commented Mar 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: User should have at least two workspaces created.

  1. Open the Expensify app.
  2. Open any worksapce.
  3. Tap on the "+" button and select "Create Expense"
  4. Complete the creation flow.
  5. Once redirected to chat, open the expense report.
  6. Tap on header and select "Share"
  7. Copy expense URL.
  8. Return to expense report.
  9. Paste the URL and add /change-workspace to it.
  10. Send the link and tap on it.
  11. Select a different workspace to move the expense to.
  12. Once redirected to report again, check how are all the fields on the report, displayed after this action.

Expected Result:

All the information in the expense report fields, should still be visible after moving the expense to a different workspace.

Actual Result:

All the fields on expense report are displayed empty after moving the expense to a different workspace.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6770316_1741926836556.Empty.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @luacmartins
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 14, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rayane-d
Copy link
Contributor

I think this is not a blocker, given that this feature is currently only accessible via URL. However, it is definitely a bug we should fix.

@mollfpr
Copy link
Contributor

mollfpr commented Mar 14, 2025

I agree with @rayane-d 👍

@mollfpr mollfpr added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 14, 2025
@mollfpr
Copy link
Contributor

mollfpr commented Mar 14, 2025

@rayane-d Do you plan to have a PR to fix the bugs related to this feature?

@mountiny mountiny assigned luacmartins and unassigned mollfpr Mar 14, 2025
@mountiny mountiny moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Mar 14, 2025
@mountiny
Copy link
Contributor

Assigning Carlos as he is handling this project with me. Added it to the migrate project

@mountiny mountiny changed the title Expense -Every field on expense report is displayed empty after changing expense to other WS [Change Policy] Expense - Every field on expense report is displayed empty after changing expense to other WS Mar 14, 2025
@trjExpensify
Copy link
Contributor

All the information in the expense report fields, should still be visible after moving the expense to a different workspace.

The way OldDot handles this is as follows:

  • fields that are available on the workspace you've moved to are shown, and if there's any "invalid" coding, violations appear. For example, if the category value is no longer valid because it doesn't exist on the new workspace.
  • fields that are not on the workspace you've moved the report to disappear (e.g had tags selected on the expense, moved to a workspace with no tags).
  • Tax looks like it's handled a little inconsistently when moving to a workspace with tax disabled, whereby the values remain and there's a button to delete tax. I think we can treat this like tags though, where the values disappear if tax isn't enabled on the workspace you moved to.

Example:

  • I had categories, tag and tax selected.
  • Moved the report to a workspace with no tags or tax enabled.
  • Category value remains but invalid, tags disappear, tax remains hanging out.
Image

@rayane-d
Copy link
Contributor

@luacmartins I think this is a backend bug. The report displays correctly when changing the workspace offline, but the fields become empty after going online. They are only corrected after reopening the report (when OpenReport is executed).

@luacmartins
Copy link
Contributor

I can take a look

Copy link

melvin-bot bot commented Mar 20, 2025

@rayane-d Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Mar 20, 2025
@lydiabarclay lydiabarclay added the Internal Requires API changes or must be handled by Expensify staff label Mar 20, 2025
@lydiabarclay
Copy link

@luacmartins any updates?

@luacmartins
Copy link
Contributor

Not yet! It's on my list though

@luacmartins
Copy link
Contributor

My plate is quite full and I haven't gotten to this one yet. Still on my list though.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 25, 2025
@lydiabarclay lydiabarclay added Weekly KSv2 and removed Daily KSv2 labels Mar 27, 2025
@melvin-bot melvin-bot bot removed the Overdue label Mar 27, 2025
@lydiabarclay
Copy link

@luacmartins I updated to weekly, feel free to change it back if that makes more sense for your prioritization at this point

Copy link

melvin-bot bot commented Mar 28, 2025

@eVoloshchak @luacmartins @rayane-d @lydiabarclay this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Apr 7, 2025
@lydiabarclay
Copy link

Hi @luacmartins just following up on this!

@luacmartins
Copy link
Contributor

Ah yes, this is done and the PR is deployed to prod. We're good to close.

@melvin-bot melvin-bot bot removed the Overdue label Apr 7, 2025
@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Development

No branches or pull requests

8 participants