[Due for payment 2025-03-24] [Simplified Actions] [App] Implement ChangeReportPolicy

[luacmartins]

Implement this section of the #migrate: Simplified actions framework for all reports design doc

Issue Owner

Current Issue Owner: @rayane-d

[melvin-bot]

Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[luacmartins]

@rayane-d we still need some backend changes for this one, but you could start working on the App changes now if you'd like to.

[rayane-d]

Sure!

[rayane-d]

Started working on this one

[rayane-d]

Draft PR: #57553

[rayane-d]

The PR is almost ready for review, pending translation confirmation and testing steps.

[rayane-d]

Just opened the PR for review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[luacmartins]

So we had a number of issues that came out of the PR. I'll list them here so we can track the progress on each:

• [Due for payment 2025-03-28] [Change Policy] Report - Report workspace changed be changed to a deleted workspace in offline mode #58428
• [Due for payment 2025-03-28] [Change Policy] Expense - Workspace page is blank when opened /change-workspace from individual expense #58432
• [Due for payment 2025-03-28] [Change Policy] Track expense - Expense is not moved to workspace when navigate to /change-workspace #58433
• [Change Policy] Desktop - Change Workspace - Only WS with report is shown on WS selector #58436
• [Change Policy] Expense - Every field on expense report is displayed empty after changing expense to other WS #58437
• [Due for payment 2025-03-27] [Change Policy] Expense - Report migration system message shows "undefined" after a restart #58442 - in review
• [Change Policy] Expense - System message created when changing expense´s WS, disappears when reacting to it. #58443 - in review
• [Change Policy] Expense - Expense migration educational modal reappears each time after app restart #58445 - in review
• [HOLD Simplified Actions project][Change Policy] Reports - App returns to Inbox after changing expense workspace in Reports #58447
• [Due for payment 2025-03-28] [Change Policy] Android -expense-Trabajo word is missing in change workspace banner #58451
• [Change Policy] Expense - Able to choose to move report from invited to owner workspace but moving fails #58458
• [Due for payment 2025-03-28] [Change Policy] Expense - Deleted expense can still be moved to a different workspace. #58459
• [Due for payment 2025-03-28] [Change Policy] Expense - No error message when moving report fails #58462
• [Due for payment 2025-03-28] [Change Policy] LHN - "Workspace owes.." is displayed for the old workspace after moving the report #58516

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feature: Implement ChangeReportPolicy #57553

If no regressions arise, payment will be issued on 2025-03-24. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-d requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-d] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[OfstadC]

@rayane-d Please complete the BZ Checklist prior to the payment date. 😃 Thank you!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rayane-d owed $250 via NewDot

BugZero Checklist (@OfstadC)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[OfstadC]

@rayane-d Please complete BZ checklist so we can issue payment here 😃

[OfstadC]

bump @rayane-d

[rayane-d]

Sorry for the delay- I’ve been under the weather for the past few days but am catching up today.

[rayane-d]

BugZero Checklist:

• [@rayane-d] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/485535

Regression Tests Proposal

Test 1:

1. Open an existing workspace expenses report or create a new one if none exists. Ensure the expenses report has some expenses attached to it.
2. Note: Transactions reports, track expense, invoices, and P2P reports are out of scope for this feature. This is related only to the workspace expenses reports.
3. Append /change-workspace to the URL of the expenses report. Example: If the report URL is https://new.expensify.com/r/123456, change it to https://new.expensify.com/r/123456/change-workspace. For native platforms:
4. click on the report header
5. Click "Share"
6. Click "Copy url"
7. Paste the url in chat
8. Add /change-workspace
9. Send the url in chat
10. Click on it
11. Verify that the workspace selection list is displayed.
12. Verify that the expense report's workspace is marked as selected.
13. From the workspace selection list, choose a different workspace.
14. Verify that the educational modal titled "You moved this report!" is displayed.
15. Dismiss the Educational Modal
16. Verify that the modal closes and you are redirected back to the report page.
17. Verify that the report is moved to the selected workspace (workspace chat).
18. Verify that the report's policy ID has been updated to reflect the new workspace.
19. Verify that the policy ID of all the child reports hierarchy of the report has been updated to reflect the new workspace.
20. Verify that a new report action of type CHANGEPOLICY is added, indicating the workspace change.
21. Ensure the report action message correctly reflects the old and new workspace names.

Test 2:

1. Precondition: Account has two workspaces.
2. Go to workspace chat of the first workspace.
3. Submit an expense.
4. Go offline.
5. Delete the second workspace.
6. Go to the expense report from Step 3.
7. Copy link to this report and add /change-workspace then send it in the chat and click on it
8. Verify that the deleted workspace is not included in the workspaces list

Test 3:

1. Create a new workspace.
2. Go to workspace chat.
3. Submit two expenses.
4. Go to transaction thread of any expense.
5. Add /change-workspace to the end of the URL and navigate to it.
6. Expected Result: Not found page should open

Test 4:

1. Precondition: Account has self DM and at least one workspace.
2. Go to self DM.
3. Track a manual expense.
4. Go to transaction thread.
5. Add /change-workspace to the end of the URL and navigate to it.
6. Expected Result: Not found page should open

Test 5:

1. Test on android native app
2. Pre-condition: app language set to Spanish. Should have at least 2 workspaces
3. Open a workspace chat > Create expense
4. Copy the share url from details page
5. Paste the URL in report page and add /chage-workspace to it and send the URL
6. Open the link
7. Note a banner is shown
8. Expected Result: "Trabajo" word must be shown in the change workspace banner and must not be cut off.

Test 6:

1. Prerequisite: Have at least two workspaces available.
2. Open any workspace chat.
3. Create an expense.
4. Open the expense report.
5. Tap on the header and select "Share"
6. Copy the URL.
7. Return to report and paste the URL.
8. At the end of it, add /change-workspace
9. Tap on header again and delete the expense.
10. Return to LHN and open the expense report thread.
11. Tap on the URL
12. Expected Result: Not found page should open

Test 7:

1. Precondition: User is logged into two sessions. Account has two workspaces.
2. [Session A] Go to workspace chat and submit an expense.
3. [Session A] Go to expense report.
4. [Session A] Add /change-workspace to the end of the URL and send the link to the report.
5. [Session A] Go offline.
6. [Session B] Delete the second workspace.
7. [Session A] Click on the link in Step 4.
8. [Session A] Select the deleted workspace.
9. [Session A] Go online.
10. Expected Result: Session A should receive an error that the moving fails.

Test 8:

1. Create two workspaces, create an expense report with 2 expenses in the workspace chat 1
2. Send the url of the report to any chat, append /change-workspace to the URL
3. Tap on the new link
4. From the workspace selection list select Workspace 2.
5. Tap "Got it" on the educational modal
6. Navigate to LHN and observe the messages displayed for the workspace 1 and 2
7. Expected Result: Owed amount for the expense report and GBR is shown only for workspace 2, where the report was moved to. workspace 1 chat should not have a GBR and should not show Owed amount message in LHN

Do we agree 👍 or 👎

[bfitzexpensify]

Just noting that this caused a regression here.

[rayane-d]

@bfitzexpensify - Replied here: #58462 (comment)

[bfitzexpensify]

Cool, yep - no regression caused here @OfstadC

[OfstadC]

Can confirm we are ready to issue payment here and the Payment Summary here is accurate

[garrettmknight]

$250 approved for @rayane-d