Skip to content

[Change Policy] Expense - System message created when changing expense´s WS, disappears when reacting to it. #58443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
mitarachim opened this issue Mar 14, 2025 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@mitarachim
Copy link

mitarachim commented Mar 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: User should have at least two workspaces available.

  1. Open the Expensify app.
  2. Open any workspace chat.
  3. Create an expense.
  4. Open the just created expense report.
  5. Tap on the header and select "Share"
  6. Copy the expense URL.
  7. Return to report.
  8. Paste the URL and add /change-workspace to it.
  9. Send the link and tap on it.
  10. Select any workspace to move the expense to.
  11. Navigate to the workspace where the expense was moved to.
  12. Open the expense report.
  13. Long tap on the system message generated when the expense was moved.
  14. Add any reaction to the message.
  15. Check the system message behaviour when a reaction is added to it.

Expected Result:

System message should remain visible after a reaction is added to it.

Actual Result:

System message generated when an expense is moved to a different workspace, disappears after reacting to it.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6770343_1741929426077.React.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @luacmartins
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Mar 14, 2025
@mountiny
Copy link
Contributor

This is hidden from users not a blocker

@mountiny mountiny changed the title Expense - System message created when changing expense´s WS, disappears when reacting to it. [Change Policy] Expense - System message created when changing expense´s WS, disappears when reacting to it. Mar 14, 2025
@trjExpensify
Copy link
Contributor

System message generated when an expense is moved to a different workspace, disappears after reacting to it.

Agreed, you should be able to react to this system message like any other. Perhaps consolidate with undefined here?

@luacmartins
Copy link
Contributor

Got a couple of PRs in review

@luacmartins luacmartins added the Reviewing Has a PR in review label Mar 14, 2025
@rayane-d
Copy link
Contributor

Got a couple of PRs in review

I think this is backend only. Let me know if any frontend changes are needed.

@luacmartins
Copy link
Contributor

Yea, backend only. PRs are already in review.

@flaviadefaria flaviadefaria moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Mar 18, 2025
@luacmartins
Copy link
Contributor

This is done and deployed. Closing.

@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
Development

No branches or pull requests

8 participants