Skip to content

[Change Policy] Desktop - Change Workspace - Only WS with report is shown on WS selector #58436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
mitarachim opened this issue Mar 14, 2025 · 9 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Mar 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57553
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5
App Component: Other

Action Performed:

  1. Log out of Desktop app
  2. On Web Go to https://staging.new.expensify.com/
  3. Create two Workspaces and add an expense on one of them.
  4. Go to the report (created expense) and Append /change-workspace to the URL of the report.
  5. Click on "Open New Expensify" popup to navigate to Desktop app
  6. Notice only one Workspace is shown on the Change workspace page

Expected Result:

All workspaces are shown in the selection page

Actual Result:

Only the workspace with the report is shown

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6770263_1741922581319.Screen_Recording_2025-03-14_at_6.11.32_in_the_morning.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @rayane-d
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rayane-d
Copy link
Contributor

I think this is not a blocker.

@luacmartins The workspaces displayed in the list are only those available in Onyx. I think we need to implement an API read command to fetch the workspaces when this page is opened.

@MariaHCD
Copy link
Contributor

Makes sense that this shouldn't block the deploy 👍🏼

I'll defer to @luacmartins about how we want to handle this follow up improvement.

@MariaHCD MariaHCD added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Mar 14, 2025
@mountiny
Copy link
Contributor

Assigning myself as we are handling this project with Carlos

@rayane-d All policies are loaded during OpenApp, I am not sure if this would be the RCA

@mountiny mountiny moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Mar 14, 2025
@mountiny mountiny changed the title Desktop - Change Workspace - Only WS with report is shown on WS selector [Change Policy] Desktop - Change Workspace - Only WS with report is shown on WS selector Mar 14, 2025
@luacmartins luacmartins self-assigned this Mar 14, 2025
@trjExpensify
Copy link
Contributor

All workspaces are shown in the selection page

Agreed, albeit a bit of a edge case thing to do mid "change workspace".

@luacmartins
Copy link
Contributor

I agree that all the policies should be available in Onyx via OpenApp. I'm also unable to reproduce this. I just see the transaction thread when I'm navigated to the Desktop app, no Change workspace RHP. I'm gonna close this since as @trjExpensify mentioned, it's an edge case.

Screen.Recording.2025-03-14.at.11.50.32.AM.mov

@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Development

No branches or pull requests

8 participants