-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Feature: Implement ChangeReportPolicy #57553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Implement ChangeReportPolicy #57553
Conversation
d0ab9ca
to
61f4961
Compare
I had to force-push to sign my commits |
Requested translation confirmation in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1741005706637539 |
@luacmartins Are there existing manual testing steps for this feature / design doc? |
@Expensify/design for eyes on this new modal #57553 (comment) |
Looking good! I wonder if we should bold @Expensify/design Do we typically use |
Updated @eVoloshchak this is ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@rayane-d Can you help with the following step for native apps?
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.13-0 🚀
|
This is a dev command. For native platforms, you can:
|
@kavimuru I updated the tests |
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.13-5 🚀
|
Explanation of Change
Fixed Issues
$ #57464
PROPOSAL: N/A
Tests
/change-workspace
to the URL of the expenses report. Example: If the report URL is https://new.expensify.com/r/123456, change it to https://new.expensify.com/r/123456/change-workspace. For native platforms:CHANGEPOLICY
is added, indicating the workspace change.Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2025-03-12.at.10.28.55.PM.mov
Android: mWeb Chrome
Screen.Recording.2025-03-12.at.10.09.05.PM.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-12.at.22.16.05.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-04.at.20.36.47.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-03-04.at.8.02.29.PM.mov
MacOS: Desktop
Screen.Recording.2025-03-12.at.10.11.24.PM.mov