Skip to content

Feature: Implement ChangeReportPolicy #57553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Mar 13, 2025

Conversation

rayane-d
Copy link
Contributor

@rayane-d rayane-d commented Feb 27, 2025

Explanation of Change

Fixed Issues

$ #57464
PROPOSAL: N/A

Tests

  1. Open an existing workspace expenses report or create a new one if none exists. Ensure the expenses report has some expenses attached to it.
    • Note: Transactions reports, track expense, invoices, and P2P reports are out of scope for this feature. This is related only to the workspace expenses reports.
  2. Append /change-workspace to the URL of the expenses report. Example: If the report URL is https://new.expensify.com/r/123456, change it to https://new.expensify.com/r/123456/change-workspace. For native platforms:
    • click on the report header
    • Click "Share"
    • Click "Copy url"
    • Paste the url in chat
    • Add /change-workspace
    • Send the url in chat
    • Click on it
  3. Verify that the workspace selection list is displayed.
  4. Verify that the expense report's workspace is marked as selected.
  5. From the workspace selection list, choose a different workspace.
  6. Verify that the educational modal titled "You moved this report!" is displayed.
  7. Dismiss the Educational Modal
  8. Verify that the modal closes and you are redirected back to the report page.
  9. Verify that the report is moved to the selected workspace (workspace chat).
  10. Verify that the report's policy ID has been updated to reflect the new workspace.
  11. Verify that the policy ID of all the child reports hierarchy of the report has been updated to reflect the new workspace.
  12. Verify that a new report action of type CHANGEPOLICY is added, indicating the workspace change.
  13. Ensure the report action message correctly reflects the old and new workspace names.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-03-12.at.10.28.55.PM.mov
Android: mWeb Chrome
Screen.Recording.2025-03-12.at.10.09.05.PM.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-12.at.22.16.05.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-04.at.20.36.47.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-03-04.at.8.02.29.PM.mov
MacOS: Desktop
Screen.Recording.2025-03-12.at.10.11.24.PM.mov

@rayane-d rayane-d force-pushed the Implement-ChangeReportPolicy branch 2 times, most recently from d0ab9ca to 61f4961 Compare February 27, 2025 23:16
@rayane-d
Copy link
Contributor Author

I had to force-push to sign my commits

@rayane-d rayane-d changed the title Feature: Implement ChangeReportPolicy [WIP] Feature: Implement ChangeReportPolicy Feb 27, 2025
@rayane-d rayane-d changed the title [WIP] Feature: Implement ChangeReportPolicy Feature: Implement ChangeReportPolicy Mar 1, 2025
@rayane-d
Copy link
Contributor Author

rayane-d commented Mar 1, 2025

Here is how the modal is looking like:

Screenshot 2025-03-01 at 1 05 12 AM

@rayane-d
Copy link
Contributor Author

rayane-d commented Mar 3, 2025

Requested translation confirmation in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1741005706637539

@rayane-d
Copy link
Contributor Author

rayane-d commented Mar 3, 2025

@luacmartins Are there existing manual testing steps for this feature / design doc?

@luacmartins
Copy link
Contributor

@Expensify/design for eyes on this new modal #57553 (comment)

@dannymcclain
Copy link
Contributor

Looking good! I wonder if we should bold approval workflow instead of just workflow in the second bullet? I don't feel too strongly, and this is looking pretty great to me as is.

@Expensify/design Do we typically use 32px of padding on these modals for desktop and then stick to 20px on mobile? Or is it supposed to be 20px everywhere?

@rayane-d
Copy link
Contributor Author

Updated @eVoloshchak this is ready for review again

Copy link
Contributor

@eVoloshchak eVoloshchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot melvin-bot bot requested a review from luacmartins March 13, 2025 17:17
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luacmartins luacmartins merged commit 34b65ec into Expensify:main Mar 13, 2025
18 of 20 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@rayane-d rayane-d deleted the Implement-ChangeReportPolicy branch March 13, 2025 17:32
@kavimuru
Copy link

@rayane-d Can you help with the following step for native apps?

For native platforms use npx uri-scheme open

Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.13-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@rayane-d
Copy link
Contributor Author

@rayane-d Can you help with the following step for native apps?

For native platforms use npx uri-scheme open

This is a dev command.

For native platforms, you can:

  1. click on the report header
  2. Click "Share"
  3. Click "Copy url"
  4. Paste the url in chat
  5. Add /change-workspace
  6. Send the url in chat
  7. Click on it

@rayane-d
Copy link
Contributor Author

@kavimuru I updated the tests

Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.13-5 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants