-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] Workspace - Green dot is shown on an empty Workspace chat #58431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @robertjchen ( |
Triggered auto assignment to @OfstadC ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Job added to Upwork: https://www.upwork.com/jobs/~021900391111352951265 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu ( |
🚨 Edited by proposal-police: This proposal was edited at 2025-03-21 10:09:56 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.When an expense report is moved from one workspace to another, the green dot remains on (in the LHN) for the workspace chat that is now empty. What is the root cause of that problem?The code in changeReportPolicy() in Report.ts is not doing anything to update the hasOutstandingChildRequest key in the optimistic updates it's making, so the green dot remains on. What changes do you think we should make in order to solve the problem?Front End:
And, in the same function, add this to the updates of the destination workspace:
Back End: What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?There do not appear to be any tests at all for changeReportPolicy, perhaps some should be added? What alternative solutions did you explore? (Optional)n/a |
Not overdue. It was the weekend. I'll review proposals today. |
Not overdue. In discussion. |
@robertjchen Friendly bump on this comment. |
@QichenZhu Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue. @robertjchen, what's our next step? Should we wait for the backend fix, or assign @davidgelhar to fix the frontend first? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Will revisit this week! |
Okay, thanks! |
@robertjchen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@robertjchen Huh... This is 4 days overdue. Who can take care of this? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
updating to reflect proper priority |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Now both new and old workspaces have GBRs. Tested on latest main. Screen.Recording.2025-04-21.at.22.36.16.mov |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Issue not reproducible during KI retests. (Second week) |
thanks, going to close out for now given existing priorities and inconsistent reproduction. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57553
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Chat Report View
Action Performed:
Expected Result:
Green dot on the LHN is not shown for workspace with no reports
Actual Result:
Green dot on the LHN is shown for workspace with no reports. Green dot is dismissed after going to the WS chat
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6770248_1741921382180.Screen_Recording_2025-03-14_at_5.49.47_at_night.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @robertjchenThe text was updated successfully, but these errors were encountered: