[$250] Workspace - Green dot is shown on an empty Workspace chat

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57553
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Chat Report View

Action Performed:

1. Goto https://staging.new.expensify.com/
2. Create two Workspaces and add an expense on one of them.
3. Go to the report (created expense) and Append /change-workspace to the URL of the report.
4. From the workspace selection list, choose a different workspace.
5. Dismiss the Educational Modal
6. On the LHN notice that Green dot is shown on the Workspace chats with no reports

Expected Result:

Green dot on the LHN is not shown for workspace with no reports

Actual Result:

Green dot on the LHN is shown for workspace with no reports. Green dot is dismissed after going to the WS chat

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6770248_1741921382180.Screen_Recording_2025-03-14_at_5.49.47_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021900391111352951265
• Upwork Job ID: 1900391111352951265
• Last Price Increase: 2025-04-25

Issue Owner

Current Issue Owner: @robertjchen

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021900391111352951265

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

[davidgelhar]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-21 10:09:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an expense report is moved from one workspace to another, the green dot remains on (in the LHN) for the workspace chat that is now empty.

What is the root cause of that problem?

The code in changeReportPolicy() in Report.ts is not doing anything to update the hasOutstandingChildRequest key in the optimistic updates it's making, so the green dot remains on.

What changes do you think we should make in order to solve the problem?

Front End:
In the changeReportPolicy function, use getReasonAndReportActionThatRequiresAttention to determine if the green dot is on because of the report that's being moved. If so, add to the optimistic updates:

            optimisticData.push({
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT}${reportToMove.chatReportID}`,
                value: {hasOutstandingChildRequest: false},
            });

And, in the same function, add this to the updates of the destination workspace:

        optimisticData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${policyExpenseChat.reportID}`,
            value: {hasOutstandingChildRequest: true},
        });

Back End:
It will also necessary to update the logic behind the ChangeReportPolicy API call to recompute hasOutstandingChildRequest on both the source and destination workspaces after the report is moved.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

There do not appear to be any tests at all for changeReportPolicy, perhaps some should be added?

What alternative solutions did you explore? (Optional)

n/a
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[QichenZhu]

Not overdue. It was the weekend. I'll review proposals today.

[QichenZhu]

Not overdue. In discussion.

[QichenZhu]

@robertjchen Friendly bump on this comment.

[melvin-bot]

@QichenZhu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[QichenZhu]

Not overdue. @robertjchen, what's our next step? Should we wait for the backend fix, or assign @davidgelhar to fix the frontend first?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[robertjchen]

Will revisit this week!

[QichenZhu]

Okay, thanks!

[melvin-bot]

@robertjchen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@robertjchen Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[robertjchen]

updating to reflect proper priority

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[QichenZhu]

Now both new and old workspaces have GBRs. Tested on latest main.

Screen.Recording.2025-04-21.at.22.36.16.mov

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[robertjchen]

thanks, going to close out for now given existing priorities and inconsistent reproduction.