-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-03-28] [Change Policy] Track expense - Expense is not moved to workspace when navigate to /change-workspace #58433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @johncschuster ( |
Triggered auto assignment to @mollfpr ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
This is expected. The "Change workspace" page is related only to the workspace expense reports. cc @luacmartins |
I agree. We can display a 'not found' page in these cases. These scenarios were not addressed in the design doc, but we should definitely address them. I can work on a PR to fix these uncovered cases. |
I'll assign the issues related to this change workspace feature to you, so it will be easier for you to track them! |
Assigning Carlos as we are managing the project. Adding it to migrate project too |
@luacmartins you can move an unreported tracked expense to a workspace in this way, right? So I agree, NotFoundPage for this invalid URL. Maybe can consolidate issues with: #58432 (comment) |
I think this is invalid. For unreported expense, we'd use the "Report transaction" flow and not the change workspace. You can only change policies on reports, not transactions. |
I'm gonna close this issue since this action is invalid. |
Sorry, I meant can't here!! Yeah, I think this should have a NotFoundPage as an invalid link. |
Fixed in a10d963 by displaying a 'Not Found' page for cases where reports are not of the type 'Expense' |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.16-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-03-28. 🎊 For reference, here are some details about the assignees on this issue:
|
@eVoloshchak / @rayane-d @johncschuster @eVoloshchak / @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #57553
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
Expected Result:
The transaction will be moved to the selected workspace
Actual Result:
The transaction is not moved to the selected workspace.
The same issue also happens with p2p expense and invoice.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6770276_1741923680214.20250314_113744.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @johncschusterThe text was updated successfully, but these errors were encountered: