Skip to content

[Due for payment 2025-03-28] [Change Policy] Track expense - Expense is not moved to workspace when navigate to /change-workspace #58433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
jponikarchuk opened this issue Mar 14, 2025 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@jponikarchuk
Copy link

jponikarchuk commented Mar 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #57553
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has self DM and at least one workspace.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track a manual expense.
  4. Go to transaction thread.
  5. Add /change-workspace to the end of the URL and navigate to it.
  6. Select a workspace.

Expected Result:

The transaction will be moved to the selected workspace

Actual Result:

The transaction is not moved to the selected workspace.
The same issue also happens with p2p expense and invoice.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6770276_1741923680214.20250314_113744.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @johncschuster
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering and removed Daily KSv2 labels Mar 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rayane-d
Copy link
Contributor

rayane-d commented Mar 14, 2025

This is expected. The "Change workspace" page is related only to the workspace expense reports. cc @luacmartins

@mollfpr mollfpr added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 14, 2025
@mollfpr
Copy link
Contributor

mollfpr commented Mar 14, 2025

I think this is still an issue. We shouldn't show the policy list if it's not report type expense.

Image

@rayane-d
Copy link
Contributor

I agree. We can display a 'not found' page in these cases. These scenarios were not addressed in the design doc, but we should definitely address them. I can work on a PR to fix these uncovered cases.

@mollfpr
Copy link
Contributor

mollfpr commented Mar 14, 2025

I'll assign the issues related to this change workspace feature to you, so it will be easier for you to track them!

@mountiny
Copy link
Contributor

Assigning Carlos as we are managing the project. Adding it to migrate project too

@mountiny mountiny moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Mar 14, 2025
@mountiny mountiny changed the title Track expense - Expense is not moved to workspace when navigate to /change-workspace [Change Policy] Track expense - Expense is not moved to workspace when navigate to /change-workspace Mar 14, 2025
@trjExpensify
Copy link
Contributor

@luacmartins you can move an unreported tracked expense to a workspace in this way, right? So I agree, NotFoundPage for this invalid URL. Maybe can consolidate issues with: #58432 (comment)

@luacmartins
Copy link
Contributor

I think this is invalid. For unreported expense, we'd use the "Report transaction" flow and not the change workspace. You can only change policies on reports, not transactions.

@luacmartins
Copy link
Contributor

I'm gonna close this issue since this action is invalid.

@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Mar 14, 2025
@trjExpensify
Copy link
Contributor

@luacmartins you can move an unreported tracked expense to a workspace in this way, right?

Sorry, I meant can't here!! Yeah, I think this should have a NotFoundPage as an invalid link.

@rayane-d
Copy link
Contributor

Fixed in a10d963 by displaying a 'Not Found' page for cases where reports are not of the type 'Expense'

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Mar 18, 2025
@melvin-bot melvin-bot bot changed the title [Change Policy] Track expense - Expense is not moved to workspace when navigate to /change-workspace [Due for payment 2025-03-28] [Change Policy] Track expense - Expense is not moved to workspace when navigate to /change-workspace Mar 21, 2025
Copy link

melvin-bot bot commented Mar 21, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 21, 2025
Copy link

melvin-bot bot commented Mar 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.16-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-28. 🎊

For reference, here are some details about the assignees on this issue:

  • @eVoloshchak requires payment through NewDot Manual Requests
  • @rayane-d requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Mar 21, 2025

@eVoloshchak / @rayane-d @johncschuster @eVoloshchak / @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
Development

No branches or pull requests

8 participants