Skip to content

[Due for payment 2025-03-28] [Change Policy] Report - Report workspace changed be changed to a deleted workspace in offline mode #58428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
mitarachim opened this issue Mar 14, 2025 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Mar 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

  • Account has two workspaces.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat of the first workspace.
  3. Submit an expense.
  4. Go offline.
  5. Delete the second workspace.
  6. Go to the expense report from Step 3.
  7. Send this to chat - https://staging.new.expensify.com/r/reportid/change-workspace
  8. Select the deleted workspace.
  9. Go online.

Expected Result:

In Step 8, the deleted workspace should be removed or crossed out.

Actual Result:

In Step 8, the deleted workspace is not removed or crossed out.
After moving the report to the deleted workspace and returning online, the report cannot be moved.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6770237_1741919944066.20250314_103537.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mollfpr
Copy link
Contributor

mollfpr commented Mar 14, 2025

Not a blocker. I think this is an edge case and it's from a new feature. #57553

cc @rayane-d @eVoloshchak

@mollfpr mollfpr added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Mar 14, 2025
@mountiny mountiny assigned luacmartins and unassigned mollfpr Mar 14, 2025
@mountiny
Copy link
Contributor

Thanks! Going to assign Carlos as he is managing this project

@mountiny mountiny moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Mar 14, 2025
@mountiny mountiny changed the title Report - Report workspace changed be changed to a deleted workspace in offline mode [Change Policy] Report - Report workspace changed be changed to a deleted workspace in offline mode Mar 14, 2025
@trjExpensify
Copy link
Contributor

In Step 8, the deleted workspace should be removed or crossed out.

This is ambiguous. It's one or the other. Let's be guided by what we do elsewhere. In the Create expense case, we don't show the pending deleted workspace anymore -- so I think we do the same here.

2025-03-14_14-56-01.mp4

@rayane-d
Copy link
Contributor

Fixed in 115d69e by hiding pending deletion workspaces from the list

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Mar 18, 2025
@melvin-bot melvin-bot bot changed the title [Change Policy] Report - Report workspace changed be changed to a deleted workspace in offline mode [Due for payment 2025-03-28] [Change Policy] Report - Report workspace changed be changed to a deleted workspace in offline mode Mar 21, 2025
Copy link

melvin-bot bot commented Mar 21, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 21, 2025
Copy link

melvin-bot bot commented Mar 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.16-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-28. 🎊

For reference, here are some details about the assignees on this issue:

  • @eVoloshchak requires payment through NewDot Manual Requests
  • @rayane-d requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Mar 21, 2025

@eVoloshchak / @rayane-d @mallenexpensify @eVoloshchak / @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 28, 2025
Copy link

melvin-bot bot commented Mar 28, 2025

Payment Summary

Upwork Job

BugZero Checklist (@mallenexpensify)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@luacmartins
Copy link
Contributor

Closing this since payment will be handled in the main issue #57464

@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Development

No branches or pull requests

8 participants