hide pending deleted workspace from change workspace list

Author: rayane-d

src/hooks/useWorkspaceList.ts

@@ -19,7 +19,7 @@ type WorkspaceListItem = {
 type UseWorkspaceListParams = {
     policies: OnyxCollection<Policy>;
     currentUserLogin: string | undefined;
-    isOffline: boolean;
+    shouldShowPendingDeletePolicy: boolean;
     selectedPolicyID: string | undefined;
     searchTerm: string;
     additionalFilter?: (policy: OnyxEntry<Policy>) => boolean;
@@ -41,7 +41,7 @@ function useWorkspaceList({
     currentUserLogin,
     selectedPolicyID,
     searchTerm,
-    isOffline,
+    shouldShowPendingDeletePolicy,
     isWorkspaceSwitcher = false,
     hasUnreadData,
     getIndicatorTypeForPolicy,
@@ -53,7 +53,7 @@ function useWorkspaceList({
         }
 
         return Object.values(policies)
-            .filter((policy) => !!policy && shouldShowPolicy(policy, !!isOffline, currentUserLogin) && !policy?.isJoinRequestPending && (additionalFilter ? additionalFilter(policy) : true))
+            .filter((policy) => !!policy && shouldShowPolicy(policy, shouldShowPendingDeletePolicy, currentUserLogin) && !policy?.isJoinRequestPending && (additionalFilter ? additionalFilter(policy) : true))
             .map((policy) => ({
                 text: policy?.name ?? '',
                 policyID: policy?.id,
@@ -76,7 +76,7 @@ function useWorkspaceList({
                         brickRoadIndicator: getIndicatorTypeForPolicy(policy?.id),
                     }),
             }));
-    }, [policies, isOffline, currentUserLogin, additionalFilter, selectedPolicyID, getIndicatorTypeForPolicy, hasUnreadData, isWorkspaceSwitcher]);
+    }, [policies, shouldShowPendingDeletePolicy, currentUserLogin, additionalFilter, selectedPolicyID, getIndicatorTypeForPolicy, hasUnreadData, isWorkspaceSwitcher]);
 
     const filteredAndSortedUserWorkspaces = useMemo<WorkspaceListItem[]>(
         () =>

src/pages/ReportChangeWorkspacePage.tsx

@@ -51,7 +51,7 @@ function ReportChangeWorkspacePage({report}: ReportChangeWorkspacePageProps) {
     const {sections, shouldShowNoResultsFoundMessage, shouldShowSearchInput} = useWorkspaceList({
         policies,
         currentUserLogin,
-        isOffline,
+        shouldShowPendingDeletePolicy: false,
         selectedPolicyID: report.policyID,
         searchTerm: debouncedSearchTerm,
         additionalFilter: (newPolicy) => isWorkspaceEligibleForReportChange(newPolicy, report, oldPolicy, currentUserLogin),

src/pages/WorkspaceSwitcherPage/index.tsx

@@ -70,7 +70,7 @@ function WorkspaceSwitcherPage() {
 
     const {sections, shouldShowNoResultsFoundMessage, shouldShowSearchInput, shouldShowCreateWorkspace} = useWorkspaceList({
         policies,
-        isOffline,
+        shouldShowPendingDeletePolicy: !!isOffline,
         currentUserLogin,
         selectedPolicyID: activeWorkspaceID,
         searchTerm: debouncedSearchTerm,