Add Merge Account to NewExpensify

[zanyrenney]

DESIGN DOC ➡️

Proposal

Tasks

• Post Proposal (full Problem/Solution statement) in #whatsnext
• Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
• Paste Proposal in the space above with a link to the Slack thread
• Email [email protected] and paste in the Proposal
• Host a pre-design meeting (example) in an appropriate slack channel to discuss any necessary details in public before filling out the High-level of proposed solution section.
• Fill out the High-level overview of the problem, Timeline, Terminology, and High-level of proposed solution sections of the Design Doc
• Email [email protected] (continue the same email chain as before - your last message should be the WN Proposal) with the link to your Design Doc containing your high-level problem and solution
• Add the DesignDocReview label to get the High-level overview of the problem and High-level of proposed solution section reviewed
• Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
• Confirm that the doc has the minimum necessary number of reviews before proceeding
• Host another pre-design meeting in the appropriate slack channel to ask for engineering feedback on the technical solution.
• Fill out the Detailed implementation of the solution and related sections.
• Re-add the DesignDocReview label to this issue
• Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
• Confirm that the doc has the minimum necessary number of reviews before proceeding
• Email [email protected] one last time to let them know the Design Doc is moving into the implementation phase
• Implement the changes
• Add regression tests so that QA can test your feature with every deploy (instructions)
• Send out a follow up email to [email protected] once everything has been implemented and do a Project Wrap-Up retrospective that provides:
  • Summary of what we accomplished with this project
  • What went well?
  • What could we have done better?
  • What did we learn?

Issue Owner

Current Issue Owner: @arosiclair

[melvin-bot]

Current assignees @twisterdotcom and @zanyrenney are eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[zanyrenney]

Edited by proposal-police: This proposal was edited at 2024-08-19 15:59:41 UTC.

Need to improve this but startign with the P/S

Proposal: add the remaining account settings to new dot, Part 1: Merge Account (Part 2: Device Management TBC)

Problem:

When users accidentally create personal accounts while their company is using Expensify, they face several issues. They must either:

• Re-scan their receipts using their company account.
• Manually create expenses within their company account.
• Accept that they won’t be reimbursed by their employer.

Generally, users can’t share reports directly with their company in-app, and managing two accounts can be confusing. Users might also unknowingly create expenses that don't align with company policies.

Solution:

Rebuild the ability to "Merge Accounts" in NewExpensify. This feature allows users to easily merge their personal and company accounts on Expensify.

This will improve the transfer from individual expense data to company-created accounts, giving visibility to admins and mitigating the need to create a novel account for those originally creating individual accounts.

[zanyrenney]

Pre-design on merging accounts for workspace feed/card conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1723841346915409

[zanyrenney]

Proposal: Add the remaining account settings to NewExpensify.

Part 1: Merge Account
Part 2: Consider implications for this on Device Management (TBC)

Problem:

When users accidentally create personal accounts while their company is using Expensify, they face several issues. They must either:

• Re-scan their receipts using their company account.
• Manually create expenses within their company account.
• Accept that they won’t be reimbursed by their employer.

Generally, users can’t share reports directly with their company in-app, and managing two accounts can be confusing. Users might also unknowingly create expenses that don't align with company policies.

Solution:

Rebuild the ability to "Merge Accounts" in NewExpensify. This feature allows users to easily merge their personal and company accounts on Expensify.

This will improve the transfer from individual expense data to company-created accounts, giving visibility to admins and mitigating the need to create a novel account for those originally creating individual accounts, and crucially, give them the ability to do take this action without requiring access to Expensify Classic.

[github-actions]

@zanyrenney Your proposal will be dismissed because you did not follow the proposal template.

[zanyrenney]

This is a bit mean, I haven't even done it yet 🥲

[zanyrenney]

https://github.com/search?q=org:Expensify+%22merge+account%22&type=Code

[zanyrenney]

https://github.com/search?q=org:Expensify+%22merge+account%22&type=Code
https://github.com/Expensify/Web-Expensify/blob/main/script/bwm/HandleBackgroundTasksOnMergeAccount.php
https://github.com/Expensify/Auth/blob/main/auth/command/MergeAccount.cpp

[zanyrenney]

Not sure we need @dannymcclain here yet so will remove this from clogging up his K2.

[zanyrenney]

[zanyrenney]

@twisterdotcom and I considered getting the pre-design out today or tomorrow but I realised we need to email strat@ prior, so done that and then can get the pre-design in flight!

[twisterdotcom]

Back from some OOO. @zanyrenney has been predesigning in a canvas in my absence.

[zanyrenney]

pre-design is posted! https://expensify.slack.com/archives/C06ML6X0W9L/p1725276863731789

[parasharrajat]

@zanyrenney Sure.

[arosiclair]

We're working through a few PRs to cleanup the bugs we found in QA:

• Merge account feature fixes - Part 1 #59911
• Merge account feature fixes - Part 2 #59955
• [HOLD] Fix full reconnect onyx updates being ignored after merging accounts #60147

These all still need review and testing so they probably won't get merged until next week.

[allroundexperts]

Status:

1. [$250] Merge account - Long email is cut off on magic code page #59757 🟢 (Merge account feature fixes - Part 1 #59911)
2. [$250] Merge Account - Background changes to inbox when reloading on merge page #59759 🟢 (Merge account feature fixes - Part 1 #59911)
3. Merge account - "Learn more about merging accounts" link opens not here page #59760 🟢 (Merge account feature fixes - Part 1 #59911)
4. Merge account - Error message contains 404 when merging with the same account #59761 🟢 (Merge account feature fixes - Part 1 #59911)
5. Android - Merge account - No spacing between the paragraph and magic code field #59763 🟢 (Merge account feature fixes - Part 2 #59955)
6. [$250] mweb - Merge account - Merge account button overlaps with magic code field #59765 🟢 (Merge account feature fixes - Part 2 #59955)
7. Merge account-Magic code page reopens when returning to previous page after requesting code #59767 🟢 (Merge account feature fixes - Part 1 #59911)
8. Merge account - Error message contains 401 when entering incorrect magic code #59772 🟢 (Merge account feature fixes - Part 1 #59911)
9. [$250] LHN - When merging accounts, more chats appear after killing the app and relaunching. #59779 🟡 ([HOLD] Fix full reconnect onyx updates being ignored after merging accounts #60147)
10. Merge Accounts - Keyboard does not open automatically on Magic Code page. #59783 🟢 (chore: remove shouldDelayFocus prop from text input #59087)
11. Merge account - Error messages in code section are not translated to Spanish #59784 🟢 (Merge account feature fixes - Part 1 #59911)
12. [$250] Android - App returns to Merge accounts flow when using back button after merging account #59764 🟡 ([Merge Account] Remove the initial route from state after successful merge #60751)
13. Merge account - Error message for non-existing account contains 404 #59824 🟢 (Merge account feature fixes - Part 1 #59911)
14. [$250] Hybrid Android&iOS - Merge account - Paragraphs in "We’re working on it" page have different style on iOS and mweb #59834 🟢 (Merge account feature fixes - Part 2 #59955)

🟡 -> In progress
🟢 -> Done
🔵 -> Not touched yet
🔴 -> Very trivial. Thinking of ways to solve it.

[zanyrenney]

Amazing effort @allroundexperts - thank you so much! For the LHN issue, i see that one is in progress, what kind of ETA are you thinking?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.31-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Merge account feature fixes - Part 2 #59955

If no regressions arise, payment will be issued on 2025-04-30. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[allroundexperts]

Amazing effort @allroundexperts - thank you so much! For the LHN issue, i see that one is in progress, what kind of ETA are you thinking?

The LHN issue is being handled by @arosiclair since it involved backend changes. We're waiting for @parasharrajat's review there.

I raised the PR for #59764 and updated the status board!

[parasharrajat]

I will get this reviewed in 5-6 hours. Currently travelling.

[zanyrenney]

How did they reviews go @parasharrajat ?

[parasharrajat]

Facing build issues but it should be completed today.

[arosiclair]

Two issues left still:

• [$250] Android - App returns to Merge accounts flow when using back button after merging account #59764 - we're fixing some issues in the PR. Waiting on updates from @allroundexperts
• [$250] LHN - When merging accounts, more chats appear after killing the app and relaunching. #59779 - I identified the likely root cause and need to draft a PR and test it

[parasharrajat]

One backend change is pending.

[arosiclair]

#59764 is complete.

I'm working on #59779. ETA is next week.