Merge account - Error message for non-existing account contains 404

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: User Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings > Security.
3. Click Merge account.
4. Enter this email - [email protected]
5. Mark "I understand this is not reversible" checkbox.
6. Click Next.
7. Enter any 6 digits.

Expected Result:

The error message for non-existing account will not contain 404.

Actual Result:

The error message for non-existing account contains 404 - 404 Account doesn't exist

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6796064_1744120047938.20250408_214405.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dangrous]

Probably similar to #59761

[dangrous]

cc @arosiclair and @allroundexperts on this one

[Eskalifer1]

Hi everyone! Im not sure about it, but in dev and stage it works different. In dev we get 404 on this request: /api/GetValidateCodeForAccountMerge ,.
And in this page App/src/pages/settings/Security/MergeAccounts/AccountDetailsPage.tsx we handle different error codes.
Tested on main branch

But in staging branch we get 200, thst why we continue But we get a code 200 on the stamp, so the next step is the following

In theory, we shouldn't be able to access this page if the account doesn't exist, it could be a backend error

Maybe also related to #59784

[luacmartins]

Even though this is coming from the API, I don't think this is a Web-E blocker since it seems like we just need better error handling App. I'll remove the blocker label for the API. Please add it back if you think otherwise.

[arosiclair]

This is similar to #59761 (comment) where we're not showing the error early enough. I'll take care of both of these.

[arosiclair]

The usual non-existing account functionality seems to be working:

Attempting to merge with [email protected] behaves weirdly though. There's a discrepancy with how we validate the email in GetValidateCodeForAccountMerge and MergeWithValidateCode which I'll fix.