[$250] LHN - When merging accounts, more chats appear after killing the app and relaunching.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #56911
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Prerequisite: merged account must contain chats appart from workspace ones. (Individual, group or rooms)

1. Open the Expensify app.
2. Tap on "Settings" and select "Security"
3. Tap on "Merge Accounts"
4. Complete the merging process.
5. Return to LHN.
6. Note that only workspace chats of the second account are displayed.
7. Kill and relaunch the app.
8. Note that now. the rest of the chats of the second account appeared.

Expected Result:

All the chats of the second account should appear automatically after finishing the merging process.

Actual Result:

When merging accounts, only workspace chats of the second one are automatically displayed. On Android, after killing and relaunching the app, all the individual, group or room chats appear on LHN.
For Web and mWeb, to reproduce this, the user has to change to "Focus" mode and return to "Most Recent".
Also, tasks of Concierge chat, appear on LHN as separated chats after accounts are merged.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909686235324826670
• Upwork Job ID: 1909686235324826670
• Last Price Increase: 2025-04-08

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @arosiclair

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MariaHCD]

This looks like it does not need to block the deploy because it is a new feature - it can be a follow up improvement from #56911

@allroundexperts @parasharrajat @arosiclair - will all improvements be tracked in the main issue #54443?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909686235324826670

[melvin-bot]

Current assignees @parasharrajat and @allroundexperts are eligible for the External assigner, not assigning anyone new.

[parasharrajat]

Yup, it will be follow-up

[arosiclair]

PR is out for review

[parasharrajat]

Will review once Frontend PRs are done.

[arosiclair]

Something new is broken now. After merging accounts, the call to ReconnectApp does not return data for the chats from the old account anymore. I'm not sure what the root problem is yet.

[melvin-bot]

@arosiclair Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[parasharrajat]

PR under review. We encountered a bug.

[arosiclair]

Looked into this a bit more today. Something changed about OpenApp in the last few weeks that's causing this new issue. After merging accounts, chats that should appear no longer appear at all even after logging out and back in.

I'm pretty sure this is because reports with hidden preference are filtered out here and the new account has no preference for the chat (it was not merged).

[arosiclair]

I'm pretty sure this is because reports with hidden preference are filtered out here and the new account has no preference for the chat (it was not merged).

Confirmed this was the root problem and drafted an Auth PR to fix it. Need to time a query and get that merged first.

[arosiclair]

Nevermind, this is going to take more time. Migrating notification preferences is a long running query that we can't just do in the MergeWithValidateCode request. Instead, we'll have to move that part to a job and push the updates asynchronously. Discussed that here.

I'll start working on that, but probably won't be able to finish until next week.

[melvin-bot]

@arosiclair Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@arosiclair Huh... This is 4 days overdue. Who can take care of this?

[arosiclair]

I'm working on the implementation now. I need to

1. Update MergeAccount in Auth to return the reportIDs that need their preferences merged
2. Update the HandleBackgroundTasksOnMergeAccount job to paginate and process these
3. Add a new Auth command to merge notification preferences for the given accounts and reportIDs

An optimistic ETA is EOW

[arosiclair]

I'm through most of the implementation and tested it a little bit. It works, but I was struggling with writing Auth tests. I'm deployer this week, but I'll try to fit in more progress.

[melvin-bot]

@arosiclair Whoops! This issue is 2 days overdue. Let's get this updated quick!