chore: remove shouldDelayFocus prop from text input #59087

wgsquayson · 2025-03-25T18:54:31Z

Explanation of Change

This PR removes the prop shouldDelayFocus from the base and native input components, since the delay behavior implemented to avoid bugs on mobile devices (as @hannojg described in #54759) isn't necessary anymore, and the bugs aren't reproducible.
It also removes implementations of this logic in other parts of the app, since those parts point to the same components.
The issue linked above also points to two other issues where iOS Safari is failing to autoFocus on some text inputs. These issues are under investigation and the problem is not targeted on this PR.

Fixed Issues

$ #54759
PROPOSAL: #54759 (comment)

Tests

Verify that no errors appear in the JS console

Navigate somewhere the input should be auto focused (for example: The sign in OTP screen, the search button on the header when signed in, editing profile details such as status, phone number, pronouns, etc.)
Notice on those screens, modals, etc. that the first (or only) input is focused when you navigate to them and your keyboard opens automatically (as cited before, iOS Safari and iOS Chrome will not focus properly everywhere)

QA Steps

Verify that no errors appear in the JS console

Navigate somewhere the input should be auto focused (for example: The sign in OTP screen, the search button on the header when signed in, editing profile details such as status, phone number, pronouns, etc.)
Notice on those screens, modals, etc. that the first (or only) input is focused when you navigate to them and your keyboard opens automatically (as cited before, iOS Safari and iOS Chrome will not focus properly everywhere)

PR Author Checklist

Screenshots/Videos

Android: Native

android.compressed.mov

Android: mWeb Chrome

chrome.android.compressed.mov

iOS: Native

ios.480p.mov

iOS: mWeb Safari

safari.ios.compressed.mov

MacOS: Chrome / Safari

safari.mac.compressed.mov

MacOS: Desktop

desktop.compressed.mov

melvin-bot · 2025-03-25T18:54:36Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

github-actions · 2025-03-25T18:54:47Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

wgsquayson · 2025-03-25T19:11:27Z

I have read the CLA Document and I hereby sign the CLA

melvin-bot · 2025-03-29T14:13:22Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chrispader

LGTM!

mountiny · 2025-03-30T21:44:42Z

@allroundexperts What is your eta for the review? thanks!

mountiny · 2025-03-30T21:47:45Z

src/components/TextInput/BaseTextInput/index.native.tsx

@@ -46,7 +46,6 @@ function BaseTextInput(
        containerStyles,
        inputStyle,
        forceActiveLabel = false,
-        autoFocus = false,


why is this prop removed for native?

It's still there, just not destructured anymore. Goes into the rest of the inputProps.

github-actions · 2025-03-30T21:48:24Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny · 2025-03-30T21:49:15Z

@wgsquayson Congrats for your first PR! Please check the failing TS and ESLint checks.

Also, for future PRs, numbered testing/QA steps are preferred as they have better readability. I have fixed it for you. Although it might be even better to break down the example case you have into numbered steps

github-actions · 2025-03-30T22:31:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59087-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59087-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59087/NewExpensify.dmg	https://59087.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

wgsquayson · 2025-03-31T12:41:06Z

@mountiny thank you! I will consider that on my next PR :)

wgsquayson · 2025-03-31T14:36:20Z

@mountiny TS/Lint errors fixed!

mountiny · 2025-03-31T18:06:55Z

@allroundexperts Are you able to get to this one?

allroundexperts · 2025-03-31T18:08:59Z

On it now!

allroundexperts · 2025-03-31T18:10:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-01.at.12.54.22.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-04-01.at.12.52.36.AM.mov

iOS: Native

Screen.Recording.2025-03-31.at.11.33.24.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-03-31.at.11.26.44.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-31.at.11.19.43.PM.mov

Screen.Recording.2025-03-31.at.11.20.31.PM.mov

MacOS: Desktop

Screen.Recording.2025-03-31.at.11.24.51.PM.mov

allroundexperts · 2025-03-31T18:31:11Z

I wasn't able to reproduce the following on staging:

Screen.Recording.2025-03-31.at.11.30.22.PM.mov

The cursor seems to be moving along the transition.

wgsquayson · 2025-03-31T19:26:37Z

@allroundexperts looking into it

wgsquayson · 2025-03-31T20:02:43Z

@allroundexperts i am not being able to reproduce the autoFocus behavior on mSafari on my physical device
will try on simulator

ScreenRecording_03-31-2025.16-56-20_1.MP4

allroundexperts · 2025-04-10T22:32:53Z

@wgsquayson Can you please resolve conflicts?

wgsquayson · 2025-04-11T13:35:46Z

@allroundexperts done!

chrispader · 2025-04-17T08:51:10Z

@mountiny can this be merged? 🙌🏼

mountiny

Thanks! Lets be on a look out for regressions after the deploy @chrispader @allroundexperts @wgsquayson

OSBotify · 2025-04-17T19:36:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-18T20:41:39Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-21T23:20:19Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.30-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

CLABotify added a commit to Expensify/CLA that referenced this pull request Mar 25, 2025

@wgsquayson has signed the CLA in Expensify/App#59087

848fafc

wgsquayson force-pushed the chore/remove-should-delay-focus-prop-from-native-input branch from 95a12f1 to 00142ba Compare March 25, 2025 19:40

wgsquayson changed the title ~~chore: remove shouldDelayFocus prop from native input~~ chore: remove shouldDelayFocus prop from text input Mar 26, 2025

wgsquayson force-pushed the chore/remove-should-delay-focus-prop-from-native-input branch from 0859cff to 71b0797 Compare March 28, 2025 12:44

wgsquayson marked this pull request as ready for review March 29, 2025 14:13

wgsquayson requested a review from a team as a code owner March 29, 2025 14:13

melvin-bot bot requested review from allroundexperts and removed request for a team March 29, 2025 14:13

wgsquayson mentioned this pull request Mar 29, 2025

[Due for payment 2025-04-28] Follow up: remove shouldDelayFocus prop #54759

Closed

chrispader approved these changes Mar 29, 2025

View reviewed changes

mountiny assigned wgsquayson Mar 30, 2025

mountiny self-requested a review March 30, 2025 21:44

mountiny reviewed Mar 30, 2025

View reviewed changes

wgsquayson requested a review from mountiny March 31, 2025 14:35

wgsquayson force-pushed the chore/remove-should-delay-focus-prop-from-native-input branch from 05d64ad to 8bb1cd5 Compare April 11, 2025 13:31

wgsquayson added 13 commits April 15, 2025 13:34

chore: remove shouldDelayFocus prop from native input

434f060

chore: use autoFocus from input props instead of destructuring

e488a96

chore: remove should delay focus from several components

8dc83b4

chore: remove input focus delay from selection list

1cd71a8

chore: remove unused shouldDelayFocus from libs

6e9ad3c

chore: return focusTextInput handler code

3327824

fix: namespace issues

a030288

fix: session actions method name

a75ead9

fix: user actions namespace imports

18a6c30

chore: keep delay behavior on base selection list

ab06472

chore: return should delay focus to base selection list

f7a03eb

chore: apply changes to new text input implementation

1a6fe1b

chore: remove prop from wrong place

176309b

wgsquayson force-pushed the chore/remove-should-delay-focus-prop-from-native-input branch from 9063782 to 176309b Compare April 15, 2025 16:35

ikevin127 mentioned this pull request Apr 15, 2025

[$250] Hybrid - iOS - FAB - Room name field is auto unfocused when switching from Chat to #Room #59388

Open

8 tasks

fix: linting errors

db085ce

allroundexperts approved these changes Apr 16, 2025

View reviewed changes

mountiny approved these changes Apr 17, 2025

View reviewed changes

mountiny merged commit 10fbf03 into Expensify:main Apr 17, 2025
17 checks passed

github-actions bot mentioned this pull request Apr 18, 2025

Deploy Checklist: New Expensify 2025-04-18 #60506

Closed

64 tasks

jaydamani mentioned this pull request Apr 19, 2025

[Due for payment 2025-05-30] Room - "Please enter a room name" error message automatically seen when creating second room #60527

Open

8 tasks

mitarachim mentioned this pull request Apr 21, 2025

Display and Legal name fields are not autofocused when navigated to #60569

Closed

8 tasks

allroundexperts mentioned this pull request Apr 22, 2025

Add Merge Account to NewExpensify #47073

Open

19 tasks

chore: remove shouldDelayFocus prop from text input #59087

chore: remove shouldDelayFocus prop from text input #59087

Uh oh!

Conversation

wgsquayson commented Mar 25, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wgsquayson commented Mar 25, 2025

Uh oh!

melvin-bot bot commented Mar 29, 2025

Uh oh!

chrispader left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Mar 30, 2025

Uh oh!

mountiny Mar 30, 2025

Choose a reason for hiding this comment

Uh oh!

wgsquayson Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 30, 2025

Uh oh!

mountiny commented Mar 30, 2025

Uh oh!

github-actions bot commented Mar 30, 2025

Uh oh!

wgsquayson commented Mar 31, 2025

Uh oh!

wgsquayson commented Mar 31, 2025

Uh oh!

mountiny commented Mar 31, 2025

Uh oh!

allroundexperts commented Mar 31, 2025

Uh oh!

allroundexperts commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Mar 31, 2025

Uh oh!

wgsquayson commented Mar 31, 2025

Uh oh!

wgsquayson commented Mar 31, 2025

Uh oh!

allroundexperts commented Apr 10, 2025

Uh oh!

wgsquayson commented Apr 11, 2025

Uh oh!

chrispader commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 17, 2025

Uh oh!

github-actions bot commented Apr 18, 2025

Uh oh!

github-actions bot commented Apr 21, 2025

Uh oh!

Uh oh!

wgsquayson commented Mar 25, 2025 •

edited by mountiny

Loading

github-actions bot commented Mar 25, 2025 •

edited

Loading

allroundexperts commented Mar 31, 2025 •

edited

Loading

chrispader commented Apr 17, 2025 •

edited

Loading