Skip to content

[Due for payment 2025-05-30] Room - "Please enter a room name" error message automatically seen when creating second room #60527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 8 tasks
jponikarchuk opened this issue Apr 19, 2025 · 30 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@jponikarchuk
Copy link

jponikarchuk commented Apr 19, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Other

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Tap on the FAB and select "Star Chat"
  3. Select "Room"
  4. Add a name and complete the creation flow.
  5. Once redirected to new room, return to LHN.
  6. Tap on FAB again and select "Start Chat"
  7. Note that "Please enter a room name" error message is automatically displayed.

Expected Result:

"Please enter a room name" error message, should only be displayed if user leaves the "Name" field empty.

Actual Result:

"Please enter a room name" error message is automatically displayed when trying to create a second room. Error is displayed despite the user not unfocusing the "Name" field or not tapping on "Create Room" button without adding a name.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @strepanier03
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 19, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Apr 19, 2025

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 19, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link

melvin-bot bot commented Apr 19, 2025

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@jaydamani
Copy link
Contributor

Regression PR: #59087

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Apr 19, 2025
@mountiny
Copy link
Contributor

Seems minor issue so does not have to hold the deploy imho

@mountiny
Copy link
Contributor

@wgsquayson can you please have a look at this one as regression?

@allroundexperts
Copy link
Contributor

Have we confirmed if this is really caused by #59087?

@mollfpr
Copy link
Contributor

mollfpr commented Apr 21, 2025

I confirm that this regression from #59087

Image

Copy link

melvin-bot bot commented Apr 23, 2025

@wgsquayson Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Apr 23, 2025
@mollfpr
Copy link
Contributor

mollfpr commented Apr 28, 2025

@wgsquayson Any update to fix this issue? Thanks!

Copy link

melvin-bot bot commented Apr 29, 2025

@wgsquayson 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@strepanier03
Copy link
Contributor

@wgsquayson and @allroundexperts, friendly bump.

@allroundexperts
Copy link
Contributor

We are waiting for an update from @wgsquayson. Happy to help in any way to move this forward.

@mallenexpensify
Copy link
Contributor

Posted in #expert-contributors and tagged @wgsquayson for 👀
https://expensify.slack.com/archives/C08CZDJFJ77/p1746052862641189

@wgsquayson
Copy link
Contributor

wgsquayson commented May 1, 2025

Sorry guys - I asked @chrispader some days ago to assign this to another contributor (and forgot to take a look here, my bad), because i've been in a really tight schedule lately. Will check with him on what happened.

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2025
Copy link

melvin-bot bot commented May 3, 2025

@strepanier03 @mollfpr @allroundexperts @wgsquayson this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented May 5, 2025

@wgsquayson Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label May 5, 2025
Copy link

melvin-bot bot commented May 7, 2025

@wgsquayson Huh... This is 4 days overdue. Who can take care of this?

@chrispader
Copy link
Contributor

I'm still looking for someone to take it over soon, but everyone at Margelo is pretty busy with other Expensify tasks at the moment unfortunately.

If this needs to be handled more quickly, feel free to re-assign. I'll probably have someone by start of next week!

Copy link

melvin-bot bot commented May 9, 2025

@wgsquayson 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@mallenexpensify
Copy link
Contributor

Posted in #expert-contributors

Room - "Please enter a room name" error message automatically seen when creating second room
If anyone is able to help with the above, please comment on the issue. cc
@Chris

@chrispader
Copy link
Contributor

@boorad is going to work on this starting next week!

cc @mallenexpensify 🙌🏼

@mollfpr
Copy link
Contributor

mollfpr commented May 12, 2025

Thanks for the confirmation @chrispader! Assigning @boorad 👍

@mollfpr mollfpr assigned boorad and unassigned wgsquayson May 12, 2025
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 12, 2025
Copy link

melvin-bot bot commented May 15, 2025

@boorad, @strepanier03, @mollfpr, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented May 19, 2025

@boorad, @strepanier03, @mollfpr, @allroundexperts 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Overdue Weekly KSv2 labels May 19, 2025
@melvin-bot melvin-bot bot changed the title Room - "Please enter a room name" error message automatically seen when creating second room [Due for payment 2025-05-30] Room - "Please enter a room name" error message automatically seen when creating second room May 23, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 23, 2025
Copy link

melvin-bot bot commented May 23, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 23, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-30. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 23, 2025

@allroundexperts @strepanier03 @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
Status: LOW
Development

No branches or pull requests

10 participants