Skip to content

[$250] Hybrid Android&iOS - Merge account - Paragraphs in "We’re working on it" page have different style on iOS and mweb #59834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
IuliiaHerets opened this issue Apr 8, 2025 · 10 comments · Fixed by #59955
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Apr 8, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max . iOS 18.4
App Component: User Settings

Action Performed:

  1. Launch Expensify app.
  2. Go to Settings > Security.
  3. Tap Merge account.
  4. Enter a phone number (+18005555555ab).
  5. Mark "I understand this is not reversible" checkbox.
  6. Click Next.
  7. Compare the paragraphs in "We’re working on it" page on iOS app and mweb.

or

  1. Directly open https://staging.new.expensify.com/settings/security/merge-accounts/+18005555555ab/result/err_saml_not_supported link on mweb and iOS app.

Expected Result:

The paragraphs in "We’re working on it" page will have the same style on iOS app and mweb.

Actual Result:

The paragraphs in "We’re working on it" page have different style on iOS app and mweb.

On iOS, it shows:
We don’t yet support merging accounts on New Expensify. Please take this action on Expensify Classic instead.Feel free to reach out to Concierge if you have any questions!

On mweb, it shows:
We don’t yet support merging accounts on New Expensify. Please take this action on Expensify Classic instead.
Feel free to reach out to Concierge if you have any questions!

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image Image https://github.com/user-attachments/assets/a3631695-1097-4a88-ad06-1454651fa0f9

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021909687307888709244
  • Upwork Job ID: 1909687307888709244
  • Last Price Increase: 2025-04-08
Issue OwnerCurrent Issue Owner: @Pujan92
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 8, 2025
Copy link

melvin-bot bot commented Apr 8, 2025

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 8, 2025

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 8, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 8, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@arosiclair arosiclair added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 labels Apr 8, 2025
@slafortune slafortune added the External Added to denote the issue can be worked on by a contributor label Apr 8, 2025
@melvin-bot melvin-bot bot changed the title Hybrid Android&iOS - Merge account - Paragraphs in "We’re working on it" page have different style on iOS and mweb [$250] Hybrid Android&iOS - Merge account - Paragraphs in "We’re working on it" page have different style on iOS and mweb Apr 8, 2025
Copy link

melvin-bot bot commented Apr 8, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021909687307888709244

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 8, 2025
Copy link

melvin-bot bot commented Apr 8, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@ChavdaSachin
Copy link
Contributor

ChavdaSachin commented Apr 8, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merge account - Paragraphs in "We’re working on it" page have different style on iOS and mweb

What is the root cause of that problem?

Here we are using styles.dblock style which is limited to web(reference) and hence creates inconsistency between ios-Native and web style.

<Text style={[styles.dBlock, styles.textAlignCenter, styles.textSupporting, styles.mt2]}>

What changes do you think we should make in order to solve the problem?

Remove styles.dblock style here.

<Text style={[styles.dBlock, styles.textAlignCenter, styles.textSupporting, styles.mt2]}>

Note

this page is not only limited to hybrid app.

Small changes like adding white space might be needed which could be handled during PR phase.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Better remove the whole wrapper here and join it with previous wrapper.

<Text style={[styles.textSupporting, styles.textAlignCenter]}>{translate('mergeAccountsPage.mergePendingSAML.limitedSupport')}</Text>
<Text style={[styles.dBlock, styles.textAlignCenter, styles.textSupporting, styles.mt2]}>
{translate('mergeAccountsPage.mergePendingSAML.reachOutForHelp.beforeLink')}
<TextLink
onPress={() => {
navigateToConciergeChat();
}}
>
{translate('mergeAccountsPage.mergePendingSAML.reachOutForHelp.linkText')}
</TextLink>
{translate('mergeAccountsPage.mergePendingSAML.reachOutForHelp.afterLink')}
</Text>

<Text style={[styles.textSupporting, styles.textAlignCenter]}>{translate('mergeAccountsPage.mergePendingSAML.limitedSupport')}
    {translate('mergeAccountsPage.mergePendingSAML.reachOutForHelp.beforeLink')}
    <TextLink
        onPress={() => {
            navigateToConciergeChat();
        }}
    >
        {translate('mergeAccountsPage.mergePendingSAML.reachOutForHelp.linkText')}
    </TextLink>
    {translate('mergeAccountsPage.mergePendingSAML.reachOutForHelp.afterLink')}
</Text>

@Pujan92
Copy link
Contributor

Pujan92 commented Apr 8, 2025

I think this issue also needs to be considered in the follow-up PR #47073 (comment)

cc: @slafortune @allroundexperts

@Pujan92
Copy link
Contributor

Pujan92 commented Apr 9, 2025

@slafortune Plz assign this to @allroundexperts and @parasharrajat as this will be handled in their follow-up PR of issue #47073

@ChavdaSachin
Copy link
Contributor

@allroundexperts I've already posted the solution to this issue here .
feel free to use my RCA and save up some time.
cc. @parasharrajat

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 9, 2025
@github-project-automation github-project-automation bot moved this from LOW to Done in [#whatsnext] #quality Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants