-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] Hybrid Android&iOS - Merge account - Paragraphs in "We’re working on it" page have different style on iOS and mweb #59834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @luacmartins ( |
Triggered auto assignment to @slafortune ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Job added to Upwork: https://www.upwork.com/jobs/~021909687307888709244 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Merge account - Paragraphs in "We’re working on it" page have different style on iOS and mweb What is the root cause of that problem?Here we are using
What changes do you think we should make in order to solve the problem?Remove
Note this page is not only limited to hybrid app. Small changes like adding white space might be needed which could be handled during PR phase. What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?NA What alternative solutions did you explore? (Optional)Better remove the whole wrapper here and join it with previous wrapper. App/src/pages/settings/Security/MergeAccounts/MergeResultPage.tsx Lines 139 to 150 in 8648481
<Text style={[styles.textSupporting, styles.textAlignCenter]}>{translate('mergeAccountsPage.mergePendingSAML.limitedSupport')}
{translate('mergeAccountsPage.mergePendingSAML.reachOutForHelp.beforeLink')}
<TextLink
onPress={() => {
navigateToConciergeChat();
}}
>
{translate('mergeAccountsPage.mergePendingSAML.reachOutForHelp.linkText')}
</TextLink>
{translate('mergeAccountsPage.mergePendingSAML.reachOutForHelp.afterLink')}
</Text> |
I think this issue also needs to be considered in the follow-up PR #47073 (comment) |
@slafortune Plz assign this to @allroundexperts and @parasharrajat as this will be handled in their follow-up PR of issue #47073 |
@allroundexperts I've already posted the solution to this issue here . |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max . iOS 18.4
App Component: User Settings
Action Performed:
or
Expected Result:
The paragraphs in "We’re working on it" page will have the same style on iOS app and mweb.
Actual Result:
The paragraphs in "We’re working on it" page have different style on iOS app and mweb.
On iOS, it shows:
We don’t yet support merging accounts on New Expensify. Please take this action on Expensify Classic instead.Feel free to reach out to Concierge if you have any questions!
On mweb, it shows:
We don’t yet support merging accounts on New Expensify. Please take this action on Expensify Classic instead.
Feel free to reach out to Concierge if you have any questions!
Workaround:
Unknown
Platforms:
Screenshots/Videos
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Pujan92The text was updated successfully, but these errors were encountered: