Skip to content

[$250] Merge account - Long email is cut off on magic code page #59757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 18 tasks
lanitochka17 opened this issue Apr 8, 2025 · 13 comments · Fixed by #59911
Closed
2 of 18 tasks

[$250] Merge account - Long email is cut off on magic code page #59757

lanitochka17 opened this issue Apr 8, 2025 · 13 comments · Fixed by #59911
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 8, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.24-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #56911
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Settings > Security
  3. Tap Merge account
  4. Enter long email
  5. Mark "I understand this is not reversible" checkbox
  6. Click Next

Expected Result:

The long email will be wrapped into two lines

Actual Result:

The long email is cut off

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6795521_1744068702443.ScreenRecording_04-08-2025_07-29-36_1.1.mp4

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021909751045190760799
  • Upwork Job ID: 1909751045190760799
  • Last Price Increase: 2025-04-08
  • Automatic offers:
    • dominictb | Reviewer | 106853268
Issue OwnerCurrent Issue Owner: @allroundexperts
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 8, 2025
Copy link

melvin-bot bot commented Apr 8, 2025

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 8, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

github-actions bot commented Apr 8, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@daledah
Copy link
Contributor

daledah commented Apr 8, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

The long email is cut off

What is the root cause of that problem?

We don't add style word-break: 'break-word'

What changes do you think we should make in order to solve the problem?

We should add word-break: 'break-word' to cover case very long email

<View>
<Text style={[styles.mb3]}>
{translate('mergeAccountsPage.accountValidate.lossOfUnsubmittedData')}
<Text style={styles.textStrong}>{email}</Text>.
</Text>
<Text>
{translate('mergeAccountsPage.accountValidate.enterMagicCode')}
<Text style={styles.textStrong}>{email}</Text>.
</Text>
</View>

descriptionStyle={{...descriptionStyle, ...styles.textSupporting}}

Image

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@daledah
Copy link
Contributor

daledah commented Apr 8, 2025

@marcaaron i can help to raise a quick PR if needed

@jasperhuangg
Copy link
Contributor

Yeahh this doesn't need to be a blocker, I can't remember the last time I saw a customer with such a long email address.

@jasperhuangg jasperhuangg added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 8, 2025
@marcaaron marcaaron removed their assignment Apr 8, 2025
@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Apr 8, 2025
@melvin-bot melvin-bot bot changed the title Merge account - Long email is cut off on magic code page [$250] Merge account - Long email is cut off on magic code page Apr 8, 2025
Copy link

melvin-bot bot commented Apr 8, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021909751045190760799

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 8, 2025
Copy link

melvin-bot bot commented Apr 8, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

@dominictb
Copy link
Contributor

This is straightforward. @daledah proposal LGTM

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Apr 9, 2025

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@amyevans
Copy link
Contributor

amyevans commented Apr 9, 2025

@allroundexperts looks like you're fixing this in a polish PR, yeah? I'll assign you. Also, please comment on any other Merge Account polish issues you plan to take so that you can be assigned, our internal engineers have varying levels of awareness of what features are in progress, who's working on what, etc. Thanks!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@allroundexperts
Copy link
Contributor

I am working on this!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants