-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] Merge account - Long email is cut off on magic code page #59757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @marcaaron ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.The long email is cut off What is the root cause of that problem?We don't add style What changes do you think we should make in order to solve the problem?We should add App/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx Lines 126 to 135 in 689e60c
![]() What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)NA Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
@marcaaron i can help to raise a quick PR if needed |
Yeahh this doesn't need to be a blocker, I can't remember the last time I saw a customer with such a long email address. |
Job added to Upwork: https://www.upwork.com/jobs/~021909751045190760799 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb ( |
Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@allroundexperts looks like you're fixing this in a polish PR, yeah? I'll assign you. Also, please comment on any other Merge Account polish issues you plan to take so that you can be assigned, our internal engineers have varying levels of awareness of what features are in progress, who's working on what, etc. Thanks! |
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
I am working on this! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.24-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #56911
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The long email will be wrapped into two lines
Actual Result:
The long email is cut off
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Platforms Tested:
On which of our officially supported platforms was this issue tested:Screenshots/Videos
Add any screenshot/video evidence
Bug6795521_1744068702443.ScreenRecording_04-08-2025_07-29-36_1.1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allroundexpertsThe text was updated successfully, but these errors were encountered: