Skip to content

[$250] Android - App returns to Merge accounts flow when using back button after merging account #59764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
mitarachim opened this issue Apr 8, 2025 · 11 comments · Fixed by #60751
Closed
4 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Apr 8, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #56911
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: User Settings

Action Performed:

  1. Launch Expensify app.
  2. Go to Settings > Security.
  3. Tap Merge account.
  4. Enter email of another account.
  5. Mark "I understand this is not reversible" checkbox.
  6. Click Next.
  7. Enter magic code.
  8. On success page, use device back button.

Expected Result:

App will return to Security page.

Actual Result:

App returns to Merge accounts flow.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6795535_1744070045235.Screen_Recording_20250408_075126_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021915068856610252811
  • Upwork Job ID: 1915068856610252811
  • Last Price Increase: 2025-04-23
Issue OwnerCurrent Issue Owner: @
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Apr 8, 2025
Copy link

melvin-bot bot commented Apr 8, 2025

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 8, 2025

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 8, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mollfpr mollfpr removed the DeployBlocker Indicates it should block deploying the API label Apr 8, 2025
@jasperhuangg jasperhuangg added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 8, 2025
@jasperhuangg
Copy link
Contributor

This doesn't need to be a blocker, very minor bug for a feature that doesn't exist on production. @allroundexperts please fix this in a followup.

@NicMendonca NicMendonca added Weekly KSv2 and removed Daily KSv2 labels Apr 9, 2025
@NicMendonca
Copy link
Contributor

setting this to weekly!

Copy link

melvin-bot bot commented Apr 22, 2025

@NicMendonca this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@zanyrenney zanyrenney added the Daily KSv2 label Apr 23, 2025
@arosiclair arosiclair added External Added to denote the issue can be worked on by a contributor and removed Engineering labels Apr 23, 2025
@melvin-bot melvin-bot bot changed the title Android - App returns to Merge accounts flow when using back button after merging account [$250] Android - App returns to Merge accounts flow when using back button after merging account Apr 23, 2025
Copy link

melvin-bot bot commented Apr 23, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021915068856610252811

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 23, 2025
Copy link

melvin-bot bot commented Apr 23, 2025

Current assignees @parasharrajat and @allroundexperts are eligible for the External assigner, not assigning anyone new.

@arosiclair arosiclair removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 23, 2025
@arosiclair
Copy link
Contributor

Not 100% sure how we should fix this yet. We could try using Navigation.goBack(ROUTES.SETTINGS_SECURITY) before navigating to the success page so that the details and validate pages are removed from the stack. However, I'm afraid that might cause unnecessary animations. Navigation.removeScreenFromNavigationState might be a better alternative.

@allroundexperts
Copy link
Contributor

PR: #60751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
Status: DONE
Development

Successfully merging a pull request may close this issue.

8 participants